Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1014044ybj; Fri, 20 Sep 2019 03:47:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjDsUGoAMz1RbC/Pqg84b6+OXEe5SLR+Ej7v0u3nrwKIYy29m2e2snv77XAmHbF2PP9NTZ X-Received: by 2002:a17:906:1941:: with SMTP id b1mr18217923eje.141.1568976427004; Fri, 20 Sep 2019 03:47:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568976426; cv=none; d=google.com; s=arc-20160816; b=WBWaWW48w1/JTrNN+L6DnC89lABe5y48NeGJbq3lGAFS+BDE57p2T0LUlQMvawN3WF haN/5nTM2IgjkSzifrCzIKjz2VE7KW52nVYbFcaRV9Wv3MXD+3M7/nP6xCUbG0XBFKWY HdtMwfyS2qrlRBfWn0W5sd5E1uPI5BuIkMC72ULng5X1m06NwNUZubdD+kukqpaQMdzU 57CEHELnWR+O+xnC4vsulS9wQbr1L5wJzzEcHVpOY6Dv8M3gIQAEo8tU0TZAR4Tw29NR K4pZb4zdaESmvAQN7J8nl8filg5pc8tv4obvvx9AKRCYlHcu4m2dV4teOychzKeE1I+P oAvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oZ35gwLbXC/Wi2qpuTpt0jMSXf9o4HH8LoAH9VwXJTs=; b=MEcldXvqsj7Hbo42s2JPi88wCAYCup8fffMV6Gk41fgH9x3SWw1aKb9MBQU1lcZb6h XhYV4axPAPFNfwwSu5axoNZkyHT6FUtVYGvZNOXHHrP84Z+SNaESzvoAQqpKCTF8T04s bsKVFzupnX3zTJqBgDXhDd7s/QwMJ/gJSRGXZKIkmJ0DYv0G1nXp1dSzWfXIS7pp5Koj Qir3bE5RSGzdxisPfjNLOmWZ8WhizdBNZmP41zdrCSsXWRrTynluFTiITq7G19xcqG7N K5n+b+ygjq6gP8lmvsAgSskcMeJ5pcFHzv+D2W3K/E/xLXqfff8myERE23SRbrOienOU f46g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="B/t57Yjf"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17si817292ejx.139.2019.09.20.03.46.43; Fri, 20 Sep 2019 03:47:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="B/t57Yjf"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391611AbfISWNu (ORCPT + 99 others); Thu, 19 Sep 2019 18:13:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:53050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732518AbfISWNs (ORCPT ); Thu, 19 Sep 2019 18:13:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F5D121928; Thu, 19 Sep 2019 22:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931227; bh=ldNzaeVAzhULshkzKyV7DHrCylNozB6V+mzzSYdz/6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B/t57Yjffa1yt8gwU89SPE6lFfWNMbE00tQCnLQH0n54p7vUbRHPBhRkIQDyRgQ/O /XFcHRCWG3wiMTdjO5qMTMyA4RGw9/MD4q6eI8t0W7Ht+TjnCeI1bwy3iZAdiY+RbH GUeKFEANwCqtgv8vdPMBrmAhZslQcNaVkhOHU8ug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Stancek , Naresh Kamboju , Trond Myklebust , Sasha Levin Subject: [PATCH 4.19 50/79] NFSv2: Fix write regression Date: Fri, 20 Sep 2019 00:03:35 +0200 Message-Id: <20190919214811.905928438@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214807.612593061@linuxfoundation.org> References: <20190919214807.612593061@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit d33d4beb522987d1c305c12500796f9be3687dee ] Ensure we update the write result count on success, since the RPC call itself does not do so. Reported-by: Jan Stancek Reported-by: Naresh Kamboju Signed-off-by: Trond Myklebust Tested-by: Jan Stancek Signed-off-by: Sasha Levin --- fs/nfs/proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index 89fa9c706b380..0e0335e77ce68 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -616,8 +616,10 @@ static int nfs_proc_pgio_rpc_prepare(struct rpc_task *task, static int nfs_write_done(struct rpc_task *task, struct nfs_pgio_header *hdr) { - if (task->tk_status >= 0) + if (task->tk_status >= 0) { + hdr->res.count = hdr->args.count; nfs_writeback_update_inode(hdr); + } return 0; } -- 2.20.1