Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1248933ybj; Fri, 20 Sep 2019 07:30:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwO9gmzmCyDJ78c5//tDoEeS8SatIvB4hOndibX9iNqTZeJxX3b3SzZ2flFCqcrItpOzQlY X-Received: by 2002:a17:906:7cc4:: with SMTP id h4mr15834395ejp.75.1568989807051; Fri, 20 Sep 2019 07:30:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568989807; cv=none; d=google.com; s=arc-20160816; b=aFc18EPza/IWEdbOefrGA+YvB9R8xj764u+kstpnBmOPf6r6I9OrCBcb7hiK3yBg/5 8OxLbAx+7Bxuh0BZN9DzfWpo0oByyFIq47Tbu3SJwKaTQcOdkhYFgVGVB+ELtogk9UrK LgQi3dIkXm5Ejphr76GSX/SqHvhFI/0ZJu9vQ0NTneTpiy2qP8NW4iTeSmgpxhDrisSG T2ozrtTB6Bg2Afi0UQYRaU1WiHeqTLguZ7atWMBZi7E94hMstzA84pWaLZ5l8lkgDvAE wyqwFLU+m1fb3u9ZHR8gogvDhsjCdIy60bZra3xio+2K9nKcTphKaTkwHaUXBKeVNHUW lxyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ucu9+MqVs6LI3wBmicxndgKo5K+S9BQb7sPbg57ayDo=; b=odTtoDfyi7xBDtSqOwlTmkJKSQS6yF0dv+i5U+4/qYtQGj4VO9j4usI9Z3nC/Muf4z DAvHgUJiaFYrBikQLpnmb47I1AC5hPifZGvkDpxqGA3rVjqUt8igQjh4y6hNniP2qyuO 6v8n294fckwJjRih3JSevUoZhCtQYFsDz5vCw6MCNbhyfqPcBony+QqFpwUIa97dIhTe mkB/L1g7RFIVm2kMtlNw6xMmTuEuJ8KLmNo5nwztNcIOMxsUE8UVpiWTY+z0OzjCDiai IXxdLe4xzvWZsyUgnrahvo+Pzd0VuwGW92aC+kagsY+7IACyKbwLdJLZAGE2q0LVkb9q 3hsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CfnnxvUn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d10si1522220edk.115.2019.09.20.07.29.43; Fri, 20 Sep 2019 07:30:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CfnnxvUn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436586AbfISW3z (ORCPT + 99 others); Thu, 19 Sep 2019 18:29:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:58050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406417AbfISWRD (ORCPT ); Thu, 19 Sep 2019 18:17:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6576217D6; Thu, 19 Sep 2019 22:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931423; bh=mj3U4sRDS8aeanAqrXJcjO6Wq6Bt5NxJ+ZBR9ABdTa0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CfnnxvUnwtZcuLZ5E4QQ6RBCr2GEBQCEE1FQqm5lZJkiB4dtLNDmFMJviKedou2qo 0BMeveSZhn/0k88uLP4guGuW7oqeVYIHblVo2wBZ/AUVbXMdFepFB1AjKvUXpmRYrQ uG1zUw8jctgtSYCsgvSV6qqtiXK1ZWILLPxKjcjw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Stancek , Naresh Kamboju , Trond Myklebust , Sasha Levin Subject: [PATCH 4.14 33/59] NFSv2: Fix write regression Date: Fri, 20 Sep 2019 00:03:48 +0200 Message-Id: <20190919214805.896609158@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214755.852282682@linuxfoundation.org> References: <20190919214755.852282682@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit d33d4beb522987d1c305c12500796f9be3687dee ] Ensure we update the write result count on success, since the RPC call itself does not do so. Reported-by: Jan Stancek Reported-by: Naresh Kamboju Signed-off-by: Trond Myklebust Tested-by: Jan Stancek Signed-off-by: Sasha Levin --- fs/nfs/proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index 73d1f7277e482..eff93315572e7 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -611,8 +611,10 @@ static int nfs_proc_pgio_rpc_prepare(struct rpc_task *task, static int nfs_write_done(struct rpc_task *task, struct nfs_pgio_header *hdr) { - if (task->tk_status >= 0) + if (task->tk_status >= 0) { + hdr->res.count = hdr->args.count; nfs_writeback_update_inode(hdr); + } return 0; } -- 2.20.1