Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1302506ybj; Fri, 20 Sep 2019 08:18:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyiFHdPpUrMY0c3idZMZiKlydcOy4RqAX5W7oRg9PpFTxH428DRJBZsxCccift+8V8tjZyb X-Received: by 2002:aa7:c1d4:: with SMTP id d20mr22157769edp.223.1568992733065; Fri, 20 Sep 2019 08:18:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568992733; cv=none; d=google.com; s=arc-20160816; b=0j08LtDjYZ3xZ/PsFZEssS4P3Bn0n7uAdITGByCDKzH5k4iYzlOj4Vs5FtJDFRAVMr 7UDhcpu2KcAicF5Hcgr1LGFQUhpWkO1mL8vWH3lvZDJKLmkm/fPaucje8Hm0jXA9GfZI sGfEw223vohyREdZ6zp8v4cdIje3ht+LxqOc8JXl8gZPAC0Hh5GkxuUuqHpnvxpTdw5B m2qI+HEUALbRKmdRzip/W+rll3pWlB0QHep5FlL9emXgV4KOJaMK0tToDPEjEhi+RMW9 tVIq0+UVUuBxIrAvmnMCLfvgz9S1WPj4V1PPvPguWj3dcKajS2lYH1y9Pv0LxA9mvTS5 PEEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DpwU+IyuwUvxN6BLiZZSQvsgjToNSr280V4CT9217hI=; b=CA6CrRxNKutPPf+Zvd3Cyi0HfraBpRIPvjJ9gRJRv7lT4AFyCEZOUmXAuJiQzVyVpS AYweQ77nhGlZi2bl/ltIjy9fMgHzSElsrNgjA+Bl9fBkCAeExUGZ8Hj+uU0/M1KKdpT/ WVatWyFSAncjZ0LjM2BF2TYWX7nFTlJpnN7Y/loHn2D4Ni9x0Jy8hr7y4b2Q9NIac6qK Z4tEohJr4YekCnaUto4tpw4tAwt7+E8XGuWDuyidcUhwZuWYk7eR4qeS9Ipc9EaeUylH PWR5TERO69Vhz8uBqX2j4dxcRvof5Vj9GPTD2t9BXwPPctRU0hugSXc2uhLpvYleWteG H5FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eVxNsJsP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l22si1636161edb.241.2019.09.20.08.18.27; Fri, 20 Sep 2019 08:18:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eVxNsJsP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393045AbfISWVu (ORCPT + 99 others); Thu, 19 Sep 2019 18:21:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:33586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733140AbfISWTr (ORCPT ); Thu, 19 Sep 2019 18:19:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1247F20678; Thu, 19 Sep 2019 22:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931586; bh=9Cb/7Dxwdgc3rSVccFfgH4ZMgneEXgFibVvzSzLCIyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eVxNsJsP/82zj3yRy7Pxx2t+lbBaQ9/jhvGiZQfj40v9rb3r5ek6+yTG/oSEAJpsO VHKK+8zNo2h7bppS/Xbo+jhWdn63PCh2cgdiopKP8onNYk55BBZsfxXeKbmpOZ6KXC avcPtY5vacF1IZ6LEXgu2Xi/gz2t1xOOgCG7ap+M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xin Long , Marcelo Ricardo Leitner , Neil Horman , "David S. Miller" Subject: [PATCH 4.9 09/74] sctp: use transport pf_retrans in sctp_do_8_2_transport_strike Date: Fri, 20 Sep 2019 00:03:22 +0200 Message-Id: <20190919214803.931884674@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214800.519074117@linuxfoundation.org> References: <20190919214800.519074117@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long [ Upstream commit 10eb56c582c557c629271f1ee31e15e7a9b2558b ] Transport should use its own pf_retrans to do the error_count check, instead of asoc's. Otherwise, it's meaningless to make pf_retrans per transport. Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg") Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Acked-by: Neil Horman Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -509,7 +509,7 @@ static void sctp_do_8_2_transport_strike if (net->sctp.pf_enable && (transport->state == SCTP_ACTIVE) && (transport->error_count < transport->pathmaxrxt) && - (transport->error_count > asoc->pf_retrans)) { + (transport->error_count > transport->pf_retrans)) { sctp_assoc_control_transport(asoc, transport, SCTP_TRANSPORT_PF,