Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1363823ybj; Fri, 20 Sep 2019 09:16:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqw6vY/vHFN/7r06cMRvQwFpOldSAgONnk4wfD3ezO51Ye9b4qNm7qsJDdPSNYFZaWoC7FQj X-Received: by 2002:a05:6402:1e4:: with SMTP id i4mr22895086edy.31.1568996183662; Fri, 20 Sep 2019 09:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568996183; cv=none; d=google.com; s=arc-20160816; b=g+lxGoxMsFPWJE+Ov1nu3Tod8X46gwbPaB9s/i7XoR9UTG7TRDaMDWF/UiAVy3kS97 yzMH6BnAfNn36zL3404koYx3X40+R9gy0dPzOEmLwXJnab11rE8pAu6X7ZVRX1fl4isI J1Oky2Cqvf5SZpFb1VG3sfZ4abfggAtEt6Y2HuzETbclDrIs4hHomcYrr2Yluc2k54sL QIcLAHV5LowT10LbEbzF3rkgNzq9byGGjyaqexrQoRn2zMDFXg3dx0JFzskepCtLl6oC H6DbyTl0NRARSHDDHNnsnyPQSb0aYS7F6juqY9XXIEpyMqRVQRqYRUl/gaRA1o/j/7/r N+BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=o5S8vyOh8JWDirMIximup54A0BKMVjxHqdgihyldzdw=; b=mYZsMt2z9V1OJ+sEdl93ve3aRAoMmqJ3byeceX1DyfxRxox3W0qSUo2ETI5TDeJXgE sh3eXN4M9Ll4J6uX+ECo3MD/uqYemjFDZH8QAoXarysUcJVFdVbYMChHHMQpKp3DBPsh oU8nvaHaopNVZ130TiPMM/pZufzRs5FdUkN6WVy/RJ2wBS8Q97bV+ziLhWhKXGdQ4cgL KHpy6i5Sc/Q93eVT01sXq48odQVQa0Y75t8axTfmYf5JGHd1IbcDUI7HqOo98/hkej6k EMbDyIr552FoB/ibx3ONz23R2A0HcgblVw4mM/z4Cq1OBjWkve99jzhflx98y4c6n2Nd o2wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R1jlu80H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o21si1300171ejr.208.2019.09.20.09.16.00; Fri, 20 Sep 2019 09:16:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R1jlu80H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406479AbfISWdO (ORCPT + 99 others); Thu, 19 Sep 2019 18:33:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:50656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405883AbfISWLx (ORCPT ); Thu, 19 Sep 2019 18:11:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 319E6218AF; Thu, 19 Sep 2019 22:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931112; bh=vaGfJQtgEX20SkVdECVKbd9a+wVF0Ps8/spkJNFEFtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R1jlu80HpkLtWC6Z4jz8NDPcu4ptgBslJdh/w/4pqOf3GugfYK2W7OeoeopYFfvPz 4fmiff28EBxiA+YRgSXABzPrh2jRd4CT1p4vtGBOxPwiaOEpjko4SO1ntLXmNjnAiK RWus/8GYOwUtOoHhFx8/7blBDs49axC8LK/Kqe+I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Bogdanov , Igor Russkikh , "David S. Miller" , Sasha Levin Subject: [PATCH 5.2 103/124] net: aquantia: reapply vlan filters on up Date: Fri, 20 Sep 2019 00:03:11 +0200 Message-Id: <20190919214822.949275123@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214819.198419517@linuxfoundation.org> References: <20190919214819.198419517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Bogdanov [ Upstream commit c2ef057ee775e229d3138add59f937d93a3a59d8 ] In case of device reconfiguration the driver may reset the device invisible for other modules, vlan module in particular. So vlans will not be removed&created and vlan filters will not be configured in the device. The patch reapplies the vlan filters at device start. Fixes: 7975d2aff5afb ("net: aquantia: add support of rx-vlan-filter offload") Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.c b/drivers/net/ethernet/aquantia/atlantic/aq_main.c index 5315df5ff6f83..4ebf083c51c5f 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_main.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_main.c @@ -61,6 +61,10 @@ static int aq_ndev_open(struct net_device *ndev) if (err < 0) goto err_exit; + err = aq_filters_vlans_update(aq_nic); + if (err < 0) + goto err_exit; + err = aq_nic_start(aq_nic); if (err < 0) goto err_exit; -- 2.20.1