Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5aa1d16d90b3fc4a4aa989a4082f0e2fb776998a.camel@linux.ibm.com>
Subject: Re: [PATCH v2 1/1] powerpc/pseries/hotplug-memory.c: Change rc
 variable to bool
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Michael Ellerman <mpe@ellerman.id.au>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     David Hildenbrand <david@redhat.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Pavel Tatashin <pavel.tatashin@microsoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oscar Salvador <osalvador@suse.de>,
        Nathan Fontenot <nfont@linux.vnet.ibm.com>,
        Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
        YueHaibing <yuehaibing@huawei.com>, Rob Herring <robh@kernel.org>
Date:   Thu, 19 Sep 2019 22:57:04 -0300
In-Reply-To: <dd417c2c-83f6-b3e0-0a87-25996af76db5@redhat.com>
References: <20190802133914.30413-1-leonardo@linux.ibm.com>
         <dd417c2c-83f6-b3e0-0a87-25996af76db5@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-ONyhHFL4Nn1SjgHz8m1T"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-ONyhHFL4Nn1SjgHz8m1T
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

Any feedback on this patch?

Best regards,


On Fri, 2019-08-02 at 15:45 +0200, David Hildenbrand wrote:
> On 02.08.19 15:39, Leonardo Bras wrote:
> > Changes the return variable to bool (as the return value) and
> > avoids doing a ternary operation before returning.
> >=20
> > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> > ---
> > Changes in v2:
> >   - Restore previous and-ing logic on rc.
> >=20
> >  arch/powerpc/platforms/pseries/hotplug-memory.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/pow=
erpc/platforms/pseries/hotplug-memory.c
> > index 8e700390f3d6..c126b94d1943 100644
> > --- a/arch/powerpc/platforms/pseries/hotplug-memory.c
> > +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
> > @@ -338,7 +338,7 @@ static int pseries_remove_mem_node(struct device_no=
de *np)
> >  static bool lmb_is_removable(struct drmem_lmb *lmb)
> >  {
> >  	int i, scns_per_block;
> > -	int rc =3D 1;
> > +	bool rc =3D true;
> >  	unsigned long pfn, block_sz;
> >  	u64 phys_addr;
> > =20
> > @@ -363,11 +363,11 @@ static bool lmb_is_removable(struct drmem_lmb *lm=
b)
> >  		if (!pfn_present(pfn))
> >  			continue;
> > =20
> > -		rc &=3D is_mem_section_removable(pfn, PAGES_PER_SECTION);
> > +		rc =3D rc && is_mem_section_removable(pfn, PAGES_PER_SECTION);
> >  		phys_addr +=3D MIN_MEMORY_BLOCK_SIZE;
> >  	}
> > =20
> > -	return rc ? true : false;
> > +	return rc;
> >  }
> > =20
> >  static int dlpar_add_lmb(struct drmem_lmb *);
> >=20
>=20
> Yeah, why not
>=20
> Reviewed-by: David Hildenbrand <david@redhat.com>
>=20

--=-ONyhHFL4Nn1SjgHz8m1T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl2EMfAACgkQlQYWtz9S
ttQDvRAAwUnVrutNNTkOUXjvHQgdRmF4pzxk4wHrWFA7lTYBdxd+cLK9+XUQEESk
nevbtmOHkjztygsa7jHuN5GJHz3SMkU5nWnUsQE1pnDrfFW3uuLoTV/o/7FHy3ph
wRUuwahCyAZ9e0viOlYAVZrzaXOStFYL87lFfB4DhUeK2XB/t4BlRazpXJeW++iV
IKu3NZHwde6TJ1HnWxrDfJKGgXI3HFQyhIn4owPPCgX81L86z817nZX99t9E0FvQ
lToxlei5I+gU/pzemowVmlU9gTVH/9rEonvq/PbL4QAsn/L5vfr/2OntEJjR9J0b
wwcH9ezlgC/uJp94YuXvUQMnMuTEsBjg+hQyuUoDowXYbpsPxUgXcS4m5L+VuVM2
ofg8uvhWHfl8g+8Wl1IuChS7Hj2oUBxYzpfICOak1aVsKiShuwv/kq+hmJf9iuom
Lv7INPBCRGJ9AhzKfY6KSaX3PloE3BZs1D5auljymr/3MtrXaRReGFzmLWPDv7np
dybb2e88BpO7h5lZR/bOrFXgw9ni0Pk2r9XfOg5uBBokJZgTiRoQMbBcPpHH+23M
4mVIMswxby2UmcuVBqhcS3SkpdIyY1ywe1PU2QwaQw+IPzAE/ndnpFOp1/JU1ZUE
ezwEQ0vbxym7/kHbfcoQk9X4kgqXIxNcYDKwrqvPabqfta5PPdw=
=85wg
-----END PGP SIGNATURE-----

--=-ONyhHFL4Nn1SjgHz8m1T--