Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Sep 2019 08:12:09 +0200
From:   Maxime Ripard <mripard@kernel.org>
To:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@siol.net>
Cc:     roman.stratiienko@globallogic.com, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sun4i: Use vi plane as primary
Message-ID: <20190920061209.ostddxvzf6xwrmdp@gilmour>
References: <20190919123703.8545-1-roman.stratiienko@globallogic.com>
 <20190919171754.x6lq73cctnqsjr4v@gilmour>
 <104595190.vWb6g8xIPX@jernej-laptop>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3ylh7nsjnj6zhso3"
Content-Disposition: inline
In-Reply-To: <104595190.vWb6g8xIPX@jernej-laptop>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--3ylh7nsjnj6zhso3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 19, 2019 at 08:15:49PM +0200, Jernej =C5=A0krabec wrote:
> Dne =C4=8Detrtek, 19. september 2019 ob 19:17:54 CEST je Maxime Ripard na=
pisal(a):
> > >
> > > Tested on Android.
> > >
> > > Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >
> > It sounds like a workaround more than an actual fix.
> >
> > If the VI planes can't use the alpha, then we should just stop
> > reporting that format.
> >
> > Jernej, what do you think?
>
> Commit message is misleading. What this commit actually does is moving pr=
imary
> plane from first UI plane to bottom most plane, i.e. first VI plane. Howe=
ver, VI
> planes are scarce resource, almost all mixers have only one. I wouldn't s=
et it
> as primary, because it's the only one which provide support for YUV forma=
ts.
> That could be used for example by video player for zero-copy rendering.
> Probably most apps wouldn't touch it if it was primary (that's usually
> reserved for window manager, if used).

Yeah, we definitely don't want to use it as primary and prevent the
video display.

> I left few formats with alpha channel exposed by VI planes, just because =
they
> don't have equivalent format without alpha. But I'm fine with removing th=
em if
> you all agree on that.

If there's no alpha support, then yeah, we shouldn't expose the format
at all, and then we can either add the new formats, or just not expose
them if they are exotic enough.

Maxime

--3ylh7nsjnj6zhso3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXYRtuQAKCRDj7w1vZxhR
xeqxAP47vhP9Zt2VoOykoxUSb+0IORx7/qZJWXiMTdUUPVILWQEAgu6XBa76F/RH
QcYmCCHcvowZxHbGSkRFp2//2Y0bsAw=
=16hs
-----END PGP SIGNATURE-----

--3ylh7nsjnj6zhso3--