Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Hanna Hawa <hhhawa@amazon.com>
CC:     "bp@alien8.de" <bp@alien8.de>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v3 2/2] edac: move edac_device_handle_*() API functions to
 header
Thread-Topic: [PATCH v3 2/2] edac: move edac_device_handle_*() API functions
 to header
Thread-Index: AQHVb3+WHFNLttAdVEqF33Cg+Ln7bQ==
Date:   Fri, 20 Sep 2019 06:49:45 +0000
Message-ID: <20190920064937.owwv5n663kwmnbb7@rric.localdomain>
References: <20190919171713.8060-1-hhhawa@amazon.com>
 <20190919171713.8060-3-hhhawa@amazon.com>
In-Reply-To: <20190919171713.8060-3-hhhawa@amazon.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d508bdac-309e-4ee6-1418-08d73d96b920
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2432;
x-ms-traffictypediagnostic: MN2PR18MB2432:
x-microsoft-antispam-prvs: <MN2PR18MB2432B1D36757C687E86D03DDD9880@MN2PR18MB2432.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 0166B75B74
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(189003)(199004)(66066001)(3846002)(71200400001)(305945005)(71190400001)(186003)(26005)(7416002)(316002)(4326008)(6916009)(7736002)(102836004)(6506007)(256004)(53546011)(66446008)(64756008)(386003)(66556008)(66476007)(25786009)(66946007)(9686003)(6512007)(52116002)(6246003)(76176011)(99286004)(478600001)(81156014)(486006)(6436002)(86362001)(2906002)(6486002)(14454004)(8936002)(8676002)(81166006)(476003)(229853002)(54906003)(11346002)(5660300002)(1076003)(446003)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2432;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: QR1SjkToGuEiKsZ9x7cpAKgkpFg357jIQ58w5p8ytQE0HjplAjeEjXokZEIbR/Pqa/tqb1hYLhw7063yr0fP+XV0lr9iXEoUaigQLO+Cd9rxdij9J7bCeAyBXKmPJ5yfy+9riG2tWhCxDbEHzGpog1U/doQEKnw6sR2Jtbb9laU8F/MGkG6CmOCG7/bPIVcony+CtnsIluy1k5tcYDO7OzIwG+0LrLendqseDdfRYlHpxT09UfmNu1vD7e3X5CpjD6eWr8B4tB/ZzB1WqHyYCNP7eUXc0FZsUzv85bpFDBueE7n4u7cWdX6wGfG8uIouxHNSNazIUzujFgdDq7dQNeUSAp30qTxyHLGFqao3i9xrLOXDcV0BwnzQWdvi94tTqGMDnO+fIAAXGsi8VxGUj3YRGZXnw6YAZPfUAu8mpuk=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0302A7159C9B82458BA77E0CB1092993@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d508bdac-309e-4ee6-1418-08d73d96b920
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2019 06:49:45.8259
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L6x+JgOqrWH8u6pod+368Pm57PQ7jm53Kf/hun0rwH3tqs8wuX4cbt7H3GLDOX6Wuk6E++28EoVM43wrqOvu3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2432
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-20_01:2019-09-19,2019-09-20 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19.09.19 18:17:13, Hanna Hawa wrote:
> Move edac_device_handle_*() functions from source file to header file as
> inline funtcion that use the new API with single error.
>=20
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>

With the changes below it looks good to me:

Acked-by: Robert Richter <rrichter@marvell.com>

Thanks,

-Robert

> diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h
> index 30dc5f5979c8..796ea134a691 100644
> --- a/drivers/edac/edac_device.h
> +++ b/drivers/edac/edac_device.h
> @@ -285,29 +285,6 @@ extern int edac_device_add_device(struct edac_device=
_ctl_info *edac_dev);
>   */
>  extern struct edac_device_ctl_info *edac_device_del_device(struct device=
 *dev);
> =20
> -/**
> - * edac_device_handle_ue():
> - *	perform a common output and handling of an 'edac_dev' UE event
> - *
> - * @edac_dev: pointer to struct &edac_device_ctl_info
> - * @inst_nr: number of the instance where the UE error happened
> - * @block_nr: number of the block where the UE error happened
> - * @msg: message to be printed
> - */
> -extern void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
> -				int inst_nr, int block_nr, const char *msg);
> -/**
> - * edac_device_handle_ce():
> - *	perform a common output and handling of an 'edac_dev' CE event
> - *
> - * @edac_dev: pointer to struct &edac_device_ctl_info
> - * @inst_nr: number of the instance where the CE error happened
> - * @block_nr: number of the block where the CE error happened
> - * @msg: message to be printed
> - */
> -extern void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
> -				int inst_nr, int block_nr, const char *msg);
> -

Just put in the inline replacement here.

>  /**
>   * edac_device_alloc_index: Allocate a unique device index number
>   *
> @@ -357,4 +334,18 @@ static inline void edac_device_handle_ue_count(struc=
t edac_device_ctl_info *edac
>  {
>  	__edac_device_handle_ue(edac_dev, count, inst_nr, block_nr, msg);
>  }
> +
> +static inline void edac_device_handle_ce(struct edac_device_ctl_info *ed=
ac_dev,
> +					 int inst_nr, int block_nr,

No need for this linebreak.

> +					 const char *msg)
> +{
> +	__edac_device_handle_ce(edac_dev, 1, inst_nr, block_nr, msg);
> +}
> +
> +static inline void edac_device_handle_ue(struct edac_device_ctl_info *ed=
ac_dev,
> +					 int inst_nr, int block_nr,

Same here.

> +					 const char *msg)
> +{
> +	__edac_device_handle_ue(edac_dev, 1, inst_nr, block_nr, msg);
> +}
>  #endif
> --=20
> 2.17.1
>=20