Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1464808ybj; Fri, 20 Sep 2019 10:54:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZnAMrNWyk8XVYESV6sZrPor253MmKfzoO7fk8WaJFOfW1bpv4Ak2QYnPWKm1aAG2ktJDp X-Received: by 2002:a50:b6aa:: with SMTP id d39mr22865029ede.16.1569002094936; Fri, 20 Sep 2019 10:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569002094; cv=none; d=google.com; s=arc-20160816; b=cqbeRCcGi7FCI/ZcvReMMv2w1DFROh0zyxB3hZaMNtGAGR2w/FhwNacZ8mK1GVJkjf FgdX1phpQyoKpRk2UWQ/vkkQOFQnidyNBk9IxRQRUeSk1q5d68rxfua8eQLRBvcYCNAf H/lkwTfSnISylFOr9cHanZZUGN0JNnVMwiCXCCTSqlKq3wPRahWfG90UQ+RI3JMVBp6w 4xgH0diIhBJzu/TXKqecqi0/fzq9NC/WmbvKGk4DgQet05lMcFuK0AvCsnJjzQpDGv/A yC3BJrEKuKLG1hd8CNFNTtY/NA8/oF7cZQStZTXcdQCJjuSrFSR76cuoxEld6m8FaBTx OMCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature; bh=bZYM89LrVSj9GDJdE/0jlpCtJAYjLDp9wahp0EyOTbU=; b=Hj4txOrMpt6Ou8J6mArRQh/NFXSgM4ZxkuSGsCPdZmltpPEXDYGG7YosWIenOjksTp RHRuWFp3oKrCVH1NbfVQTz2OYxlxCU/+pjTm7dqXoLP9gMb8sG9xCCWzTtVKvjSUhN5P W6ud8Wd6SedC9yfoy8Rd2xK5eoNucIIdqQTv+b+NPeJiGTIvIoW7kEwGHyuHE2u9uevB aZWyGkGQq6w9+WJ2JkaiZ/6jZmITR05KHh1k7Vc2kS0Gub18W/Z0jqqhtgYvMjTFFEWb ygQ6BaPRoiaOu0moc4XAJIz9uqMBp0ohQfWcXEzytV+vdOJKdhPpbmc73pktKu4SUvZM qw3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=kTjQyByP; dkim=pass header.i=@codeaurora.org header.s=default header.b=WGsKuACj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si1728523edr.446.2019.09.20.10.54.31; Fri, 20 Sep 2019 10:54:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=kTjQyByP; dkim=pass header.i=@codeaurora.org header.s=default header.b=WGsKuACj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437781AbfITIE5 (ORCPT + 99 others); Fri, 20 Sep 2019 04:04:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37734 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437722AbfITIE4 (ORCPT ); Fri, 20 Sep 2019 04:04:56 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 62CEF616BA; Fri, 20 Sep 2019 08:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568966695; bh=GZAlYah0lgBo/IVKZbnqPeDUaKVAPxsY/Fvwv9PSHKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kTjQyByPyEd8yvbaVtZiS6+/wcMpJHOY8OAfInopHJZAccAwpghbPANWktIe8TqUY vQ21OpiC+BoLCJyVmGeGGcOz/HhggkpYylyAn/OHuf01cvenkq82UfeW5l44zRMes0 Zme72eCM72x4HN3QLCVLDot2XNrT3Uxg6Gezf4Zs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-253.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 222DA615B0; Fri, 20 Sep 2019 08:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568966693; bh=GZAlYah0lgBo/IVKZbnqPeDUaKVAPxsY/Fvwv9PSHKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WGsKuACjm+va54PNd5B52+3RSEiPIgjto5K7d/z5rkKuSxfsMe885V3/Z7BXqvPPp unVcHkPWN+RDmP00g82PrXM+PEkJTU5X1lssVS88BMtX3LSluDmVcd0CS78zdDT4in Z2CuPI7eJH5/H9o2bUHmld0nxEYrUYTlICmQeO3M= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 222DA615B0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org From: Sai Prakash Ranjan To: Robin Murphy , Will Deacon , Joerg Roedel , iommu@lists.linux-foundation.org, Stephen Boyd , Vivek Gautam , bjorn.andersson@linaro.org, Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , Sai Prakash Ranjan Subject: [PATCHv7 2/3] firmware/qcom_scm: Add scm call to handle smmu errata Date: Fri, 20 Sep 2019 13:34:28 +0530 Message-Id: <30e1aeb6032c869679edc4eb36783468adcc7e40.1568966170.git.saiprakash.ranjan@codeaurora.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivek Gautam Qcom's smmu-500 needs to toggle wait-for-safe sequence to handle TLB invalidation sync's. Few firmwares allow doing that through SCM interface. Add API to toggle wait for safe from firmware through a SCM call. Signed-off-by: Vivek Gautam Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd Signed-off-by: Sai Prakash Ranjan --- drivers/firmware/qcom_scm-32.c | 5 +++++ drivers/firmware/qcom_scm-64.c | 13 +++++++++++++ drivers/firmware/qcom_scm.c | 6 ++++++ drivers/firmware/qcom_scm.h | 5 +++++ include/linux/qcom_scm.h | 2 ++ 5 files changed, 31 insertions(+) diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c index 215061c581e1..bee8729525ec 100644 --- a/drivers/firmware/qcom_scm-32.c +++ b/drivers/firmware/qcom_scm-32.c @@ -614,3 +614,8 @@ int __qcom_scm_io_writel(struct device *dev, phys_addr_t addr, unsigned int val) return qcom_scm_call_atomic2(QCOM_SCM_SVC_IO, QCOM_SCM_IO_WRITE, addr, val); } + +int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, bool enable) +{ + return -ENODEV; +} diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c index 65d772b7fd1e..76867868042a 100644 --- a/drivers/firmware/qcom_scm-64.c +++ b/drivers/firmware/qcom_scm-64.c @@ -552,3 +552,16 @@ int __qcom_scm_io_writel(struct device *dev, phys_addr_t addr, unsigned int val) return qcom_scm_call(dev, QCOM_SCM_SVC_IO, QCOM_SCM_IO_WRITE, &desc, &res); } + +int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, bool en) +{ + struct qcom_scm_desc desc = {0}; + struct arm_smccc_res res; + + desc.args[0] = QCOM_SCM_CONFIG_ERRATA1_CLIENT_ALL; + desc.args[1] = en; + desc.arginfo = QCOM_SCM_ARGS(2); + + return qcom_scm_call_atomic(dev, QCOM_SCM_SVC_SMMU_PROGRAM, + QCOM_SCM_CONFIG_ERRATA1, &desc, &res); +} diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 4802ab170fe5..a729e05c21b8 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -345,6 +345,12 @@ int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) } EXPORT_SYMBOL(qcom_scm_iommu_secure_ptbl_init); +int qcom_scm_qsmmu500_wait_safe_toggle(bool en) +{ + return __qcom_scm_qsmmu500_wait_safe_toggle(__scm->dev, en); +} +EXPORT_SYMBOL(qcom_scm_qsmmu500_wait_safe_toggle); + int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val) { return __qcom_scm_io_readl(__scm->dev, addr, val); diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom_scm.h index 99506bd873c0..baee744dbcfe 100644 --- a/drivers/firmware/qcom_scm.h +++ b/drivers/firmware/qcom_scm.h @@ -91,10 +91,15 @@ extern int __qcom_scm_restore_sec_cfg(struct device *dev, u32 device_id, u32 spare); #define QCOM_SCM_IOMMU_SECURE_PTBL_SIZE 3 #define QCOM_SCM_IOMMU_SECURE_PTBL_INIT 4 +#define QCOM_SCM_SVC_SMMU_PROGRAM 0x15 +#define QCOM_SCM_CONFIG_ERRATA1 0x3 +#define QCOM_SCM_CONFIG_ERRATA1_CLIENT_ALL 0x2 extern int __qcom_scm_iommu_secure_ptbl_size(struct device *dev, u32 spare, size_t *size); extern int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr, u32 size, u32 spare); +extern int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, + bool enable); #define QCOM_MEM_PROT_ASSIGN_ID 0x16 extern int __qcom_scm_assign_mem(struct device *dev, phys_addr_t mem_region, size_t mem_sz, diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h index 2d5eff506e13..ffd72b3b14ee 100644 --- a/include/linux/qcom_scm.h +++ b/include/linux/qcom_scm.h @@ -58,6 +58,7 @@ extern int qcom_scm_set_remote_state(u32 state, u32 id); extern int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare); extern int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size); extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare); +extern int qcom_scm_qsmmu500_wait_safe_toggle(bool en); extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val); extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val); #else @@ -97,6 +98,7 @@ qcom_scm_set_remote_state(u32 state,u32 id) { return -ENODEV; } static inline int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare) { return -ENODEV; } static inline int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size) { return -ENODEV; } static inline int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) { return -ENODEV; } +static inline int qcom_scm_qsmmu500_wait_safe_toggle(bool en) { return -ENODEV; } static inline int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val) { return -ENODEV; } static inline int qcom_scm_io_writel(phys_addr_t addr, unsigned int val) { return -ENODEV; } #endif -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation