Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190918110541.38124-1-roman.stratiienko@globallogic.com>
 <9229663.7SG9YZCNdo@jernej-laptop> <20190920062020.zyt5ng6cxtu6muye@gilmour>
In-Reply-To: <20190920062020.zyt5ng6cxtu6muye@gilmour>
From:   Roman Stratiienko <roman.stratiienko@globallogic.com>
Date:   Fri, 20 Sep 2019 13:14:30 +0300
Message-ID: <CAODwZ7sJ9g4fycde5Yk1sRYW6WuNtsgXOf34GJMma0rKMyc0QQ@mail.gmail.com>
Subject: Re: drm/sun4i: Add missing pixel formats to the vi layer
To:     Maxime Ripard <mripard@kernel.org>
Cc:     =?UTF-8?Q?Jernej_=C5=A0krabec?= <jernej.skrabec@siol.net>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 20, 2019 at 9:20 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> On Thu, Sep 19, 2019 at 08:53:10PM +0200, Jernej =C5=A0krabec wrote:
> > Dne sreda, 18. september 2019 ob 13:05:41 CEST je
> > roman.stratiienko@globallogic.com napisal(a):
> > > From: Roman Stratiienko <roman.stratiienko@globallogic.com>
> > >
> > > According to Allwinner DE2.0 Specification REV 1.0, vi layer supports=
 the
> > > following pixel formats:  ABGR_8888, ARGB_8888, BGRA_8888, RGBA_8888
> >
> > It's true that DE2 VI layers support those formats, but it wouldn't cha=
nge
> > anything because alpha blending is not supported by those planes. These
> > formats were deliberately left out because their counterparts without a=
lpha
> > exist, for example ABGR8888 <-> XBGR8888. It would also confuse user, w=
hich
> > would expect that alpha blending works if format with alpha channel is
> > selected.
>
> I'm not too familiar with the DE2 code, but why is alpha not working
> if the VI planes support formats with alpha?

Good question. It mentioned in the datasheet
https://linux-sunxi.org/images/7/7b/Allwinner_DE2.0_Spec_V1.0.pdf
on page 95: "All ui layers' alpha is useless"
And my experiments proves it.

My assumption that vi uses post-processing that cuts out alpha values.

>
> Thanks!
> Maxime


--=20
Best regards,
Roman Stratiienko
Global Logic Inc.