Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp440963ybj; Sat, 21 Sep 2019 04:56:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyq4Bhn7tHu8//rnUsWxEwC0RgclIVhIuVfZjDZTORw16nFcgQKllkxfL2ZOzQWVbmRafHd X-Received: by 2002:a17:906:4910:: with SMTP id b16mr22500660ejq.301.1569067011025; Sat, 21 Sep 2019 04:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569067011; cv=none; d=google.com; s=arc-20160816; b=kAh4NpT2MDfdrUG/Bu2d7griYHVJzSTa6rssgJ5K5T7ebpZWBJ1IneR+32WvZ3+gMA u8Y+RTmSwF/wLmQfjOH+godhOXe3Cxe3yRldvLlebogPF3GV1JmX7ARNPHeSVEEQdrn7 XBMKbhF6XNPJVltQTKQwBIl882XS6pq4aVhqOyvrJElSPGdtDz+cGDuXUCrzCyNx0FWu OkjNA+K3POKbtvAezsXCuWE+HgsNPqDEasU0V0vLCMa0Y7LVJJwUK33dlKYBF+bNH07r 4sW97taT0B1bHpyVTmaDuK8LI7W7mZdXQfIkzjnIkO8zcTeL4oIw3X+UrPGKa6/r9Q1C hX/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=B0gRBX2sU0Z6OKmHo7Z4yIU03olB4csImxHyIILBwAA=; b=OEfl+WwC5e2UBT5IsvZShSQZN+nAn1woY4iKKEWakqxp9VSz583/Pwu6qu2FRkzoRs 4taUqkhMGeeMQhDoQ4jfleAEx4xbjpYh5mOq+qpg6r/uyU33KTT8rra1B9bKYUT7ckfc M6f5do7Ba4ThkXHNHad91d98qUX0PzxQWWMGIkQzBt7DgrVUh+gMaPAU8FUAL9SBG87K UDblQtXOWiNeKXi9BaJ0q1JSGf8/evKq/QPQKlRQuD91U5X+y3ec0eqMCE9gwXWhqS/P uHOkvgR7b8pu+yNNYzgiu6lS5yNBzGpz3eQeEEXY4GpWZkPhH7I7AC/1zY32T7LjWF8l p9Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y26si3095802edv.134.2019.09.21.04.56.25; Sat, 21 Sep 2019 04:56:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408583AbfITJsL (ORCPT + 99 others); Fri, 20 Sep 2019 05:48:11 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43171 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405771AbfITJsK (ORCPT ); Fri, 20 Sep 2019 05:48:10 -0400 Received: from mail-wm1-f72.google.com ([209.85.128.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iBFWL-0005Aq-0s for linux-kernel@vger.kernel.org; Fri, 20 Sep 2019 09:48:09 +0000 Received: by mail-wm1-f72.google.com with SMTP id g82so955965wmg.9 for ; Fri, 20 Sep 2019 02:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=B0gRBX2sU0Z6OKmHo7Z4yIU03olB4csImxHyIILBwAA=; b=JC/YpPNc7WOKKAV8XgOhJxswjxjIAgtPkJYkbRcKMSabGYPOPxPNhbIJizxFuQkv+K 860kbqFYefiTuRZNdksbIP58N7WOL5o2bbKe/Z6ZvpU0CWAYucd2E8NAY+RWZ1Kgj5i/ iLt3/DKdeq2E5qbkf6tOCUzueGTkXpHtBtthsTQXht1vDO7mNNaqQkNhYYGw3FZPkRuf WhWbLMXee7pykufUmnx2DBMGkaHOelgkiB0LnbiojoQVi8lxsoPNr/ASgnqdgS3yPNqO fi7FvKhohb+Wczm8t3diwgtpzty/x6MfyyNdznuOrRi5BN2X8nlVQJiX113m73kgdwAK OPcQ== X-Gm-Message-State: APjAAAWysRPp1Z/0BMNFDeupgaJQeFGDLQTzzxRFfz48y+Vb/hOhogms Ir12kX6EFRE5cpGc377gwJON/bpYKGNgAVFBk4V1GQr0NHmGwwDFQw6nJogwcPBpyvshlq5GKiH 4hJ0rKmjcZAz5UEdAMxE0iDDunwldkPeTvdz5YU+Shg== X-Received: by 2002:a5d:430f:: with SMTP id h15mr11239560wrq.177.1568972888806; Fri, 20 Sep 2019 02:48:08 -0700 (PDT) X-Received: by 2002:a5d:430f:: with SMTP id h15mr11239545wrq.177.1568972888657; Fri, 20 Sep 2019 02:48:08 -0700 (PDT) Received: from canonical.c.hoisthospitality.com (static-dcd-cqq-121001.business.bouyguestelecom.com. [212.194.121.1]) by smtp.gmail.com with ESMTPSA id z9sm2104375wrp.26.2019.09.20.02.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 02:48:07 -0700 (PDT) From: Connor Kuehl To: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, straube.linux@gmail.com, devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] staging: rtl8188eu: remove unnecessary self-assignment Date: Fri, 20 Sep 2019 11:48:07 +0200 Message-Id: <20190920094807.9217-1-connor.kuehl@canonical.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a self-assignment which is redundant. Fix this by removing the self-assignment. Addresses-Coverity: ("Self assignment") Signed-off-by: Connor Kuehl --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c index 086f98d38cba..57ae0e83dd3e 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c @@ -552,7 +552,6 @@ void Hal_ReadAntennaDiversity88E(struct adapter *pAdapter, u8 *PROMContent, bool pHalData->AntDivCfg = 1; /* 0xC1[3] is ignored. */ } else { pHalData->AntDivCfg = 0; - pHalData->TRxAntDivType = pHalData->TRxAntDivType; /* The value in the driver setting of device manager. */ } DBG_88E("EEPROM : AntDivCfg = %x, TRxAntDivType = %x\n", pHalData->AntDivCfg, pHalData->TRxAntDivType); } -- 2.17.1