Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1807674ybj; Sun, 22 Sep 2019 12:22:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzszYko3+8cE5KJcW9TKnzmGrhFzIvpf0YFnGaAtVyJ6ydwl4TlQ78hmaVQrqfyGeomRlZz X-Received: by 2002:a50:852c:: with SMTP id 41mr32358309edr.201.1569180153515; Sun, 22 Sep 2019 12:22:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569180153; cv=none; d=google.com; s=arc-20160816; b=ubwFpMB+JhXhUV1Xb0re793ZSoyM/qCpvTh5E2vOjspwDD1FAZzF0m6ti9owWCVeDt cl+x0M2X4KZWOzhSmmEyRl0TN2Hh8viTZ39wMnNdRhllT9/kCwCSo7u29NSRX81VTpZE C0t2VRf2BuPU3QscbXNsos9VGHCJbaN5h9YD2X5TWs5wYGvATi9QqAhCSwQepA7xR8lD 6mISjfh1vNC0tmgLhe7oCr0Pr/1M+QpCNHwbyA2730T+dP8cvDefV1atbupHeYSBubZW vk18KBph3agw4TKS+4o2CQHHMpzxvfYeiAWKj0vOe+/bkq0cjpjArK5eht4DvDvj2Y/n V48A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=SRZXqeH237Zd3XFldI3eNxtwtEJ31D/pRYjCJkpYIxM=; b=e4oSjk89R2LxGmDzB5qA4IzbRpffFXA+YiTrC4k2JVnTs+N9xxwsP65VjZKXI4axWZ vtHLVv73cjzu+Yyzz4HMd9+2XZEIOIZdGzaEAlv2E+kErA/FLrJe5znE5LhJYa9dsrlE /gHFh5jygdhWezKz85OcH3wOtOFs4HSFbstN3TBVR0+57PtUMDoWg9SmCLXc+19BrOpx 7Z0Ut6sZlRCk3swrFaleuoJCTrHN/tXKQNMv5X2qq0v9u4VCwOQ9brNuziQTnrpaZJVH bTqOBnIJOcCoaycilaCLMU8dwyIWk5BVqaX3mMfsHE1204T8dwJ5U+jvxvM3QjIwYjMZ 2N/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w34si5429659edc.252.2019.09.22.12.22.09; Sun, 22 Sep 2019 12:22:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438314AbfIUPhk convert rfc822-to-8bit (ORCPT + 99 others); Sat, 21 Sep 2019 11:37:40 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:58904 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438303AbfIUPhj (ORCPT ); Sat, 21 Sep 2019 11:37:39 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0E94B608310C; Sat, 21 Sep 2019 17:37:37 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8SXr9EMJTOpX; Sat, 21 Sep 2019 17:37:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 55133613E499; Sat, 21 Sep 2019 17:37:36 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bXykVNXxa5Ah; Sat, 21 Sep 2019 17:37:36 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 1042D608310C; Sat, 21 Sep 2019 17:37:36 +0200 (CEST) Date: Sat, 21 Sep 2019 17:37:35 +0200 (CEST) From: Richard Weinberger To: Hou Tao Cc: Xiaoming Ni , Al Viro , Boris Brezillon , dilinger@queued.net, linux-kernel , daniel santos , linux-mtd , David Woodhouse Message-ID: <1837147225.3667.1569080255850.JavaMail.zimbra@nod.at> In-Reply-To: References: <1568962478-126260-1-git-send-email-nixiaoming@huawei.com> <20190920114336.GM1131@ZenIV.linux.org.uk> <206f8d57-dad9-26c3-6bf6-1d000f5698d4@huawei.com> <20190920124532.GN1131@ZenIV.linux.org.uk> <20190920125442.GA20754@ZenIV.linux.org.uk> Subject: Re: [PATCH] jffs2:freely allocate memory when parameters are invalid MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF60 (Linux)/8.8.12_GA_3809) Thread-Topic: jffs2:freely allocate memory when parameters are invalid Thread-Index: jsGu5gCQ4Vd/48D/3p31+ncM705uWQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tao, ----- Ursprüngliche Mail ----- > Von: "Hou Tao" > In Huawei we use jffs2 broadly in our products to support filesystem on raw > NOR flash and NAND flash, so fixing the bugs in jffs2 means a lot to us. > > Although I have not read all of jffs2 code thoroughly, I had find and "fixed" > some bugs in jffs2 and I am willing to do any help in the jffs2 community. Maybe > we can start by testing and reviewing the pending patches in patch work ? yes, this is a good idea. In MTD's patchwork the jffs2 queue is in bad shape. I tried to catch up but failed to find enough time. So with more eyeballs I think we can bring it in shape again. Basically we need to classify which patches fix important stuff and which do not. Some time ago I make xfstests work with jffs2, I can share (and upstream) these patches too. One of my goals is making sure that we don't break jffs2. xfstests can help. Are you on the OFTC IRC network? On #mtd you can find us MTD guys. Thanks, //richard