Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1880042ybj; Sun, 22 Sep 2019 14:09:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqynQtoKl8sfT4dUZNWKIbexbdV6Di4dBxF0XnFIcvIw1HmCXTSHUUHViJCKH4/v7q7Adu8l X-Received: by 2002:a50:ce06:: with SMTP id y6mr18845821edi.282.1569186577151; Sun, 22 Sep 2019 14:09:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569186577; cv=none; d=google.com; s=arc-20160816; b=BtsDT9gYSIC0SZHpYDbwjCTvDAx/7V2tJNDuJZ+vw/xp/wvz3A++hCKvNWPC0YzW4g x96ZN0ameoTdn48Ioatd8SC1+vD3gnPWaq+voQOfD5y/lvBN0HWmESVCJt6u7xDPbwH4 PE3znySQgbj+LUr9hUSWKHxOtwEkmyFLaUlTXvGdza/l4vGcetVhbzHm26Upu/NZToNv LtWhQgyM3S7QExElkeH7fwt1ANxMXigEHRQbj9GwMMOAeqPHmADtZt6okEAn0dWduLJ8 8FQyquNECnJQYxksG1NADV6ikiXzzw6TCU4iQusaMhnKJ2HqyJ9GW5QZRZSvNFFl9EAk mOYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=QpV7/+yAaByU9Gkvq1/TvnZG5n90383ADAkpodmCXBA=; b=M+gXYnGE9CEeY0WBm+XqVklhxxcepOCv7Pq1aQEnsi44kUbp7dsghUSPoKoEKxrNgT xkEZJ+gpp2huxH7evYtATHH7PSQbfV/fuiJgJ2HxDzkGAeGrzCufMQtOE1gwJw5zUiYn gcEA9Yb16b+imjGXhnKZvUjsgY8oaliKU+GO3hI54TO/VBX5ftOi5a+c6dEGTBHPuDw9 BED1Wm8XJwDgblJsDmgGEVrsm5hR8P26rDJiX1+X3wJqrBb/NNWALm28GprGP7LqlZ0f kAG0Rfl0iWWRV664R3xvuhpJhlKd0WCCElBoo3pbQFu7tbZYNEQ4nrjES8Od5DkXs0nD 75cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lj8TXUiu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a36si5852146edf.123.2019.09.22.14.08.25; Sun, 22 Sep 2019 14:09:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lj8TXUiu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392986AbfITOiz (ORCPT + 99 others); Fri, 20 Sep 2019 10:38:55 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:33303 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389025AbfITOiy (ORCPT ); Fri, 20 Sep 2019 10:38:54 -0400 Received: by mail-wm1-f68.google.com with SMTP id r17so9714347wme.0 for ; Fri, 20 Sep 2019 07:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QpV7/+yAaByU9Gkvq1/TvnZG5n90383ADAkpodmCXBA=; b=lj8TXUiuIegfzRLSf+IsVql/zQQi6GFZkqQDxgz95XHsiUsXg5DoeBHTX2r5lfEuVL 99o/mHwpCF20bDx+1HOUdBYqPPcXQOkQQ9h1Syh2E2RcuD8hNK6Gd42Y9tIBKP1Y+PM3 cFHd7RMsJTSbEAEja3SWep4tucmR+Jo3cdNLQhml7wo+yG5jTcXTWxRuM7h2Hz/vwCqt MGGHxUXcvar9xbktUx/GrnEC33yWbAM6/sZFmuwZWoVf/D4RZB+8cOS31kjekKOlHC3K VPOPcf6qjzRwp210fcvX0LdHM01TRUo8i3RIJJnORMEzFGTtcr5EJhXu5CC78nLaKvLt SoZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QpV7/+yAaByU9Gkvq1/TvnZG5n90383ADAkpodmCXBA=; b=TzEK6NADrMgsyDZ9sLbZAgNaMWYL56ZrNNSW0M6TAS/M3EHRMRxCGXTglJoz856Gvk Kytp7Xpe67aBZ86TuC/UDL/xqwLC30Kwo8fsnnWHgs5AqLnj2Q/LBw2zdc1a7cCct3DY JsfSU/TMV91UwT5tvz16jbtyqoehPmUr6FK5grYin6XOy8JXSG/hDa+LNVUBFsPg2oWS CLJ6ng5p0ZkwB4WwgSD/1CjiWJY6AbORHAl+3Pcom0CD+A5Ou72hVKhmXwi312TrZeKt GipGA/X/6jXihQw2SbHLWtsKAwjOe2cahSTZE7yNIOslUvqCYezbjQvme44GjhEnBFpp yeig== X-Gm-Message-State: APjAAAXEkWKJV+yfkbl/6DHZuPIbQPnWT0YQ9rm0zTo2A2lDD9ePKIGa 3kjXYRisFKhWV+xXSB7l5tKZOmshQrsKZONaX8Q= X-Received: by 2002:a05:600c:24d1:: with SMTP id 17mr3773509wmu.104.1568990332904; Fri, 20 Sep 2019 07:38:52 -0700 (PDT) MIME-Version: 1.0 References: <1568962478-126260-1-git-send-email-nixiaoming@huawei.com> <20190920114336.GM1131@ZenIV.linux.org.uk> <206f8d57-dad9-26c3-6bf6-1d000f5698d4@huawei.com> <20190920124532.GN1131@ZenIV.linux.org.uk> <20190920125442.GA20754@ZenIV.linux.org.uk> In-Reply-To: From: Richard Weinberger Date: Fri, 20 Sep 2019 16:38:39 +0200 Message-ID: Subject: Re: [PATCH] jffs2:freely allocate memory when parameters are invalid To: Xiaoming Ni Cc: Al Viro , Boris Brezillon , Richard Weinberger , dilinger@queued.net, LKML , daniel.santos@pobox.com, linux-mtd@lists.infradead.org, houtao1@huawei.com, David Woodhouse Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 20, 2019 at 4:14 PM Xiaoming Ni wrote: > I still think this is easier to understand: > Free the memory allocated by the current function in the failed branch Please note that jffs2 is in "odd fixes only" maintenance mode. Therefore patches like this cannot be processed. On my never ending review queue are some other jffs2 patches which seem to address real problems. These go first. I see that many patches come form Huawai, maybe one of you can help maintaining jffs2? Reviews, tests, etc.. are very welcome! -- Thanks, //richard