Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp2266762ybj; Mon, 23 Sep 2019 00:16:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7Ulkl7khAGSkpRA1aPllX1XOS6O7Nn041CqSkwATyfutKdslJggtBhkX1zI3e+nSvoID+ X-Received: by 2002:a50:ce06:: with SMTP id y6mr20524519edi.282.1569223002798; Mon, 23 Sep 2019 00:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569223002; cv=none; d=google.com; s=arc-20160816; b=jcWLH3jlWq2N/46YZGB5bZGjPPTfZwVCDjmS0seu4pkgV9LxMlpxLo+ptD2DrN86qX pc/Y5goi0yDaVP/vp0XoA1IFvXmEAvcVzPtYCEmyYoqQyom6L3cM0uu6uW1l46iQojtd vkUw25zA3/8TorylHevm7M2oJLQ6NBHMtmbvqj1W/xfxoapE7NLW7pN2PSYpcYezXdG5 X6jYwBkoqIm5ogN6dgYhFHsQFqcypcBEDywWkoNhmOjAqE5KTvPKs5zC0/X8Y9GSJjXq 2tCrmfwk3SCXotMJJzKdOocX68Fas8C7cKVZz2AbC7XtymccimtD1QjHUaeuYuN34SGC WzEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=c57hxFA67fRRdSaSzWfUzlK33jYXyRtls9vYGbs8yPA=; b=mUwi+CdCPg726jQ+IWTJGNSScW/rvSYejcbjpZ6doEi7G/iyYpzu+/9LbjXZZEMIaw lENLKtABDgNKVHPiB9Ju/DIxcTNGoXpRDop/6VKvm988V+LmUuBtOxfcwtFFxun/VEig wj9sZt2oTuph1j+mcUyT5TT89nGs0iPXiCpMRDNntE9Bl4wn7Sg44kkCqo/vOPq/0OuG w7o0hGVPJdSzzWfvmYI8/TVvfqXh1e5+t2gPUiBVyQ3y33JCKuSxuUgPsKNiA4Zk8m+0 LgQZtUe6H+ao/meI22z5c+SkL7kX+WN5A5mjvDRfC/kn5kKjFiYzQMRqIhCLtG2XqRWM oJhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="kTf1z///"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4si4555912ejf.264.2019.09.23.00.16.17; Mon, 23 Sep 2019 00:16:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="kTf1z///"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390690AbfITQrQ (ORCPT + 99 others); Fri, 20 Sep 2019 12:47:16 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37478 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390274AbfITQrQ (ORCPT ); Fri, 20 Sep 2019 12:47:16 -0400 Received: by mail-qt1-f196.google.com with SMTP id d2so9415745qtr.4 for ; Fri, 20 Sep 2019 09:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c57hxFA67fRRdSaSzWfUzlK33jYXyRtls9vYGbs8yPA=; b=kTf1z///BD0MlbD3Rq+UybgtgBgOdhQqNDPBjwhi5czfm+yHZAia51VUsD6NOdA51U fn9iKlq000D27RSHlObzLX9euuS2Zs51aX07i20aT+cbUqJF831KVLz9h1E54Wl41N6K W1fdExGxOvUkHItGmKr8ZMAEOA2ClfioaxoHpoYYmydUKCT9sHIhQ0XlOj+/THXd5XUe uLMTAyg5k+h7mBgRxV1+aGymigT8661B8mHvX9C/WqT313DImUZRoXPnecKdOP3EvSRH r0llfbcTu5gee8p7Z35cYSPf3fYTPXLy0H1DfevFlFhx/XCWQe6Der6DFiZj6cCTb9DG 8Xdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c57hxFA67fRRdSaSzWfUzlK33jYXyRtls9vYGbs8yPA=; b=gyxFp4M0j2JnaUleNfIYM+d1WwHeUAU6McMkFMLKiqHUX3SswAETJi9xCsxcLe6srQ KRxONzAMSn56+L302xiGSh2iIAEnJyBdtlgAtcazXPDnyGOWmyDaiHA4nFGkdT8lM5MV IRp/6mbbrvjjVf3ammfSb5vn91Q8w0l++hq1OUaeaqEXwPZ/qMBdcCQZaSOh0VZSLKGg 5dP1EOkWQYgI3zxw3UeGVmXM8iVw7dPHUjn0Hdp81LVnPD1FQHefxZOjidL96DJCTpd6 AwDeArxUoxfKV5d/xKkzyo4Rmtrx4U0JFFyDL9YvtH7q4AsZMRf/s3XRehouUUCkNmsa L6tw== X-Gm-Message-State: APjAAAVYwrX+ZXKRwLcLLT/N2hMbMR3xlspOOjjCQ4jPC56qL+dwlA0D FST6jSxz8IuI1GRQfQ61j9e9NgQDAI6aUmEw0A/avg== X-Received: by 2002:ac8:7646:: with SMTP id i6mr4420523qtr.50.1568998033153; Fri, 20 Sep 2019 09:47:13 -0700 (PDT) MIME-Version: 1.0 References: <20190920163123.GC55224@lakrids.cambridge.arm.com> In-Reply-To: <20190920163123.GC55224@lakrids.cambridge.arm.com> From: Dmitry Vyukov Date: Fri, 20 Sep 2019 18:46:53 +0200 Message-ID: Subject: Re: Kernel Concurrency Sanitizer (KCSAN) To: Mark Rutland Cc: Marco Elver , kasan-dev , LKML , Andrey Konovalov , Alexander Potapenko , "Paul E. McKenney" , Paul Turner , Daniel Axtens , Anatol Pomazau , Will Deacon , Andrea Parri , Alan Stern , LKMM Maintainers -- Akira Yokosawa , Nicholas Piggin , Boqun Feng , Daniel Lustig , Jade Alglave , Luc Maranget Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 20, 2019 at 6:31 PM Mark Rutland wrote: > > On Fri, Sep 20, 2019 at 04:18:57PM +0200, Marco Elver wrote: > > Hi all, > > Hi, > > > We would like to share a new data-race detector for the Linux kernel: > > Kernel Concurrency Sanitizer (KCSAN) -- > > https://github.com/google/ktsan/wiki/KCSAN (Details: > > https://github.com/google/ktsan/blob/kcsan/Documentation/dev-tools/kcsan.rst) > > Nice! > > BTW kcsan_atomic_next() is missing a stub definition in > when !CONFIG_KCSAN: > > https://github.com/google/ktsan/commit/a22a093a0f0d0b582c82cdbac4f133a3f61d207c#diff-19d7c475b4b92aab8ba440415ab786ec > > ... and I think the kcsan_{begin,end}_atomic() stubs need to be static > inline too. > > It looks like this is easy enough to enable on arm64, with the only real > special case being secondary_start_kernel() which we might want to > refactor to allow some portions to be instrumented. > > I pushed the trivial patches I needed to get arm64 booting to my arm64/kcsan > branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/kcsan > > We have some interesting splats at boot time in stop_machine, which > don't seem to have been hit/fixed on x86 yet in the kcsan-with-fixes > branch, e.g. > > [ 0.237939] ================================================================== > [ 0.239431] BUG: KCSAN: data-race in multi_cpu_stop+0xa8/0x198 and set_state+0x80/0xb0 > [ 0.241189] > [ 0.241606] write to 0xffff00001003bd00 of 4 bytes by task 24 on cpu 3: > [ 0.243435] set_state+0x80/0xb0 > [ 0.244328] multi_cpu_stop+0x16c/0x198 > [ 0.245406] cpu_stopper_thread+0x170/0x298 > [ 0.246565] smpboot_thread_fn+0x40c/0x560 > [ 0.247696] kthread+0x1a8/0x1b0 > [ 0.248586] ret_from_fork+0x10/0x18 > [ 0.249589] > [ 0.250006] read to 0xffff00001003bd00 of 4 bytes by task 14 on cpu 1: > [ 0.251804] multi_cpu_stop+0xa8/0x198 > [ 0.252851] cpu_stopper_thread+0x170/0x298 > [ 0.254008] smpboot_thread_fn+0x40c/0x560 > [ 0.255135] kthread+0x1a8/0x1b0 > [ 0.256027] ret_from_fork+0x10/0x18 > [ 0.257036] > [ 0.257449] Reported by Kernel Concurrency Sanitizer on: > [ 0.258918] CPU: 1 PID: 14 Comm: migration/1 Not tainted 5.3.0-00007-g67ab35a199f4-dirty #3 > [ 0.261241] Hardware name: linux,dummy-virt (DT) > [ 0.262517] ================================================================== > > > To those of you who we mentioned at LPC that we're working on a > > watchpoint-based KTSAN inspired by DataCollider [1], this is it (we > > renamed it to KCSAN to avoid confusion with KTSAN). > > [1] http://usenix.org/legacy/events/osdi10/tech/full_papers/Erickson.pdf > > > > In the coming weeks we're planning to: > > * Set up a syzkaller instance. > > * Share the dashboard so that you can see the races that are found. > > * Attempt to send fixes for some races upstream (if you find that the > > kcsan-with-fixes branch contains an important fix, please feel free to > > point it out and we'll prioritize that). > > > > There are a few open questions: > > * The big one: most of the reported races are due to unmarked > > accesses; prioritization or pruning of races to focus initial efforts > > to fix races might be required. Comments on how best to proceed are > > welcome. We're aware that these are issues that have recently received > > attention in the context of the LKMM > > (https://lwn.net/Articles/793253/). > > I think the big risk here is drive-by "fixes" masking the warnings > rather than fixing the actual issue. It's easy for people to suppress a > warning with {READ,WRITE}_ONCE(), so they're liable to do that even the > resulting race isn't benign. > > I don't have a clue how to prevent that, though. I think this is mostly orthogonal problem. E.g. for some syzbot bugs I see fixes that also try to simply "shut up" the immediate manifestation with whatever means, e.g. sprinkling some slinlocks. So (1) it's not unique to atomics, (2) presence of READ/WRITE_ONCE will make the reader aware of the fact that this runs concurrently with something else, and then they may ask themselves why this runs concurrently with something when the object is supposed to be private to the thread, and then maybe they re-fix it properly. Whereas if it's completely unmarked, nobody will even notice that this code accesses the object concurrently with other code. So even if READ/WRITE_ONCE was a wrong fix, it's still better to have it rather than not.