Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp2363284ybj; Mon, 23 Sep 2019 02:29:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVeadVoqGSwMTo0eIolc2osbsrgkYu2Jby0agjBoLx5yZ8VTxWBNRY7Hd1Jah8b7u1balF X-Received: by 2002:a17:906:7ac6:: with SMTP id k6mr28719720ejo.243.1569230963393; Mon, 23 Sep 2019 02:29:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569230963; cv=none; d=google.com; s=arc-20160816; b=QC+NZNltE8RcT9fXRW83qAo09Nc5Itiw34lJJx+BkC/jJf1lKQVhNDpM20wU3/jde6 WxIVCV/IzJf60dMBCVxvQt1Y+gBqMTRysoXeJAaSY1YFu0i9E5qofDpgp9iiM2Iitk/H pho9Q+/luaR9+NvWi01cy0nb+GnPBpkHA3vWgECSSFZJDkYkJDTtY3CM0pqNUV8KLE4L Qf2RxWyI5inL3RBX4dI+WKeZw0m92IjGAcd0HFd2VXOIlgs3Omx4O1a5y5/0TyPlg1ss rlt+Tokc2RQv7Vx3XKzJojfFMQ3uADYh5muDA1t2X4VsG3XcAf3SZANSZyZ8jr/hrXBI 6ISQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=L+sPKUKH06o+2bCBaoKbYjJxrNj69PQvI6LssiKHDZw=; b=nf7fx9Wjf7A1YVZ6cZTuGMBRIf5rdkDfoVMbdWP8Ma56d+7zz1kDNiDuqPupKgOOG8 CB8IOarNjOoDaOY6nJe/p9Rt6gYoLDLyAvB3pkx/Ikskuv+F44lBx5tQ2ypHImX0HMeo ztTpQbOoitglev/2XrNoqIRPgvXwHC5XXh58GEEjCa8LUuf1GSzP47bddrfEV2bfHNCa O+e7SzQyfwaCU0vPt7usXZRJ3HEzkVUeal7FGQShUNNUmxMPYeRNxrNTVOcqdyf/5cPy FvVn1LBCMzZq0xP1p8nhlYozq4t6YKFbFQVfeGB8d6TMXBy1dKYhe/c5OvhbKQwG7r35 eBlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=FZzWDaGs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e20si3226187eje.299.2019.09.23.02.29.00; Mon, 23 Sep 2019 02:29:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=FZzWDaGs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406221AbfITREy (ORCPT + 99 others); Fri, 20 Sep 2019 13:04:54 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:39312 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405588AbfITRD4 (ORCPT ); Fri, 20 Sep 2019 13:03:56 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8KH3t4s101456; Fri, 20 Sep 2019 12:03:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1568999035; bh=L+sPKUKH06o+2bCBaoKbYjJxrNj69PQvI6LssiKHDZw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=FZzWDaGsTQM3Dydlqk05fxQWm5Q7C1npzM2sqtp3dhQeR3BesszXZaHEtK9Wg3wUE CQF4hiOHVE4903XK+GwftMYA72fdSutlpdlAgkmaIFgxHSORCFpLOl4zVA5iBWQin6 oG3RywrxoNw+uAln/fD5afad9IRLYtviBvAS+9TU= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8KH3txI102382 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Sep 2019 12:03:55 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 20 Sep 2019 12:03:51 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 20 Sep 2019 12:03:55 -0500 Received: from uda0869644b.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8KH3r6u054719; Fri, 20 Sep 2019 12:03:55 -0500 From: Benoit Parrot To: Hans Verkuil CC: Prabhakar Lad , , , , Benoit Parrot , Jyri Sarha Subject: [Patch v3 02/13] media: am437x-vpfe: Fix missing first line Date: Fri, 20 Sep 2019 12:05:43 -0500 Message-ID: <20190920170554.29666-3-bparrot@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190920170554.29666-1-bparrot@ti.com> References: <20190920170554.29666-1-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Previous generation of this driver were hard coded to handle encoder/decoder where the first line never contains any data and was therefore always skipped, however when dealing with actual camera sensors the first line is always present. Signed-off-by: Benoit Parrot Signed-off-by: Jyri Sarha --- drivers/media/platform/am437x/am437x-vpfe.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c index a3d22f90e64c..1521c072f3e3 100644 --- a/drivers/media/platform/am437x/am437x-vpfe.c +++ b/drivers/media/platform/am437x/am437x-vpfe.c @@ -345,13 +345,9 @@ static void vpfe_ccdc_setwin(struct vpfe_ccdc *ccdc, if (frm_fmt == CCDC_FRMFMT_INTERLACED) { vert_nr_lines = (image_win->height >> 1) - 1; vert_start >>= 1; - /* Since first line doesn't have any data */ - vert_start += 1; /* configure VDINT0 */ val = (vert_start << VPFE_VDINT_VDINT0_SHIFT); } else { - /* Since first line doesn't have any data */ - vert_start += 1; vert_nr_lines = image_win->height - 1; /* * configure VDINT0 and VDINT1. VDINT1 will be at half -- 2.17.1