Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp2609952ybj; Mon, 23 Sep 2019 06:40:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqzceLwYlGNGNrU726lnWazijaLC1mSVjf+aRQLXf922UPYjKgE//G6sPfx1P6SNRnAMA2FZ X-Received: by 2002:a17:906:3644:: with SMTP id r4mr30373977ejb.92.1569246056532; Mon, 23 Sep 2019 06:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569246056; cv=none; d=google.com; s=arc-20160816; b=faWk2iR54wR9QIwZIJZvaGROtVcHQeE5NqJLq3tFqvKIbxPWJ1qvBib3tvbTb0/bo5 5T5TfvBs3oy655IA2BIdLWogLvpfNtw7NLTwhVoOtymRlZJL0nxTzhpD7ubEUGOCUuA1 wBWg1tqpP9v6CUiRUHLHwPt0Q3A598hVMEEqDWI1GlxrXy/vtJ3WfUA9BIgE22sj+oCa xHIuEwldv8LAPVaKPX3JBcARQxJuCzAWbjARIoiazTqZJZucL3woaI9/dqtNz2kHHLSX sqmWNXmLoXomm2XZmJoD987MfQ9m9wo9VC017WlDY/j8XR9PJPQChN4wmvI2DNaSBxhD oHiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=SMoq7TZ0NiQ8MxwG7eDaPmFmoJSB00R5hX+Hdmm23DU=; b=KE/TGuJ6gK+qCwP4kYXhEKzxnAZMF9qbvJsBZM/psz+VFwlHgfZmKjBmXsaLCUQ/qQ K7n+Y8If2EWBETUiY9HQdQCEPpK+yqvA4quhl9e6ZXGrKyAK8PcluyJMh+RcbXkDTRWJ iXuh9bINgVtGtyEMp3jrkJXPSFyT0KTsBcIeFT901ctJSNzXFOeiBP0qBBstKHtZcubn WZkXwrA/F2PzPPxGDGFwk7YF2D0QI6PwhAZSZ1wo/NZmucTq2/mHguNj3nLVi6pRzkMQ crJRdxRWQ+X4sxZy4fSAHkczwwCmA7pBeDl6k7uIsjhJQc1LNzOXmwYWNhj5WIzVl6X8 3vzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=e9F2FhzK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si5087536ejw.373.2019.09.23.06.40.32; Mon, 23 Sep 2019 06:40:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=e9F2FhzK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730933AbfIUGAq (ORCPT + 99 others); Sat, 21 Sep 2019 02:00:46 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:37850 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbfIUGAp (ORCPT ); Sat, 21 Sep 2019 02:00:45 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8L603gp125363; Sat, 21 Sep 2019 06:00:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2019-08-05; bh=SMoq7TZ0NiQ8MxwG7eDaPmFmoJSB00R5hX+Hdmm23DU=; b=e9F2FhzKB9HwNYraob4tnlRcxJM+Iso37WuafIE7+YVkeoJeiQHf6Q7roNQxj183DXr0 x4Jp6awk1sfeBi+bFs+UHVkmllwANrVTLEcnaYEO660MuCbh45eI4+HZUrJ01SNkSSpA YquicE8QOhZAeW0Ex6LRkFIPb+ZcUbG2KM2pxsFWy5DkWTjab+Czs0tfinvebnnjk/J4 Um5i1AbYjvTQeCmodOTY5Nvx6ifKBxha4wtoEWzCuhxr92wDkXTAYJ2hdXfjG4X9EqM+ u6UGO7ax8yxnx3yRXFfrXEzfjka09psln+ZEvKg6TC1nL8WBNjJ5OE1hPaFJV474AU6t eQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2v5b9t87wc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Sep 2019 06:00:40 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8L5wc19114889; Sat, 21 Sep 2019 06:00:40 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2v59x8vpp5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Sep 2019 06:00:39 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x8L60csn018213; Sat, 21 Sep 2019 06:00:38 GMT Received: from mwanda (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 21 Sep 2019 06:00:37 +0000 Date: Sat, 21 Sep 2019 09:00:31 +0300 From: Dan Carpenter To: Song Liu , NeilBrown Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] md/raid0: Fix an error message in raid0_make_request() Message-ID: <20190921060031.GB18726@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9386 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909210065 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9386 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909210066 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first argument to WARN() is supposed to be a condition. The original code will just print the mdname() instead of the full warning message. Fixes: c84a1372df92 ("md/raid0: avoid RAID0 data corruption due to layout confusion.") Signed-off-by: Dan Carpenter --- drivers/md/raid0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c index f61693e59684..3956ea502f97 100644 --- a/drivers/md/raid0.c +++ b/drivers/md/raid0.c @@ -615,7 +615,7 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio) tmp_dev = map_sector(mddev, zone, sector, §or); break; default: - WARN("md/raid0:%s: Invalid layout\n", mdname(mddev)); + WARN(1, "md/raid0:%s: Invalid layout\n", mdname(mddev)); bio_io_error(bio); return true; } -- 2.20.1