Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 22 Sep 2019 10:30:04 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Artemy Kovalyov <artemyko@mellanox.com>,
        Yossi Itigin <yosefe@mellanox.com>,
        Leon Romanovsky <leonro@mellanox.com>,
        Steve Wise <swise@opengridcomputing.com>,
        Jason Gunthorpe <jgg@mellanox.com>,
        =?iso-8859-1?Q?H=E5kon?= Bugge <haakon.bugge@oracle.com>
Subject: Re: [PATCH 4.19 03/79] RDMA/restrack: Release task struct which was
 hold by CM_ID object
Message-ID: <20190922083004.GA2654133@kroah.com>
References: <20190919214807.612593061@linuxfoundation.org>
 <20190919214808.101726182@linuxfoundation.org>
 <20190921202209.GA14868@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190921202209.GA14868@amd>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Sep 21, 2019 at 10:22:10PM +0200, Pavel Machek wrote:
> Hi!
> 
> > commit ed7a01fd3fd77f40b4ef2562b966a5decd8928d2 upstream.
> > 
> > Tracking CM_ID resource is performed in two stages: creation of cm_id
> > and connecting it to the cma_dev. It is needed because rdma-cm protocol
> > exports two separate user-visible calls rdma_create_id and
> > rdma_accept.
> ...
> 
> Mainline says this needs additional fix, fe9bc1644918aa1d, see below.
> 
> > --- a/drivers/infiniband/core/restrack.c
> > +++ b/drivers/infiniband/core/restrack.c
> > @@ -209,7 +209,7 @@ void rdma_restrack_del(struct rdma_restr
> >  	struct ib_device *dev;
> >  
> >  	if (!res->valid)
> > -		return;
> > +		goto out;
> >  
> >  	dev = res_to_dev(res);
> >  	if (!dev)
> #                 return;
> 
> This test does return, does it need to go through 'goto out', too? (I
> see it should not happen, but...)
> 
> > @@ -222,8 +222,10 @@ void rdma_restrack_del(struct rdma_restr
> >  	down_write(&dev->res.rwsem);
> >  	hash_del(&res->node);
> >  	res->valid = false;
> > +	up_write(&dev->res.rwsem);
> > +
> > +out:
> >  	if (res->task)
> >  		put_task_struct(res->task);
> > -	up_write(&dev->res.rwsem);
> >  }
> 
> Mainline says res->task = NULL is needed there, see fe9bc1644918aa1d.

Good catch, now queued up, thanks!

greg k-h