Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3034124ybj; Mon, 23 Sep 2019 13:36:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7OF6Y1xdr8W0+6cwfU7MJYuCEnjXTC+hS8VFASS9/V1KQeFjdCd5gHrWTHmZ2ERqcWTJe X-Received: by 2002:a17:906:308a:: with SMTP id 10mr1479482ejv.277.1569271003895; Mon, 23 Sep 2019 13:36:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569271003; cv=none; d=google.com; s=arc-20160816; b=Q3Zu+mX52dg2Z4QojAsWNwWEctHJEhk5XPA0E13L0wxTtN5eSle5n9rfMw35OLmNv2 i+lAmGa+SRXnk9Js+WySh8swfKxcafoIkd4cq7372nMcTo2tM5B8NfaTZxBe9wscer6v oHQrXx35YiKnCPYVMyeci7X6EKcqRXJl0PC149VTdlC6xh1ksQ5Z9Y7yofgLIow6GhOt 3JsEy+jhnTGiB2X9KplrwWNy2cdP+h6WP7UXQrxhwR/WAkqC2SqmSwJMIFiY8wulPsoo AJRsULonom66trWWAGSNpCjM8zGbEn1EJb5yzSVCPKqqsUrNXwr4q0FgVV+KGS9lAVkC brRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FWZXXrTVD4WFH1Ghz5/J4Li9g5DgPD0a/vGpT0RJExs=; b=Vq2wF9RNipZPecuI6Ugg3nQ6P43iiEUxxOZEaz33FbGBXnTL6X703pjx78E72ZHs0J UWxTHsli82OqZlYN/oMffPhsrVXN2EdAis7RlbuH3ROiXmz0e1hsdMz2eEN5cxBshAfy L0kMceKchLDpaAsGChrT8p9hfsZvJctk+mkH9Y0zbVHB7MGv1UxTUKhJrpAb5e06dgkZ PgOZPZMp2zqh2HDExJNlW3FVoqVQhIgBG4c+PSo5zL8gmPnCiQvvv97F/rkYc1ATGMnn 09I15C0kk2mQ+8cPhw6eohCT3wSyBzjvec0Rb0JTDOQnIf780fhPskhSigXMZZGn0bkR 8Z5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1TjcEW1L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g14si7020455edm.407.2019.09.23.13.36.20; Mon, 23 Sep 2019 13:36:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1TjcEW1L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388384AbfIVSny (ORCPT + 99 others); Sun, 22 Sep 2019 14:43:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:39462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388156AbfIVSnx (ORCPT ); Sun, 22 Sep 2019 14:43:53 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0431206C2; Sun, 22 Sep 2019 18:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177832; bh=m8Rkj3Qzx71o5Y0r+L+LsH76roXPq/OBkz76e2xoE40=; h=From:To:Cc:Subject:Date:From; b=1TjcEW1Llg96P9YM6gA3KZrIT8Sd6mpQXxAMN8FNjFWqUXKQ83TX+mCsm1WDDF/kF 42uOwxPDoAd6o+M3vbqzWIx2+d/s3qznIO8/yJqMXO1UWg9thb/CmD3jXnsiUg71kD CrGQh94JIj4J71N7Ae4M5Fy3gkkylYHtePE8l1rU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chris Wilson , Takashi Iwai , Sasha Levin Subject: [PATCH AUTOSEL 5.3 001/203] ALSA: hda: Flush interrupts on disabling Date: Sun, 22 Sep 2019 14:40:27 -0400 Message-Id: <20190922184350.30563-1-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Wilson [ Upstream commit caa8422d01e983782548648e125fd617cadcec3f ] I was looking at <4> [241.835158] general protection fault: 0000 [#1] PREEMPT SMP PTI <4> [241.835181] CPU: 1 PID: 214 Comm: kworker/1:3 Tainted: G U 5.2.0-CI-CI_DRM_6509+ #1 <4> [241.835199] Hardware name: Dell Inc. OptiPlex 745 /0GW726, BIOS 2.3.1 05/21/2007 <4> [241.835234] Workqueue: events snd_hdac_bus_process_unsol_events [snd_hda_core] <4> [241.835256] RIP: 0010:input_handle_event+0x16d/0x5e0 <4> [241.835270] Code: 48 8b 93 58 01 00 00 8b 52 08 89 50 04 8b 83 f8 06 00 00 48 8b 93 00 07 00 00 8d 70 01 48 8d 04 c2 83 e1 08 89 b3 f8 06 00 00 <66> 89 28 66 44 89 60 02 44 89 68 04 8b 93 f8 06 00 00 0f 84 fd fe <4> [241.835304] RSP: 0018:ffffc9000019fda0 EFLAGS: 00010046 <4> [241.835317] RAX: 6b6b6b6ec6c6c6c3 RBX: ffff8880290fefc8 RCX: 0000000000000000 <4> [241.835332] RDX: 000000006b6b6b6b RSI: 000000006b6b6b6c RDI: 0000000000000046 <4> [241.835347] RBP: 0000000000000005 R08: 0000000000000000 R09: 0000000000000001 <4> [241.835362] R10: ffffc9000019faa0 R11: 0000000000000000 R12: 0000000000000004 <4> [241.835377] R13: 0000000000000000 R14: ffff8880290ff1d0 R15: 0000000000000293 <4> [241.835392] FS: 0000000000000000(0000) GS:ffff88803de80000(0000) knlGS:0000000000000000 <4> [241.835409] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [241.835422] CR2: 00007ffe9a99e9b7 CR3: 000000002f588000 CR4: 00000000000006e0 <4> [241.835436] Call Trace: <4> [241.835449] input_event+0x45/0x70 <4> [241.835464] snd_jack_report+0xdc/0x100 <4> [241.835490] snd_hda_jack_report_sync+0x83/0xc0 [snd_hda_codec] <4> [241.835512] snd_hdac_bus_process_unsol_events+0x5a/0x70 [snd_hda_core] <4> [241.835530] process_one_work+0x245/0x610 which has the hallmarks of a worker queued from interrupt after it was supposedly cancelled (note the POISON_FREE), and I could not see where the interrupt would be flushed on shutdown so added the likely suspects. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111174 Signed-off-by: Chris Wilson Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/hda/hdac_controller.c | 2 ++ sound/pci/hda/hda_intel.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 3b0110545070a..196bbc85699e5 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -447,6 +447,8 @@ static void azx_int_disable(struct hdac_bus *bus) list_for_each_entry(azx_dev, &bus->stream_list, list) snd_hdac_stream_updateb(azx_dev, SD_CTL, SD_INT_MASK, 0); + synchronize_irq(bus->irq); + /* disable SIE for all streams */ snd_hdac_chip_writeb(bus, INTCTL, 0); diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 99fc0917339bb..0ed2be83706d6 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1349,9 +1349,9 @@ static int azx_free(struct azx *chip) } if (bus->chip_init) { + azx_stop_chip(chip); azx_clear_irq_pending(chip); azx_stop_all_streams(chip); - azx_stop_chip(chip); } if (bus->irq >= 0) -- 2.20.1