Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3034265ybj; Mon, 23 Sep 2019 13:36:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqynwrQ+RjHQ5Jqjc9l+ZFn/xnSoe9DriNNPkzmGgQUJlRW7LnsS9kVvJdUDXJ1lr3JCTRgw X-Received: by 2002:a17:906:fc20:: with SMTP id ov32mr1556629ejb.22.1569271014716; Mon, 23 Sep 2019 13:36:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569271014; cv=none; d=google.com; s=arc-20160816; b=k/I8hXsEUVBMjUKLHNaV2aczYVnbEDcqZetQV8Fsc+SMiAtOFJTyyHRZL+XNYH4qyh pkQMQTxGGKvZOexEfSBEN3XRWMwsimvK88Q+fNx9+6lpcoUVX2dDg8NnkTC9/MOUTLa8 Dh5Ugply7iSysuYheNx2k66AaI0GT+EJQCLPBXj88yK6Nj0CVr97Erjnl4GgVCjHIVyB d5wMp6Gy8qwGIB02huEiBDf9srBXlu/R9nb7M8lp3nGo+6eOm1/K1cmryUcQCUWMXk/b 4sAHAUFzfPu8B8bREa52YKsby4jF4207DdZNMKe478q+0l2fnS58KHNXoeSXLpvy9s8p d4Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wHObB8AJf8Xo2rbMybozK9eN/LUGMbhd7cYTI7GuZmY=; b=j5ReOYKwHdSZ2taSiXKcIY4YW52q5EbeGKzPZpsmUVTN4v6+FqSN3yFdn6UijA5GPH u8Lu8bFBOiMHeVutKUWKfF7xQokp+1/fO1ZqQlDwv7Qpw7Dk4u4p9AWh9FrvfseFJHTd cVpafND7fx8/VYYTbHqadFNBWR50fPoIpyFAv5TvzjvB0Xl8I2kbi61IShxVmJ+q6xqG NWNbbZhqNXsGNY4AWlKO+OhZdv08Yiy0f5+EH9LJoU+TMmnw4HLt36nlI3Qknib4ENLI DzMOSnOcdzd0ZrJjdla/if2Tjk9fpOlIy5lsEj8R1BxbErmp3gduAcc81vjRrZV3Vzpp Gt2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L0tfweO0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h26si7165270edb.141.2019.09.23.13.36.31; Mon, 23 Sep 2019 13:36:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L0tfweO0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388756AbfIVSoT (ORCPT + 99 others); Sun, 22 Sep 2019 14:44:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388694AbfIVSoG (ORCPT ); Sun, 22 Sep 2019 14:44:06 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFC42206C2; Sun, 22 Sep 2019 18:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177846; bh=34W1jjTazjZpi9L33eWvheVRmOMYkavJ5q66RdOX93w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L0tfweO0naisZ0J2afvXndHXOO1xR0aJHN9pc82FuRnu1Yej5I90Z2MA1P7Xk8JSa g244puSr4LjDiHx+Y3eO2ia6UKftTg0kL7XB8D8H449LVLnvZbBhQAe0C580LRj8/p 6MET/efrdbSZklRuP5MLtSj+ChoYlmXe7guU5uUY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nick Stoughton , Pavel Machek , Jacek Anaszewski , Sasha Levin , linux-leds@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 013/203] leds: leds-lp5562 allow firmware files up to the maximum length Date: Sun, 22 Sep 2019 14:40:39 -0400 Message-Id: <20190922184350.30563-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Stoughton [ Upstream commit ed2abfebb041473092b41527903f93390d38afa7 ] Firmware files are in ASCII, using 2 hex characters per byte. The maximum length of a firmware string is therefore 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64 Fixes: ff45262a85db ("leds: add new LP5562 LED driver") Signed-off-by: Nick Stoughton Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/leds-lp5562.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c index 37632fc637414..edb57c42e8b1d 100644 --- a/drivers/leds/leds-lp5562.c +++ b/drivers/leds/leds-lp5562.c @@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip) { const struct firmware *fw = chip->fw; - if (fw->size > LP5562_PROGRAM_LENGTH) { + /* + * the firmware is encoded in ascii hex character, with 2 chars + * per byte + */ + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) { dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n", fw->size); return; -- 2.20.1