Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3076424ybj; Mon, 23 Sep 2019 14:23:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxwRyWmxpklSWvJikN8mczuQYms6N1rT+/D5bWpvua+IC2BuG81DkqBpSwxuAwU4zlNnAgj X-Received: by 2002:a50:eb03:: with SMTP id y3mr2349292edp.194.1569273814026; Mon, 23 Sep 2019 14:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569273814; cv=none; d=google.com; s=arc-20160816; b=Pclu+XQzbztjzJ98FA2HyH9/ynGw8YrRf1X+pJx+EmQ27tb0OGGK/McFPsBWHTHSum fQGD2rQaRmFlGU8lzx4kePXMh2cLfN+QM/F1/jpjvPrcn474Xo6wOSuFwOCuGTtExlT8 0yfTA82sKjqFZeCg35u7PKHH40ljdVrIESGxEKXi3C/5aaUiO+r0cCupzvp6WPHmO50W /k5rn7wrKESxoxDR9YdhLXhyoANyNt8R4F1RyPIK27iXFnqOD3C+5HKVjysaa8IIFhx0 upN7IpqEnMI3TsIWFZpj8MWhI3i4yg4ITeUm1mqXQiqEVlCuo0sW/5+XLyzGaCYv8sKB 6JSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vdeyXemE6QanKW/K/iCZ0hfS7vA8EHgMUoPZmY+56r4=; b=hln9+Vtux+vlYaa/Y3r9gVsa5brF0glbNPdQNinSWsK8zEPlMzA5UkMQDpZl0lUeCo /JSMvBQn7gB/ZCIU9hb0cW9sXA8yK5SxJUaXOm7VcgrGJ86zrjNWeL/jhgnMi+l5KDdB BWHHo4w7j0F5mu9RQiaEicx1Tqz2bsoWRks8jSgiWCWJji3itbi1loohTUBOoY3SvNwS SorbCj8lmesbu9fMnjzQ/lX0S76nMRTJ8ohBRDus3pXPB9eZ6rMxQra1tGRRgBz47dpl 3KxL+aZ8XhN9OwlVYtycZcXnBQSNNnirgCN6wKmpVSGO70rOWyTt3Qh1SfMzLz6Brq9t ojNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U6e6u9bp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w54si6946317edd.427.2019.09.23.14.23.05; Mon, 23 Sep 2019 14:23:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U6e6u9bp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389864AbfIVSqS (ORCPT + 99 others); Sun, 22 Sep 2019 14:46:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:42340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729125AbfIVSqQ (ORCPT ); Sun, 22 Sep 2019 14:46:16 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82808206B6; Sun, 22 Sep 2019 18:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177975; bh=TEEH8AkXj/LBWnxOt8qCA4YMnQ7RsOpFc05KlNuJSCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U6e6u9bpf3aF2A7uhuzLSXxZL5EkWe9cfiDgdynTjxcGYqBLmrPkwQKIHcnSWWJqg CztZ5nfeKdWKLIP2xvyE1Lit6P3n3WCLzvx6lQtdrZQO0Kf/A5ZvyIOiKjnQU8wFkx EV/eKanyC+Y3rN3zdUqPcLGt//gQ5gdaEyjGNDoE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sean Young , Ezequiel Garcia , Brad Love , syzbot+b7f57261c521087d89bb@syzkaller.appspotmail.com, Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 073/203] media: em28xx: modules workqueue not inited for 2nd device Date: Sun, 22 Sep 2019 14:41:39 -0400 Message-Id: <20190922184350.30563-73-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Young [ Upstream commit 46e4a26615cc7854340e4b69ca59ee78d6f20c8b ] syzbot reports an error on flush_request_modules() for the second device. This workqueue was never initialised so simply remove the offending line. usb 1-1: USB disconnect, device number 2 em28xx 1-1:1.153: Disconnecting em28xx #1 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 12 at kernel/workqueue.c:3031 __flush_work.cold+0x2c/0x36 kernel/workqueue.c:3031 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.3.0-rc2+ #25 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 panic+0x2a3/0x6da kernel/panic.c:219 __warn.cold+0x20/0x4a kernel/panic.c:576 report_bug+0x262/0x2a0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:179 [inline] fixup_bug arch/x86/kernel/traps.c:174 [inline] do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:272 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:291 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1026 RIP: 0010:__flush_work.cold+0x2c/0x36 kernel/workqueue.c:3031 Code: 9a 22 00 48 c7 c7 20 e4 c5 85 e8 d9 3a 0d 00 0f 0b 45 31 e4 e9 98 86 ff ff e8 51 9a 22 00 48 c7 c7 20 e4 c5 85 e8 be 3a 0d 00 <0f> 0b 45 31 e4 e9 7d 86 ff ff e8 36 9a 22 00 48 c7 c7 20 e4 c5 85 RSP: 0018:ffff8881da20f720 EFLAGS: 00010286 RAX: 0000000000000024 RBX: dffffc0000000000 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff8128a0fd RDI: ffffed103b441ed6 RBP: ffff8881da20f888 R08: 0000000000000024 R09: fffffbfff11acd9a R10: fffffbfff11acd99 R11: ffffffff88d66ccf R12: 0000000000000000 R13: 0000000000000001 R14: ffff8881c6685df8 R15: ffff8881d2a85b78 flush_request_modules drivers/media/usb/em28xx/em28xx-cards.c:3325 [inline] em28xx_usb_disconnect.cold+0x280/0x2a6 drivers/media/usb/em28xx/em28xx-cards.c:4023 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423 __device_release_driver drivers/base/dd.c:1120 [inline] device_release_driver_internal+0x404/0x4c0 drivers/base/dd.c:1151 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:556 device_del+0x420/0xb10 drivers/base/core.c:2288 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199 hub_port_connect drivers/usb/core/hub.c:4949 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 process_scheduled_works kernel/workqueue.c:2331 [inline] worker_thread+0x7ab/0xe20 kernel/workqueue.c:2417 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Kernel Offset: disabled Rebooting in 86400 seconds.. Fixes: be7fd3c3a8c5e ("media: em28xx: Hauppauge DualHD second tuner functionality) Reviewed-by: Ezequiel Garcia Reviewed-by: Brad Love Reported-by: syzbot+b7f57261c521087d89bb@syzkaller.appspotmail.com Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/em28xx/em28xx-cards.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c index 1283c7ca9ad51..1de835a591a06 100644 --- a/drivers/media/usb/em28xx/em28xx-cards.c +++ b/drivers/media/usb/em28xx/em28xx-cards.c @@ -4020,7 +4020,6 @@ static void em28xx_usb_disconnect(struct usb_interface *intf) dev->dev_next->disconnected = 1; dev_info(&dev->intf->dev, "Disconnecting %s\n", dev->dev_next->name); - flush_request_modules(dev->dev_next); } dev->disconnected = 1; -- 2.20.1