Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3092102ybj; Mon, 23 Sep 2019 14:42:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzz30CzN/A1nWDqgKTjsMLR8EkcerS0gI/oQD7lcBM5+Dxv3X+uYjzBCcP82zg57CCiuBDM X-Received: by 2002:a05:6402:a50:: with SMTP id bt16mr2369806edb.114.1569274941270; Mon, 23 Sep 2019 14:42:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569274941; cv=none; d=google.com; s=arc-20160816; b=sza1xTVEsYpioFgF4Ql/IMNjYGXytxHpERKcDOwVACAQ7IxV1w7akwSE5Hj1SMCkkg bEjOqf1bf1XoVZgk+pwAW5N07tJ7mXiAcikV/Y0DCbRAGRoUiMWhKNCXcXLjLUEp0/XK fBMW3zXItrjgT7fulPQvrj1CdG33pXVZxV4sBQaWGWRMaiweBiX3o5B3V2lkkjxE8neW XKEkDK32zj7QMkETFNBPom/7WtSjBrmTqoonlXUKnU70BIslBZX4TfhGGqKFCg416WM1 cHN5B/Bc2WdcwOOQvlCdlVwiufnBc1oJKpL+SSdSL3zy4fHbUpHzYzw4HPkWeSs/Fhg8 /U6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3LM2sRUHhIUmoW8FlRgQ1N5UdjAMF/lVv+RGQ1nEmi4=; b=vQGQpOjGI4NQjjhk0VVlB3YHTy8xo2isoTBnAoJBX4E11ZXF7tw3v7ru1h8BE+A1VS wIl/HIB5dHcll/lunpwaP/r+iS5Hs4jwqg0E89ARmmyjrWo/01j+0SSWntKN+mjIa1yz uDjegCTjZwdJXmjeuMCFGbWkSp0jp4OWHGs/kF8jg1GGU7FJplY+kCWpHQDF6xfVUO+n Kw4atWGk/fQTHjy0AQvGSZMujbwHp8oySpYu5oqrdQqNyV0ZEFGSVsqjVfvNPTwsO8QW Ldjiy1cXv+Bpa3krIEa1JS/WomeFPB4AVQT0ha4rFHWqXVib+/OfiXLi+M9iwyMU0V7l RGCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzxNgGKz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si7098692edv.182.2019.09.23.14.41.55; Mon, 23 Sep 2019 14:42:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzxNgGKz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389677AbfIVSpz (ORCPT + 99 others); Sun, 22 Sep 2019 14:45:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:41662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389612AbfIVSpw (ORCPT ); Sun, 22 Sep 2019 14:45:52 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB8FB206C2; Sun, 22 Sep 2019 18:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177951; bh=kJC6Awz8EDg7dPEGltPbxNIzRDp5I4Bk/eB1xSqgAyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zzxNgGKzMqP+IthGwGq5O2KSgpFDa/oIBNgiML5wmkAg1utHG+UAcT0r7PuvE8wQZ nFFTihsTJAti4rllYuzMrqhac8cQ7kNH/g12GQKqDtR7aOtJYInVTVeDPzbIYQUu+4 CSqv+zGLdxLf8M7a+Wv3Z97BthSx1uzAT3WM0jEc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keyon Jie , Pierre-Louis Bossart , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 5.3 057/203] ASoC: hdac_hda: fix page fault issue by removing race Date: Sun, 22 Sep 2019 14:41:23 -0400 Message-Id: <20190922184350.30563-57-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keyon Jie [ Upstream commit 804cbf4bb063204ca6c2471baa694548aab02ce3 ] There is a race between hda codec device removing and the jack-detecting work, which will lead to a page fault issue as the latter work is accessing codec device which could be already removed. Here add the cancellation of jack-detecting work before codecs are actually removed to avoid the race and fix the issue. Bug: https://github.com/thesofproject/linux/issues/1067 Signed-off-by: Keyon Jie Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20190807145030.26117-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/hdac_hda.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c index 7d49402569149..91242b6f8ea7a 100644 --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -495,6 +495,10 @@ static int hdac_hda_dev_probe(struct hdac_device *hdev) static int hdac_hda_dev_remove(struct hdac_device *hdev) { + struct hdac_hda_priv *hda_pvt; + + hda_pvt = dev_get_drvdata(&hdev->dev); + cancel_delayed_work_sync(&hda_pvt->codec.jackpoll_work); return 0; } -- 2.20.1