Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3114326ybj; Mon, 23 Sep 2019 15:07:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxb8obyslQ1875sYykXF3+siJpPr3hEogZ2V1JIEiCVxS6JQ14reZxQVjs8FkeFsc4tkUHZ X-Received: by 2002:a50:c306:: with SMTP id a6mr2548048edb.108.1569276439295; Mon, 23 Sep 2019 15:07:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569276439; cv=none; d=google.com; s=arc-20160816; b=xGol/9V5LSripnexFa9MUNo5zHKqR2CdQgZuuzGuUTvs7FyhoR15GhbCcer1y0m89j WgAH4OyS703kS4KX4i3YYgifBgYnt4R/DijcQSdzW2yM1RpjB04TRDTsKsoekZOx9SdS tm4PLsrPA2xZGIrT6anmpwTVkeVDlGGP0tn8UIIdstRxZ1Taijihs9JmTd6pf/g73UvD 7pF8vkruNUFGXL/FGP5DOZTTcZ4vnGCiXwCgz/bLlTDZiCyTaixVOGFZhna/iJzh9JXM 37iLfi35ww/drEuxmEdFObRnnE1GwHlBpKeh6JTIwGG/BzDhfYhNAkFR/eTbk3JAlQIR WcAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JfmKwj4ej+idQky/XG3MXHRfnz2H3gdE4fu8J5VqeZY=; b=rAxHAg2/sjLvS19Xs9SB8xQUL1hAspPHyPYqtdM1H0zoHO90aSwIGogMsyTC3tFJ3S dOIpPbYiErLJTBEdCbGGKcdN9ZZEYKnkB1pNN8lAeaMxXuQQJGZad73/rfBeM6Uq8F9A 9HHHW8+o5hC1OXr2/l09ThjS9Udd8CLH+aV403dufUVbGicIq505ngO2QoeQDitn9SmT iBKYD5gQRh5ZXNyOeASZypWny4YNvrqP7LhmoB1QBDgpeiptc2a5tjN1kyL9Iubwt8wM o2m/k9H8jDReiQV8aEUmEfd+al86JzGEaJ0y2qjd1vCJ4d67sAPttnxMEJf0szQZLXSV JSMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cFGiiT+A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si7478442edw.29.2019.09.23.15.06.49; Mon, 23 Sep 2019 15:07:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cFGiiT+A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390460AbfIVSrA (ORCPT + 99 others); Sun, 22 Sep 2019 14:47:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:43234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390380AbfIVSqz (ORCPT ); Sun, 22 Sep 2019 14:46:55 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FF96208C2; Sun, 22 Sep 2019 18:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178014; bh=rpLu/oS3jQttqG3AiJBi6ubdqtvP3hbrdcN6X/C/dR4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cFGiiT+AFA4SfPMwPKYNmvRRC3QzuiVhwITL+MSv2GU+Ro7HQoFngaRHtGIyBunWx 1vzTCy2IAgxleyxTfAf/ra9aYN/LrJMrzjxGyS6vrvzBJTXRnyKoHS4yKJ1oa1LVvE ypNMPMac8ttxhg60PDy9qZi5r8tMKGUO/NGxOpyw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , Pavel Machek , Jacek Anaszewski , Sasha Levin , linux-leds@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 101/203] led: triggers: Fix a memory leak bug Date: Sun, 22 Sep 2019 14:42:07 -0400 Message-Id: <20190922184350.30563-101-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit 60e2dde1e91ae0addb21ac380cc36ebee7534e49 ] In led_trigger_set(), 'event' is allocated in kasprintf(). However, it is not deallocated in the following execution if the label 'err_activate' or 'err_add_groups' is entered, leading to memory leaks. To fix this issue, free 'event' before returning the error. Fixes: 52c47742f79d ("leds: triggers: send uevent when changing triggers") Signed-off-by: Wenwen Wang Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/led-triggers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 8d11a5e232271..eff1bda8b5200 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -173,6 +173,7 @@ int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) list_del(&led_cdev->trig_list); write_unlock_irqrestore(&led_cdev->trigger->leddev_list_lock, flags); led_set_brightness(led_cdev, LED_OFF); + kfree(event); return ret; } -- 2.20.1