Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3114339ybj; Mon, 23 Sep 2019 15:07:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLUN4UC/cfn0Fh1WNtAXcpg41++xqTVZol73JEXeGu1ts/CEvNB22Sk2JcraWNguxMSMGf X-Received: by 2002:a50:e718:: with SMTP id a24mr2441569edn.289.1569276439663; Mon, 23 Sep 2019 15:07:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569276439; cv=none; d=google.com; s=arc-20160816; b=FuuSYXWkKRQY+a5KAeIo60nc2ppzGY+xrrYlEIcAsPjHJpDMDbZI2G0PFf4z/hZcQo VGcyo7a/P3mS3auaSPWTf6OeQxMw0T5lAwSZWU2XJPNydUM4KVQxKRKmTwM+O14Zq1B/ Ekd+Rn+GSQsJZHEGTCoag8DnVeeu2IYyJJ9x+FJIuwqMcE/sMVB9xAvviIG2Uu3FADcj WfiSZk4M6CJ+37OgdnKo9jdvLahIvqFzlX1nfxGe13HRQdXsP+4w4Y4sDFn/j2LD8Uev SGle6Rastr4mdgp7J0ju/VtdrsDLh+yxxAcbtZGJbBSHk+YKxx2okzRdvM2HLAm1huIO B3bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iGBcW5KbUa5ifPbscFkwqzSm663xfkKuEZxERWv5w+Q=; b=w3pFxlRQtkutGo7cnuteh06qxfAotUYtYzWmii3OxYleTCG5pgI5THFtzrCyDAdN05 7eshx1w/J0+gNSueVgOVtg4U25o0+ont+2z5oUR4Nk74AR0eqQGupb26b3wYQG16pXAC vX3wIoPxTWy9zJ0NmsKOGJYFhmN6wjdbnyMVkxJYHINOVka296mtVaHkhsWSOyP5sceP kdf64nq6yV3X++XLusIbubPx7my86Jj8zF0DUFte0o33A1KCoqmCewAbtlH4Hm+Z0qKA Vmn5uqwt7kuL9uM7w0brG8+1L77wQ6wMEvHJluDNreaMEWxpAvNT0pLNsOh86SH8eB+n bzAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yMlPQlGp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ot41si5806314ejb.215.2019.09.23.15.06.52; Mon, 23 Sep 2019 15:07:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yMlPQlGp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390360AbfIVSqx (ORCPT + 99 others); Sun, 22 Sep 2019 14:46:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:43114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390231AbfIVSqs (ORCPT ); Sun, 22 Sep 2019 14:46:48 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4E1D214AF; Sun, 22 Sep 2019 18:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178007; bh=hjmpnAIp7H1b+RS9Gb7JtQbLwf8dNp2GOvMS39yQNrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yMlPQlGpuQkKFlSk4PWxd3rDABJ1mbC4hd0kVwXw7rW+e3WxpU68CHKTwNTiQm+5J iXsO/z/2rPl3UCwGP0LUdiMDIQ0UvBRYw8MftfFctVbe/yPge8pnw/j7/3QWxwLXPg nV11/M0CnF+PecbyayXhrPzkhKQuolbhUs6kVQTw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans Verkuil , syzbot+79d18aac4bf1770dd050@syzkaller.appspotmail.com, Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 095/203] media: hdpvr: add terminating 0 at end of string Date: Sun, 22 Sep 2019 14:42:01 -0400 Message-Id: <20190922184350.30563-95-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil [ Upstream commit 8b8900b729e4f31f12ac1127bde137c775c327e6 ] dev->usbc_buf was passed as argument for %s, but it was not safeguarded by a terminating 0. This caused this syzbot issue: https://syzkaller.appspot.com/bug?extid=79d18aac4bf1770dd050 Reported-and-tested-by: syzbot+79d18aac4bf1770dd050@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/hdpvr/hdpvr-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c index a0905c81d2cb2..b75c18a012a73 100644 --- a/drivers/media/usb/hdpvr/hdpvr-core.c +++ b/drivers/media/usb/hdpvr/hdpvr-core.c @@ -137,6 +137,7 @@ static int device_authorization(struct hdpvr_device *dev) dev->fw_ver = dev->usbc_buf[1]; + dev->usbc_buf[46] = '\0'; v4l2_info(&dev->v4l2_dev, "firmware version 0x%x dated %s\n", dev->fw_ver, &dev->usbc_buf[2]); -- 2.20.1