Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3119299ybj; Mon, 23 Sep 2019 15:12:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhcmda8lSCju+DvpPzY3+dQBP5NriZeEmsYp9XNE+EzfbS7VU7Qt8H/hAd9FWs2mJbuDex X-Received: by 2002:a50:a7c4:: with SMTP id i62mr2442134edc.92.1569276745106; Mon, 23 Sep 2019 15:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569276745; cv=none; d=google.com; s=arc-20160816; b=EhRcZbV7XMblAHrdot9oK7AUV2LGkU9Sc3sWk6TgUuOac4sZb2isr+I6Sixi8eAeJg 4hwuUXPbUW9lTqt5jfOjYZGGn5UnG3/TAE/ghTBy3c3FBSYLy7gfqhPI6nR0OhFLlyBx LnoV5sUpKcdxBdaxLVEril1TfmzaZ+b3M9Cki9pyNomRY1JLuck+djkNoPpknoGa/SU+ Uzs+ZE9iw1J3ZyCef4mG1Mp00lSeY9YpRSi288mZYdCVfty3mMoJEqLz0Ql2QpqOxaF/ em5FBymVQPqk6PujklPzQGWRQf4a5weU//hFGHaWPpKn03Btqo2NUsOHiNS5YB3Z45I4 svjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5TT7sybZExs7Yb/oB6r5a7ed3efAZZdUg0ZGS3O1+i4=; b=fIm6NTawZSTgDSYykXk1hNFRnJGAO7DZ2n+YtTrVMiqqekK9hstSbLA/Je8Km1ArYX uoRV+COYhwyICiyvmWbRZi3OOlCcnFYFYoh66D10oa5F09qyU/t6Tojzb6xyC0fNOU3a ibV+Y4tzxvLpjdRdTJ9KsZBp7Q2KP0rBsOsY18JpqZZs1HNbjZ0kjvJZ31GqEPfGGv5D nulwnyIjXYULYC1PeyZcYTEB9+7blLsE+toGw4MH/m6YoGi/mAuYGgJLZ03gFH67H/4W QJGnfZq7+5kXcKooQ4PVjKUsiHz1y9aDvImd6z3mBnQF0r2WLhu4GxbxBFB8f7ZhksvB FcMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g6ndi1jq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si5883714ejj.363.2019.09.23.15.12.01; Mon, 23 Sep 2019 15:12:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g6ndi1jq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391091AbfIVSrl (ORCPT + 99 others); Sun, 22 Sep 2019 14:47:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:44134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391077AbfIVSrj (ORCPT ); Sun, 22 Sep 2019 14:47:39 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 910A4214D9; Sun, 22 Sep 2019 18:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178059; bh=zRRSafVxTQ5grYDlfaRz+gppOToyxtG9qdrTKTUUJ/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g6ndi1jqpjctBHCoVdYXb9BEwFLo1Vm9idjZDaBw6rETZGhZ7itm1EidiaqgN34Y9 TECgr7CPpEtR/5mmjwjL/E00brukx7QS83wXdJijJXOFIam7t7A20A2PNWtSHc09he RpM1GrB0BZ/cK4eXsr6tGCDVM+/LJtiiQbfdLMVA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Douglas RAILLARD , Peter Zijlstra , "Rafael J . Wysocki" , Sasha Levin Subject: [PATCH AUTOSEL 5.3 135/203] sched/cpufreq: Align trace event behavior of fast switching Date: Sun, 22 Sep 2019 14:42:41 -0400 Message-Id: <20190922184350.30563-135-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Douglas RAILLARD [ Upstream commit 77c84dd1881d0f0176cb678d770bfbda26c54390 ] Fast switching path only emits an event for the CPU of interest, whereas the regular path emits an event for all the CPUs that had their frequency changed, i.e. all the CPUs sharing the same policy. With the current behavior, looking at cpu_frequency event for a given CPU that is using the fast switching path will not give the correct frequency signal. Signed-off-by: Douglas RAILLARD Acked-by: Peter Zijlstra (Intel) Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- kernel/sched/cpufreq_schedutil.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 867b4bb6d4beb..b03ca2f73713d 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -117,6 +117,7 @@ static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time, unsigned int next_freq) { struct cpufreq_policy *policy = sg_policy->policy; + int cpu; if (!sugov_update_next_freq(sg_policy, time, next_freq)) return; @@ -126,7 +127,11 @@ static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time, return; policy->cur = next_freq; - trace_cpu_frequency(next_freq, smp_processor_id()); + + if (trace_cpu_frequency_enabled()) { + for_each_cpu(cpu, policy->cpus) + trace_cpu_frequency(next_freq, cpu); + } } static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time, -- 2.20.1