Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3123556ybj; Mon, 23 Sep 2019 15:16:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWM3FfKdKM2h7svOepXoybWQ9R2gyGyIi70tvW6s5g+91UCMae8Zhq7a1TkPlpgFa1/X8K X-Received: by 2002:a17:907:4242:: with SMTP id np2mr1834650ejb.102.1569277010707; Mon, 23 Sep 2019 15:16:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569277010; cv=none; d=google.com; s=arc-20160816; b=YfZ0zfdB8TcGoTh+BTencecrzdx/s0eDXhggIQuBl7yh8LVVhMtHurMuMjadKbqNL6 Kh+j04HzgSeM9B57TivPa7Uh0RZBI6pCMMXy7OMR2DWp4Ca5nZfnek2PuCd5o/NCwWCD sQRgGivFBF0WDHXLOH98JPqeKk1NW5TSJJLqOn8espYOk/VlIWgOSazVCHYQ2Fd3OM8F oaEW9ed0zGDwdePBeHY+oTCVCyvRoEq2YYkcFAn/JVIl8qVkO8KmXqi89njQyUJxuu3T aXcw9KQ2q1xP9QtrzGDiF5yFcDQT0vOxTA3EsJEQ8eBjznRglRV7PWlqAUkbf3gHpf+h jl3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kpaaV4GCDnVrNGkSiKLkrNQ6KTxqTa3mz+0Jy3KM4Ow=; b=M6mHSJ1Nbiu1j+KxiPdxM97m77Rit1T9Klvzmm847/wqAW3d4v2v9NZFLF7tkU41vR A0LjEOHH14ppRy0jdn7lAAWpEZhG8JBrIv6S/CaF8YGKK/cbht2f2IzKF/GxYg0z+EWW DgLqyZHT5O/zsYES12QRNc5KDSe63gaMXIEMuDcz3SByGDikSs1Fab6EjiYNgcBJikBb sJur+W7iILSBSSx3+u40iTioIrdSYxsezJ8oIK86djfBDBj8ZBESngKU0MLSJHkRfJhu H4nCb7jUjYZxmMnwqOLw6hRQaBGsBqhaidAnMwBQRLw2SZDmTGNZPJs49a1e9ciSferl gOYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="IuYy0/Gr"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si7764186eda.213.2019.09.23.15.16.27; Mon, 23 Sep 2019 15:16:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="IuYy0/Gr"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391372AbfIVSsG (ORCPT + 99 others); Sun, 22 Sep 2019 14:48:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:44586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391288AbfIVSr7 (ORCPT ); Sun, 22 Sep 2019 14:47:59 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C74021479; Sun, 22 Sep 2019 18:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178078; bh=dzieCr/axxqMz92jBnTQ1G764nndP0Xbet2Pe5781Xs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IuYy0/GrKS+55M7TP/yHv3uUI+GesbvNsYkTr3nmZb8N4O5JLB2Yzza54D7B8Get/ GRgvY+5tU1xLKyHpMZbned72jDYyxcl85ec56cyCiE+yFa7rzM9Tz1YMkL4EBzpPcU zM6MYS7rGCoUZT4YsTKH2OYqObtmY5+BuBrUyGUw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qian Cai , Joerg Roedel , Sasha Levin , iommu@lists.linux-foundation.org Subject: [PATCH AUTOSEL 5.3 149/203] iommu/amd: Silence warnings under memory pressure Date: Sun, 22 Sep 2019 14:42:55 -0400 Message-Id: <20190922184350.30563-149-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qian Cai [ Upstream commit 3d708895325b78506e8daf00ef31549476e8586a ] When running heavy memory pressure workloads, the system is throwing endless warnings, smartpqi 0000:23:00.0: AMD-Vi: IOMMU mapping error in map_sg (io-pages: 5 reason: -12) Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 swapper/10: page allocation failure: order:0, mode:0xa20(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0,4 Call Trace: dump_stack+0x62/0x9a warn_alloc.cold.43+0x8a/0x148 __alloc_pages_nodemask+0x1a5c/0x1bb0 get_zeroed_page+0x16/0x20 iommu_map_page+0x477/0x540 map_sg+0x1ce/0x2f0 scsi_dma_map+0xc6/0x160 pqi_raid_submit_scsi_cmd_with_io_request+0x1c3/0x470 [smartpqi] do_IRQ+0x81/0x170 common_interrupt+0xf/0xf because the allocation could fail from iommu_map_page(), and the volume of this call could be huge which may generate a lot of serial console output and cosumes all CPUs. Fix it by silencing the warning in this call site, and there is still a dev_err() later to notify the failure. Signed-off-by: Qian Cai Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/amd_iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 61de81965c44e..e1259429ded2f 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -2577,7 +2577,9 @@ static int map_sg(struct device *dev, struct scatterlist *sglist, bus_addr = address + s->dma_address + (j << PAGE_SHIFT); phys_addr = (sg_phys(s) & PAGE_MASK) + (j << PAGE_SHIFT); - ret = iommu_map_page(domain, bus_addr, phys_addr, PAGE_SIZE, prot, GFP_ATOMIC); + ret = iommu_map_page(domain, bus_addr, phys_addr, + PAGE_SIZE, prot, + GFP_ATOMIC | __GFP_NOWARN); if (ret) goto out_unmap; -- 2.20.1