Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932080AbVL3Ved (ORCPT ); Fri, 30 Dec 2005 16:34:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932104AbVL3Ved (ORCPT ); Fri, 30 Dec 2005 16:34:33 -0500 Received: from gateway-1237.mvista.com ([12.44.186.158]:24819 "EHLO hermes.mvista.com") by vger.kernel.org with ESMTP id S932080AbVL3Vec (ORCPT ); Fri, 30 Dec 2005 16:34:32 -0500 Subject: Re: [PATCH] protect remove_proc_entry From: Daniel Walker To: Steven Rostedt Cc: LKML , Ingo Molnar , Andrew Morton In-Reply-To: <1135978110.6039.81.camel@localhost.localdomain> References: <1135973075.6039.63.camel@localhost.localdomain> <1135978110.6039.81.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 30 Dec 2005 13:34:26 -0800 Message-Id: <1135978466.32431.12.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 16 On Fri, 2005-12-30 at 16:28 -0500, Steven Rostedt wrote: > + spin_lock_irqsave(&remove_proc_lock, flags); ... > + spin_unlock_irqrestore(&remove_proc_lock, flags); Why do an irqsave here? Are you not sure what context it gets called from? Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/