Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3255926ybj; Mon, 23 Sep 2019 18:01:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzm6wnZaZ2hqYj4btASPQdKG1YC1vWAyzba9ksR4fcgiX3rgezQluBmv1WGVX3qMDFDZNde X-Received: by 2002:a50:ab58:: with SMTP id t24mr24887edc.131.1569286908022; Mon, 23 Sep 2019 18:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569286908; cv=none; d=google.com; s=arc-20160816; b=OyJK6Zu2CCUlMwnSzysX2ZOmhcaDTNtG5mqhDhQlKkontEXgKSkWKMkGDlnog518JI LwwulBF62ZDTxExa0MlZZtHrhyPKdZAXGy+XhEBwPqOZb+SYq6BpuYPYQw7hbFimRJRZ jhvtoIqMtnsy34F9eRNATkcpWL83EpRwTv+S4Dn3XormLXCCo17WkCbwh1iAvsZO4PmX PCg8jNJd+lthb0aPu+AnrzLHo5QI91lTqYTGxQM27PEtQDA/gJaR46KXpo2B0WojcmS7 7385P0l6v6MBKeWm98e6a3tPZ/Z25qPUP64A2pjXgRtC1ohS9lmlpGHVTrmHCmBd3zu4 tcKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RySFzyIddmZg5Iw3/8RCFmtGpRfmYuDQ5EYDqdOHgIE=; b=p07D4S2TfL+XeD150TGbkcEBuBFeUlFc7fzBQLI8h5xS8YwffzFrdRgzGyBe4TpSi1 OdsE88DpIs3ssRDxvrqb5Dd0qP74mdX4H9dYf1QDCXuq/0OwvndLRKJeorpUg5Y7gbbt 5XADYy4pyM5yrJUqd2If5+LMXH1iljQW2KfYWZv7vOmnVnnBS8CpGsj6Y+KuM5i/YWjM 1ismwqv5vCjufsWuPkkpnJK62NcuhbfeAhtrhsmZYklM658j84RQxJyXK0gvx9mai/9c NnvViLWqBk97gzlOgJ3u2+68SrlzhhnNiYubZxwNqNwL7qqIzeaaxVwuMLt+uQ+kEkIh D7Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tb080fzc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2si70855ejo.82.2019.09.23.18.01.08; Mon, 23 Sep 2019 18:01:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tb080fzc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392148AbfIVStP (ORCPT + 99 others); Sun, 22 Sep 2019 14:49:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:45874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391864AbfIVSsz (ORCPT ); Sun, 22 Sep 2019 14:48:55 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 345E821479; Sun, 22 Sep 2019 18:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178135; bh=55epLifv/9ypt2pWBrwbCrVU96q+XbcR0MUL9tS6NaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tb080fzcea1f3yGtTMjbTNmM6VxTVHTS2d8bqRDtnoikMwPnZLNy9qVTmh3wM7PQ7 MmywxsbZnmpYkw5cTlBsQrsPjL0Bj9yQnB8d8pyLZphpnFYF3MZjqN+ces/CRbghGA WaikZbjJEZzkN/CMLt94Tztev1ZzvMrsaAGumMG0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nigel Croxon , Song Liu , Sasha Levin , linux-raid@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 186/203] raid5: don't increment read_errors on EILSEQ return Date: Sun, 22 Sep 2019 14:43:32 -0400 Message-Id: <20190922184350.30563-186-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nigel Croxon [ Upstream commit b76b4715eba0d0ed574f58918b29c1b2f0fa37a8 ] While MD continues to count read errors returned by the lower layer. If those errors are -EILSEQ, instead of -EIO, it should NOT increase the read_errors count. When RAID6 is set up on dm-integrity target that detects massive corruption, the leg will be ejected from the array. Even if the issue is correctable with a sector re-write and the array has necessary redundancy to correct it. The leg is ejected because it runs up the rdev->read_errors beyond conf->max_nr_stripes. The return status in dm-drypt when there is a data integrity error is -EILSEQ (BLK_STS_PROTECTION). Signed-off-by: Nigel Croxon Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- drivers/md/raid5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 21514edb2bea3..d574701185db9 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2526,7 +2526,8 @@ static void raid5_end_read_request(struct bio * bi) int set_bad = 0; clear_bit(R5_UPTODATE, &sh->dev[i].flags); - atomic_inc(&rdev->read_errors); + if (!(bi->bi_status == BLK_STS_PROTECTION)) + atomic_inc(&rdev->read_errors); if (test_bit(R5_ReadRepl, &sh->dev[i].flags)) pr_warn_ratelimited( "md/raid:%s: read error on replacement device (sector %llu on %s).\n", -- 2.20.1