Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp3268671ybj; Mon, 23 Sep 2019 18:16:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxuZeygEml9z/W5m8tvuAkyrDNBBFFkgoDok6z5nQtZZ87RV6ojznPGAk22EIy6HLoiJTPx X-Received: by 2002:a50:d6db:: with SMTP id l27mr100120edj.164.1569287764942; Mon, 23 Sep 2019 18:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569287764; cv=none; d=google.com; s=arc-20160816; b=xGR7InVvVDYxqPEuSkdBqbEg92hKKRPEbqYTleUA/IW1YcNeVEUgEKO4Z/EsCp70MK nAkAaNA5bEJ4JsHfXjFi0v/5uTnom5TAxZJ5KbHB553NMu+87fQptDVENRv4JXxNThHl 3Ac5DGB0aBXjA62KuTKj+Sa6mteJZA9OR3dLdqrJ2cHVcIyo1VJsyFWw3N083ptR3bP+ O+rCBs282wkMJ1COXSh9Ucl4SiCdTOYmM/yvdJm2CfqDaKNhAcIdaRKbK/vVVZW8Mutx cBb2pjrjnfVVD65R6axoz/lG7XBZJUXF4+A+1eZJNZmEUoFklIJ5tXWHRNZ38pWcLXVD kZjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0Wjx/NfYq2vHl0hhof/FHJ2WL+Oh3CiP4t1wMW8hgtw=; b=gpoBh0pwzLFtCpo6Racym1mW1xz6iOc8577Wk7lKBL3DbOdt0jYSCGvZTxfIxZyKCS 9bw3lOwNFB5aN1IoILstArGxqx2wutw1grdneOxuXi5+KLEi6Ca38QhUn9GgNg0yRzUB +EWgPw5qce/LGJg+FtGwquxjmr8xtCy4gztJ5v0K0Q8dkZJLrWwWqZXsTwvtQYLyfNx9 W+GfwT71hW5CNJKnlHNPxC1XHp32GN3DGQ5740BlTffNWx00CixYcwmyNMa8VsVsVuiM OJM0uehp7xdsCRFZ+voa+MWMNTJPWlOdmPyr7s8drTRi+ODdkHQDZJDJhfhatpdA/i4j y/dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dYo53l8v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j52si152964eda.338.2019.09.23.18.15.41; Mon, 23 Sep 2019 18:16:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dYo53l8v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392228AbfIVStT (ORCPT + 99 others); Sun, 22 Sep 2019 14:49:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:45938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391897AbfIVSs6 (ORCPT ); Sun, 22 Sep 2019 14:48:58 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D004D21A4C; Sun, 22 Sep 2019 18:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178137; bh=kEqj6OLGPamqmRohSMQQqEmFs4DfR7akg0YU+5Kzct8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dYo53l8vXPjtuAayysOj9u/Q3Bh5Qxp+sxq+HVrbaVXULQ5eMzRfb0rcVnXi18+gR XiO1JetI00sCOXhsTRjbodLL4GyI/heCcnEpFt0ucg0elgu9NAuJtM/gdXeju8Bt3L 4HFpzODfMhSHAZW9m4LQgH1IghY/r7pXbk8k36RU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sean Young , syzbot+eaaaf38a95427be88f4b@syzkaller.appspotmail.com, Kees Cook , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 188/203] media: technisat-usb2: break out of loop at end of buffer Date: Sun, 22 Sep 2019 14:43:34 -0400 Message-Id: <20190922184350.30563-188-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Young [ Upstream commit 0c4df39e504bf925ab666132ac3c98d6cbbe380b ] Ensure we do not access the buffer beyond the end if no 0xff byte is encountered. Reported-by: syzbot+eaaaf38a95427be88f4b@syzkaller.appspotmail.com Signed-off-by: Sean Young Reviewed-by: Kees Cook Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb/technisat-usb2.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c b/drivers/media/usb/dvb-usb/technisat-usb2.c index c659e18b358b8..676d233d46d53 100644 --- a/drivers/media/usb/dvb-usb/technisat-usb2.c +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c @@ -608,10 +608,9 @@ static int technisat_usb2_frontend_attach(struct dvb_usb_adapter *a) static int technisat_usb2_get_ir(struct dvb_usb_device *d) { struct technisat_usb2_state *state = d->priv; - u8 *buf = state->buf; - u8 *b; - int ret; struct ir_raw_event ev; + u8 *buf = state->buf; + int i, ret; buf[0] = GET_IR_DATA_VENDOR_REQUEST; buf[1] = 0x08; @@ -647,26 +646,25 @@ static int technisat_usb2_get_ir(struct dvb_usb_device *d) return 0; /* no key pressed */ /* decoding */ - b = buf+1; #if 0 deb_rc("RC: %d ", ret); - debug_dump(b, ret, deb_rc); + debug_dump(buf + 1, ret, deb_rc); #endif ev.pulse = 0; - while (1) { - ev.pulse = !ev.pulse; - ev.duration = (*b * FIRMWARE_CLOCK_DIVISOR * FIRMWARE_CLOCK_TICK) / 1000; - ir_raw_event_store(d->rc_dev, &ev); - - b++; - if (*b == 0xff) { + for (i = 1; i < ARRAY_SIZE(state->buf); i++) { + if (buf[i] == 0xff) { ev.pulse = 0; ev.duration = 888888*2; ir_raw_event_store(d->rc_dev, &ev); break; } + + ev.pulse = !ev.pulse; + ev.duration = (buf[i] * FIRMWARE_CLOCK_DIVISOR * + FIRMWARE_CLOCK_TICK) / 1000; + ir_raw_event_store(d->rc_dev, &ev); } ir_raw_event_handle(d->rc_dev); -- 2.20.1