Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp751347ybn; Tue, 24 Sep 2019 08:59:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqyABZLbUuTn/7wxo94w00/xCLporoHBwlg19Ql7HEFLc4I4kE1i6aHd+jHMmxeXQ0X5r4eH X-Received: by 2002:a17:906:d04f:: with SMTP id bo15mr3302316ejb.296.1569340750096; Tue, 24 Sep 2019 08:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569340750; cv=none; d=google.com; s=arc-20160816; b=dTTW/ZTOKA0KHGXGXZEmTboYl1eDEDo/ziX9FKHCQLkxKvisrjzzDGnRwIZV16U4v2 N7DtSF9PQHvc72le0ix1J5BJ4y6vWkN47UIIi82mzQn661Bbm6/9qR30BDB+Ra/kXIQR hVavWGCwPAjqWiuYjqxhIbBhXOWTxp9W5eXSLbH8nlnQVkFqfy0kkbituvCLSY3cJQQq tDiQME5TBhTOjyfM0BnMjppX/RV3wjkDw6KairZGXfdpDcXslk3ZZ8r+XT7mzMslpkes +t+iDmOGeXKHdgW5Fr6c9hUD9gErbxIwMYw6tl2Xbq0VMXgKDESY3iYl82rck6HQRaHs 9m5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2RQLAlftE53X+6zcNpMMEiZwturHy5tkWNLGf2d9qA4=; b=MnI2wscO60sHCzHsqyS+bvCLea/jjZbXGLeVOneOCxdaZ67NPsvRmHO9y3jkSE5uoG hKAU7/M2Vnikq5ijUEWnWq6XHkEEf6PW1Q7Azbq3+Vp6IrNBJ1vTVTmg0DtrV/Nl8V9U Mt/zD2TpNZUILzRvwsjGeAvQQ43b/6kKGtuabHHi3qdd7Zc084/Z5mug9Uzwd/QPzpAC WYnQlhTVzK6ArxOqrukwoqjrlfKtC0N82BSCa9/tQP/V45Zxfa7DJzb5wrL93q4EtbsE Od89z4LZ8rbp4o5u/yRmxmRR61f7KfcPjE0Gl9vKNzS6EWokLjS3dnZ599lyp7xsw0Pm zJoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Iv9NxLep; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ec21si957706ejb.26.2019.09.24.08.58.46; Tue, 24 Sep 2019 08:59:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Iv9NxLep; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439204AbfIVTgB (ORCPT + 99 others); Sun, 22 Sep 2019 15:36:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:42718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389892AbfIVSqd (ORCPT ); Sun, 22 Sep 2019 14:46:33 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8F9720882; Sun, 22 Sep 2019 18:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177992; bh=7p/PpIJVXp3yefC5Tsd+O11UJMhZ4iW3qIEvbURNxrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Iv9NxLeplQw1hN6d33wVtJoQLx65rTXRAKAdBM126120OShSfpPkOXaRZSK74Jm7g 4Ttm20L2il0Ju+PFHsaq6HfEKOatjZWwXUTN830tUm4nDF9gM67K7QSRZmMwmBCp+B sXoreKhIMmza9ApSuxzmOdNTII3u1uUKeMA3iK1k= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 084/203] media: omap3isp: Don't set streaming state on random subdevs Date: Sun, 22 Sep 2019 14:41:50 -0400 Message-Id: <20190922184350.30563-84-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] The streaming state should be set to the first upstream sub-device only, not everywhere, for a sub-device driver itself knows how to best control the streaming state of its own upstream sub-devices. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/omap3isp/isp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 83216fc7156b3..9cdb43859ae09 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -719,6 +719,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe, s_stream, mode); pipe->do_propagation = true; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return 0; @@ -833,6 +837,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe) &subdev->entity); failure = -ETIMEDOUT; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return failure; -- 2.20.1