Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp774476ybn; Tue, 24 Sep 2019 09:17:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/+3YihurEkOUSTeaLmLJhKd2KLPqFW3PJQyd6TgyrTrMYXMQzTb4d6qlBc4WLhzw2TOUO X-Received: by 2002:a1c:7914:: with SMTP id l20mr927498wme.155.1569341847419; Tue, 24 Sep 2019 09:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569341847; cv=none; d=google.com; s=arc-20160816; b=zawEwV6ghUO+/TevKf/OtuCC5U89BG2PBaOihDA37dMgu+vzAMCJmFtar6AYD/a3rf iSlRRzqsxAXry7b0FhUSMFm9P9sZKs9LNKGOYj0DDtZWeeqgWBdsIpt21YmzlgwqaOGr zdCCoPjUGiJO8aifVhNQaHpivX0QWQzW+OY5jMTQgEdQw6mWfYnP0/O3AfFcJbG9599w pz96k+4L7x0tKokflQfE9fXSUPolnS/h6OC+43PrNmI6qUDX/P6QSndtLjnwV6edUd7g ggc62r8/lsBFWsptZKW092MRO8MtpfIatfML4EcwfUB7ORgDIZglFaAAchiu3CP9kwlv ytAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DEVelxsn/F+b77DoJCA+JxMfnJER3eXFbSub5sa+3Q8=; b=xzsvzyMz73Z4R7Ljf1OeugpkhXIrZ2vrMP9FwRED3q2QVepWDN6GaT/iETTGO30bdT fS4bKW5CHJ9sE9XUwOSiegGOVGOu5DusgGVn73t+0aKzGBhhSJiWn0xgpeBp7sU7wVCZ Qzdcm3/WfeRnJAz7S5Aeej0JwdzBKzZe/qxR5gyuf5QjXVFBjaVYCtCQVOj9IE7UOG1e cxdTDnM8E1dt6gwyoqY1qSb72ONBg9qUigoRRzWCR0TXNr2LC1wMCIXM4GLoCwWrBwF8 X22B7719GBAh24Tn7AlOf9Gqpa29Olr3MT8VBECb83FwNx2UCgdFuymIknVOruqA0LY5 2tiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZeYe+tWc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si1306888edr.443.2019.09.24.09.17.01; Tue, 24 Sep 2019 09:17:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZeYe+tWc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439303AbfIVTit (ORCPT + 99 others); Sun, 22 Sep 2019 15:38:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:40990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389139AbfIVSpU (ORCPT ); Sun, 22 Sep 2019 14:45:20 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 635292186A; Sun, 22 Sep 2019 18:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177919; bh=XNkArJrgmFA4u/o7SMJx8gZU/YYccW+idXxXPo25A9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZeYe+tWcqAjOBwA8kY3KevL2YqleG0QltTlhUeyNCP9oO/tOB4RW+KzoC3BPur2Rk Ukj0AidfWhOivgjVOBCkkLwlB/tCmXqlcFVon4hG1fiGW1+Wyi7k2bVYgzNx/N/yfl mW6lgye9ydVau42Gu8gvNsFZ5DD8+zWyXYxepiuY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Takashi Iwai , Sasha Levin Subject: [PATCH AUTOSEL 5.3 032/203] ALSA: hda - Show the fatal CORB/RIRB error more clearly Date: Sun, 22 Sep 2019 14:40:58 -0400 Message-Id: <20190922184350.30563-32-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai [ Upstream commit dd65f7e19c6961ba6a69f7c925021b7a270cb950 ] The last fallback of CORB/RIRB communication error recovery is to turn on the single command mode, and this last resort usually means that something is really screwed up. Instead of a normal dev_err(), show the error more clearly with dev_WARN() with the caller stack trace. Also, show the bus-reset fallback also as an error, too. Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/hda_controller.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c index 48d863736b3c3..a5a2e9fe77854 100644 --- a/sound/pci/hda/hda_controller.c +++ b/sound/pci/hda/hda_controller.c @@ -869,10 +869,13 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, */ if (hbus->allow_bus_reset && !hbus->response_reset && !hbus->in_reset) { hbus->response_reset = 1; + dev_err(chip->card->dev, + "No response from codec, resetting bus: last cmd=0x%08x\n", + bus->last_cmd[addr]); return -EAGAIN; /* give a chance to retry */ } - dev_err(chip->card->dev, + dev_WARN(chip->card->dev, "azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n", bus->last_cmd[addr]); chip->single_cmd = 1; -- 2.20.1