Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp774481ybn; Tue, 24 Sep 2019 09:17:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyJervSYoSeVOyxNBBVqCyL8EExAmzpFsZd0/6xGyp57c1tyd3vMqhFTH7OMvIT19dARKHo X-Received: by 2002:a17:907:211c:: with SMTP id qn28mr3265904ejb.244.1569341847598; Tue, 24 Sep 2019 09:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569341847; cv=none; d=google.com; s=arc-20160816; b=Y17moSMhxH3U6PHCzSKbF2BXHR0DT618rj2MbZsFP6KotkGupMBD9oLrIk2IchNs3Y O8s1etoxav0qRc6oFyrS8KwDW0bmGIBlVK9qrS+iB7kV7AxFlZETF+7kkntQ+uUYzJGM HZPVsFESjgU7BL7FRkvcemtQGdHg7v04evS8+Y9hWHdsrd/so9WtQ9m9jdwoWFLl4ym5 XF9nrggk5GuRKaGWF3dAmhA6uhDIxc58UzuPG9JNnCjLH0+i7Dy7x5x9hx/FitHlNqLx SOTXDJ3TtsbMypdPFYuiGmo/LmsL7/pWKjWA8otDlDFkANGk50k+lN3VvjJteDhZ+ATa C5gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SwcscPs62dgyaqqUp/c9Ap/H2vniSAoMkplA4yi8+4M=; b=t1FzWk7k52Ish30v6IBRfW3qPwYdkykypxlG3MCbFpD1+BHackJqTucaloNGmS/ZXj mjCumzRVuUEr+1r5JMvUtuFU0CMuVSWAOKdl5/HEx5q1RzQyKzXSeL29aI73sT3rvaZK InkcRCHnn2Q5trce+ATJMkCDvuOeOuU5gXYbAvTIy3p+GknX2KMKXxhzsirRI/v3diM7 ZUdZKAkEJrmOhgewS3/A/1tYBR/83XhMpJCILzQBfz2Y/FLow6abI7G4jqITnbsvN7fo tujV0vogiHIeuFsUTi4dvWJdUjXGGnyx7LM1fCYlFL5d/4sXNndh9hNHZ9UJJQfRsYvn nJFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="jcIV/zWT"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18si1204721ejr.189.2019.09.24.09.17.03; Tue, 24 Sep 2019 09:17:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="jcIV/zWT"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439313AbfIVTiy (ORCPT + 99 others); Sun, 22 Sep 2019 15:38:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:40906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389112AbfIVSpS (ORCPT ); Sun, 22 Sep 2019 14:45:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7FF92184D; Sun, 22 Sep 2019 18:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177917; bh=Xyvrre4X+S8jYk7Ug49uysaicfimb21oXHG48XhPxd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jcIV/zWTnk8eDOGMM84aCQ3pppemUm2LVVuDyF1RqR8e/X+VHcZSrhS8mUSrAaxwc /s4tglP1A0h1fqABeKZOEk647RzvkNYoFPJ051Ua+R0ytvh+SI7Ff3PTvGbbQESy8H g3edJ5I31C5+4HjOanWuO5MOl6ugQJDibUjNSa7Q= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juri Lelli , Peter Zijlstra , Dietmar Eggemann , Linus Torvalds , Thomas Gleixner , bristot@redhat.com, claudio@evidence.eu.com, lizefan@huawei.com, longman@redhat.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, rostedt@goodmis.org, tj@kernel.org, tommaso.cucinotta@santannapisa.it, Ingo Molnar , Sasha Levin Subject: [PATCH AUTOSEL 5.3 030/203] rcu/tree: Call setschedule() gp ktread to SCHED_FIFO outside of atomic region Date: Sun, 22 Sep 2019 14:40:56 -0400 Message-Id: <20190922184350.30563-30-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juri Lelli [ Upstream commit 1a763fd7c6335e3122c1cc09576ef6c99ada4267 ] sched_setscheduler() needs to acquire cpuset_rwsem, but it is currently called from an invalid (atomic) context by rcu_spawn_gp_kthread(). Fix that by simply moving sched_setscheduler_nocheck() call outside of the atomic region, as it doesn't actually require to be guarded by rcu_node lock. Suggested-by: Peter Zijlstra Tested-by: Dietmar Eggemann Signed-off-by: Juri Lelli Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Thomas Gleixner Cc: bristot@redhat.com Cc: claudio@evidence.eu.com Cc: lizefan@huawei.com Cc: longman@redhat.com Cc: luca.abeni@santannapisa.it Cc: mathieu.poirier@linaro.org Cc: rostedt@goodmis.org Cc: tj@kernel.org Cc: tommaso.cucinotta@santannapisa.it Link: https://lkml.kernel.org/r/20190719140000.31694-8-juri.lelli@redhat.com Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- kernel/rcu/tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index a14e5fbbea467..eb764c24bc4d4 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3234,13 +3234,13 @@ static int __init rcu_spawn_gp_kthread(void) t = kthread_create(rcu_gp_kthread, NULL, "%s", rcu_state.name); if (WARN_ONCE(IS_ERR(t), "%s: Could not start grace-period kthread, OOM is now expected behavior\n", __func__)) return 0; + if (kthread_prio) + sched_setscheduler_nocheck(t, SCHED_FIFO, &sp); rnp = rcu_get_root(); raw_spin_lock_irqsave_rcu_node(rnp, flags); rcu_state.gp_kthread = t; - if (kthread_prio) { + if (kthread_prio) sp.sched_priority = kthread_prio; - sched_setscheduler_nocheck(t, SCHED_FIFO, &sp); - } raw_spin_unlock_irqrestore_rcu_node(rnp, flags); wake_up_process(t); rcu_spawn_nocb_kthreads(); -- 2.20.1