Subject: Re: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver
From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
In-Reply-To: <20051230080002.GA7438@kroah.com>
References: <patchbomb.1135816279@eng-12.pathscale.com>
	 <20051230080002.GA7438@kroah.com>
Content-Type: text/plain
Organization: PathScale, Inc.
Date: Fri, 30 Dec 2005 15:11:44 -0800
Message-Id: <1135984304.13318.50.camel@serpentine.pathscale.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1142
Lines: 33

On Fri, 2005-12-30 at 00:00 -0800, Greg KH wrote:

> >   - The driver still uses EXPORT_SYMBOL, for consistency with other
> >     code in drivers/infiniband
> 
> Why would that matter?

I don't want to do something gratuitously different to the prevailing
set of code in which it lives.

> >   - We're still using ioctls instead of sysfs or configfs in some
> >     cases, to maintain userspace compatibility
> 
> Compatibility with what?  The driver isn't in the kernel tree yet, so
> there's no old kernel versions to remain compatibile with :)

We already ship userspace code to customers that relies on the ioctl
interfaces.

> I also noticed that you are still using the uint64_t type variable
> types, can you please switch to the proper kernel types instead (u64 in
> this specific example.)

Yes, we'll use u64 for internal variables, and __u64 for stuff exported
to userspace, etc.

	<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/