Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp809121ybn; Tue, 24 Sep 2019 09:50:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxN1eXPiqA6QEQFNHXPEeDMxFU9LGo/MUNosD0Pf4If69m2m4QBijuCaJ8VZzHXytX4dLOV X-Received: by 2002:a17:906:3615:: with SMTP id q21mr3376390ejb.201.1569343819444; Tue, 24 Sep 2019 09:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569343819; cv=none; d=google.com; s=arc-20160816; b=aSPxnaB8/Uh6OreTYrFOnHNZtYcqm2FqUbQMbXqiBciJwXHabqFmOT8HNtkyVaJB1K q3xOl3nyaz3D6X+LYP6AHh5FHrXL/f9VWs+XR5mpxn37rPGyXf94T1ek37dqsVGT5NbE We9yIY4NS/qNtdgx+0fctogJuwQciufIvbKbwAxMWgkCxUIdI7IPlcIZGd5yyprN+8CE O0I+WrAnGv/iHZg50CfROgf8hDWZDOOc2MCAADClEDmsitEqZ5APk0iNYj0xf2uWVKLh IksEkvPLVEW0RPO73t1bUSE/EKakQR80SpuGXK4qyOpe5AuSMe9rPvsNeswvoMAtDQsM Yf8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UT3PnwLVcdmwR9VnUoH9VVs7QNgY5WypIw97ga0FmXU=; b=uyoWVIh88OTf8rXEfyz/za5JM59LECGK+OeO6yLCykO5it+TnUP33o8hPrnsnFuFZz tuIZvnIKpqrxU+FKErCk3CYGaPojp+VUdH2o9kSWWloyB5e7mQBEqz1jlTtGixySR+lK J+uQR2RVi/DH4WivIbdGkKDaYmpSzoXmRd6rEEz6Pp5gQaCPT6lDdL7L3SHN1lad47zl qpzkhd/HzFGkruFc6jtEUUfr6NFL/beXsnngr9EbhbIPVlqMjgF4vvZtQeBUxwXT905E WD348zjUFx9yHHI4LiQX9rnca8uovNITjCKMJX8opnbydgjUhCP8SNZyNhRdBj3el7bv CqYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca7si1191269ejb.319.2019.09.24.09.49.56; Tue, 24 Sep 2019 09:50:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436661AbfIWHUo (ORCPT + 99 others); Mon, 23 Sep 2019 03:20:44 -0400 Received: from retiisi.org.uk ([95.216.213.190]:49834 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436537AbfIWHUo (ORCPT ); Mon, 23 Sep 2019 03:20:44 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 02DA5634C87; Mon, 23 Sep 2019 10:19:42 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1iCIdK-00029L-S1; Mon, 23 Sep 2019 10:19:42 +0300 Date: Mon, 23 Sep 2019 10:19:42 +0300 From: Sakari Ailus To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.3 084/203] media: omap3isp: Don't set streaming state on random subdevs Message-ID: <20190923071942.GJ5525@valkosipuli.retiisi.org.uk> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-84-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190922184350.30563-84-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sasha, On Sun, Sep 22, 2019 at 02:41:50PM -0400, Sasha Levin wrote: > From: Sakari Ailus > > [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] > > The streaming state should be set to the first upstream sub-device only, > not everywhere, for a sub-device driver itself knows how to best control > the streaming state of its own upstream sub-devices. > > Signed-off-by: Sakari Ailus > Reviewed-by: Laurent Pinchart > Signed-off-by: Mauro Carvalho Chehab > Signed-off-by: Sasha Levin I don't disagree with this going to the stable trees as well, but in that case it *must* be accompanied by commit e9eb103f0277 ("media: omap3isp: Set device on omap3isp subdevs") or the driver will mostly cease to work. Could you pick that up as well? Thanks. -- Kind regards, Sakari Ailus