Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190907090534.GB1712@pc-sasha.localdomain> <20190920194450.GA3970@pc-sasha.localdomain>
 <CAKMK7uECOW2YigBe7aeCDPYXoXJ8TVh65xvKBjJXXRt5Y7HngA@mail.gmail.com> <20190923063803.c7zpqwcqq5f2acq5@sirius.home.kraxel.org>
In-Reply-To: <20190923063803.c7zpqwcqq5f2acq5@sirius.home.kraxel.org>
From:   Alexander Kapshuk <alexander.kapshuk@gmail.com>
Date:   Mon, 23 Sep 2019 09:50:41 +0300
Message-ID: <CAJ1xhMV2ikra9udRhhLLntLxZKO23jLkU=9AeP=denALhw8r_w@mail.gmail.com>
Subject: Re: Kernel panic during drm/nouveau init 5.3.0-rc7-next-20190903
To:     Gerd Hoffmann <kraxel@redhat.com>
Cc:     Daniel Vetter <daniel@ffwll.ch>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-next <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Sean Paul <sean@poorly.run>, Dave Airlie <airlied@linux.ie>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 23, 2019 at 9:38 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> > > 'Git bisect' has identified the following commits as being 'bad'.
> > >
> > > b96f3e7c8069b749a40ca3a33c97835d57dd45d2 is the first bad commit
> > > commit b96f3e7c8069b749a40ca3a33c97835d57dd45d2
> > > Author: Gerd Hoffmann <kraxel@redhat.com>
> > > Date:   Mon Aug 5 16:01:10 2019 +0200
> > >
> > >     drm/ttm: use gem vma_node
> > >
> > >     Drop vma_node from ttm_buffer_object, use the gem struct
> > >     (base.vma_node) instead.
> > >
> > >     Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > >     Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
> > >     Link: http://patchwork.freedesktop.org/patch/msgid/20190805140119=
.7337-9-kraxel@redhat.com
>
> > > Today, I upgraded the kernel to 5.3.0-next-20190919, which booted fin=
e
> > > with no Xorg regressions to report.
> > >
> > > Just wondering if the earlier kernels would not boot for me because o=
f
> > > the changes introduced by the 'bad' commits being perhaps incomplete?
>
> Yes, we had a regression in nouveau, fixed by this patch (in drm-misc-nex=
t):
>
> commit 019cbd4a4feb3aa3a917d78e7110e3011bbff6d5
> Author: Thierry Reding <treding@nvidia.com>
> Date:   Wed Aug 14 11:00:48 2019 +0200
>
>     drm/nouveau: Initialize GEM object before TTM object
>
>     TTM assumes that drivers initialize the embedded GEM object before
>     calling the ttm_bo_init() function. This is not currently the case
>     in the Nouveau driver. Fix this by splitting up nouveau_bo_new()
>     into nouveau_bo_alloc() and nouveau_bo_init() so that the GEM can
>     be initialized before TTM BO initialization when necessary.
>
>     Fixes: b96f3e7c8069 ("drm/ttm: use gem vma_node")
>     Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>     Acked-by: Ben Skeggs <bskeggs@redhat.com>
>     Signed-off-by: Thierry Reding <treding@nvidia.com>
>     Link: https://patchwork.freedesktop.org/patch/msgid/20190814093524.GA=
31345@ulmo
>
> HTH,
>   Gerd
>

Terrific.
Thanks for the info.