Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp42611ybn; Tue, 24 Sep 2019 17:54:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhDC+gKmlZQefO4q98Kt7OJCitfzL1gKmXLrBw5cEi33qaLMzEdpT7CFg9GExtrV49EGah X-Received: by 2002:a1c:d185:: with SMTP id i127mr3809322wmg.28.1569372858642; Tue, 24 Sep 2019 17:54:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569372858; cv=none; d=google.com; s=arc-20160816; b=0gb4xKE4ft4AVEqN4gvuQT7rzDgJC+Vebeniaf7z2dkJvaUEFTcXHvOBbxzhsIV9uO HwE27jGfE9/mj2EVdgNVfPtREmrtUECkAWRL9A29ahgb6RfEo9g9Ft+Gip5VLDEk90BH pqZ+iQOZuhcjKCA988jvIo4HLzd+2xcl8JW4EKQ/6zhAaz86AoRLVpvrMVlvig62oWbT HjhdI+TJA6b2z72eLJjcaFqXjH14oFWRbA96H67h4h2OvzKHGNkvqXTKGeggxob6Mvv8 iXO8JeqZUtUU3+TvkyUZ276fjJkwYeOny1LRqZd/rUnARViAJiYsEQuWIyU7/QRARK8Z I9xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O4VcN0d4IEyXb1Mpafssk3m4oofIQQWS+rju5RxEMJg=; b=wsphxtSXSYgok5JNWxhaVAfxK4vaiJ2+HjXRNEDGwLyUkUAsHA+hk2sfmdgCnYWIxC vDn50CTPHNAcvC8IzB6zMFFYycPWMmfSB9wK5NmOQ+w3HIZgeoZ8ujNKA7Kem0qQzjU0 Nh7RgPlxWBaX3uRd9bYwq5cpS1fwL1+D0ROJUkRiu2wHM3jeivE0zJqLqHfKRJxTLqw6 aPcD05rRcgI6qOvH3IBY+NlBPBHAKDfb5Ht29dPtgkr3dIPj78jAz8hdOjvH6Z0l+qAb pR5D8981iJfPB3MziCp97r3x+Ko+8QJN+sFGnOLmTvZcv2b1S04gcixy0j+VqPoMPHxC 7+Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gkQuUuMN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w20si2313243edc.202.2019.09.24.17.53.26; Tue, 24 Sep 2019 17:54:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gkQuUuMN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389507AbfIVTiO (ORCPT + 99 others); Sun, 22 Sep 2019 15:38:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:41286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389363AbfIVSpg (ORCPT ); Sun, 22 Sep 2019 14:45:36 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFB74214D9; Sun, 22 Sep 2019 18:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177935; bh=Efrs07DtXo6dlB5edLomXEd/SCJQyQCva1c9N4iPxMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gkQuUuMNptp2VFpmhg8HmwIYCRZNdRXd09KG7TgNPu8m4bRkNlZHfathxdWK5HGLN 4wjF8d+udq29p2YIBRoXAqhtAgV2maPeBiyq/CZd1dmZoHY0Q8usvzpeRu+hI5bMf7 jIr+ajiKGdGGQupoezCyo7CwTO82gK0dOKz9wcuM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ard van Breemen , Takashi Iwai , Sasha Levin Subject: [PATCH AUTOSEL 5.3 045/203] ALSA: usb-audio: Skip bSynchAddress endpoint check if it is invalid Date: Sun, 22 Sep 2019 14:41:11 -0400 Message-Id: <20190922184350.30563-45-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard van Breemen [ Upstream commit 1b34121d9f26d272b0b2334209af6b6fc82d4bf1 ] The Linux kernel assumes that get_endpoint(alts,0) and get_endpoint(alts,1) are eachothers feedback endpoints. To reassure that validity it will test bsynchaddress to comply with that assumption. But if the bsyncaddress is 0 (invalid), it will flag that as a wrong assumption and return an error. Fix: Skip the test if bSynchAddress is 0. Note: those with a valid bSynchAddress should have a code quirck added. Signed-off-by: Ard van Breemen Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index e4bbf79de956e..33cd26763c0ee 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -457,6 +457,7 @@ static int set_sync_endpoint(struct snd_usb_substream *subs, } ep = get_endpoint(alts, 1)->bEndpointAddress; if (get_endpoint(alts, 0)->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE && + get_endpoint(alts, 0)->bSynchAddress != 0 && ((is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress | USB_DIR_IN)) || (!is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress & ~USB_DIR_IN)))) { dev_err(&dev->dev, -- 2.20.1