Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp43438ybn; Tue, 24 Sep 2019 17:55:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYMuqs+shXlNxdi+J7DmcI2vkEQTB/BCnmkhyFvT8mPHyXfmqBVYr0XnwnHi089IokU8/g X-Received: by 2002:a7b:c935:: with SMTP id h21mr3667693wml.97.1569372923378; Tue, 24 Sep 2019 17:55:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569372923; cv=none; d=google.com; s=arc-20160816; b=EBUFm1VV45JDDPZ/kALheIpysKXlxyDAsTC1Ypoep+x/K9EPHSezdyrj2i+K6pdTym U9bJscNKlpc5Q1KrV89OM6P/veDqIcVbdT6Kcji1YrbDP7KvQxcAlg2SP6lSUQGz28jH +d+sG9GYlbmBixuX6+wTu4b8ThkvNNT5uwefOVgP2jjocBg4PoGtxGCWsNsGp46+c3fL Kl/DW2oF1O+V0oJpndMpa7iPgKa9o54F4Fyv90BkUqXtYnQ7b2sAttxUlwjvdOzPwjdz I9S1n+VgC8hbc6/6+sbj0dmVZuenUz/I34S8gyiPcj8Mo+vlX22hQD0T5air43rmhjek D3Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VtNAaTxGm0SaZRu3gMNaE9xaL7WTiaY1hkBLQhDFckg=; b=Pgm+B7wPTZydcyhgbQSjr5Y2bPhJsGvZ9rV4lHMbB41l8js7z43RiA6bQzbpOZyzm0 Z6DZf5gZgBZhcZBI8U7/3F3Y8oiCCT7pVs/1hUu3swUXGdR29sTxP/80ZeTVikeDsHVX 5b6goEehPpFnqg0YAw9UZXtfatZP8yypth5AZtlt8/Ef8DcYkDXA8K7KdA+XBqqT3kNr DWvxb69N0ehg2mrw/ODP07uHajX4rvdjinaEz+iBUAI4Z3cryDuzVXAHiKwHHxa8q+tx LVBd509V3GTcSKCnT9WHc2Lleat4oibJWZdJKeZfM9cLxojOnUudeOGdkV9L6+4mtVx6 Fr0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ii0moMhr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q46si2226595eda.44.2019.09.24.17.54.58; Tue, 24 Sep 2019 17:55:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ii0moMhr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439328AbfIVTj0 (ORCPT + 99 others); Sun, 22 Sep 2019 15:39:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:39600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388616AbfIVSn6 (ORCPT ); Sun, 22 Sep 2019 14:43:58 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 621C8214D9; Sun, 22 Sep 2019 18:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569177838; bh=Ln47ydx473W+6KQNzCPk61eWAr9+pKosg4/WQNSro/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ii0moMhrug07139OND8kC4wBVUCaggoSVyG7O3Y1sBLAPaCZG0Nf3FhvFKj2YyaQy 34Ui//CFcZWXghHRc+JYspGOMwdc7RM8NYZNrQnXS+5REZNZFyD0+/dr2DH8YWaHCD 8XeDumDORq8FGfomOoT4UvCC+PCodwaRHxnnJ9nw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 5.3 006/203] regulator: lm363x: Fix n_voltages setting for lm36274 Date: Sun, 22 Sep 2019 14:40:32 -0400 Message-Id: <20190922184350.30563-6-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184350.30563-1-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 962f170d9344e5d9edb3903971c591f42d55e226 ] According to the datasheet http://www.ti.com/lit/ds/symlink/lm36274.pdf: Table 23. VPOS Bias Register Field Descriptions VPOS[5:0]: VPOS voltage (50-mV steps): VPOS = 4 V + (Code × 50 mV), 6.5 V max 000000 = 4 V 000001 = 4.05 V : 011110 = 5.5 V (Default) : 110010 = 6.5 V 110011 to 111111 map to 6.5 V So the LM36274_LDO_VSEL_MAX should be 0b110010 (0x32). The valid selectors are 0 ... LM36274_LDO_VSEL_MAX, n_voltages should be LM36274_LDO_VSEL_MAX + 1. Similarly, the n_voltages should be LM36274_BOOST_VSEL_MAX + 1 for LM36274_BOOST. Fixes: bff5e8071533 ("regulator: lm363x: Add support for LM36274") Signed-off-by: Axel Lin Link: https://lore.kernel.org/r/20190626132632.32629-2-axel.lin@ingics.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/lm363x-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c index e4a27d63bf901..4b9f618b07e97 100644 --- a/drivers/regulator/lm363x-regulator.c +++ b/drivers/regulator/lm363x-regulator.c @@ -36,7 +36,7 @@ /* LM36274 */ #define LM36274_BOOST_VSEL_MAX 0x3f -#define LM36274_LDO_VSEL_MAX 0x34 +#define LM36274_LDO_VSEL_MAX 0x32 #define LM36274_VOLTAGE_MIN 4000000 /* Common */ @@ -226,7 +226,7 @@ static const struct regulator_desc lm363x_regulator_desc[] = { .of_match = "vboost", .id = LM36274_BOOST, .ops = &lm363x_boost_voltage_table_ops, - .n_voltages = LM36274_BOOST_VSEL_MAX, + .n_voltages = LM36274_BOOST_VSEL_MAX + 1, .min_uV = LM36274_VOLTAGE_MIN, .uV_step = LM363X_STEP_50mV, .type = REGULATOR_VOLTAGE, @@ -239,7 +239,7 @@ static const struct regulator_desc lm363x_regulator_desc[] = { .of_match = "vpos", .id = LM36274_LDO_POS, .ops = &lm363x_regulator_voltage_table_ops, - .n_voltages = LM36274_LDO_VSEL_MAX, + .n_voltages = LM36274_LDO_VSEL_MAX + 1, .min_uV = LM36274_VOLTAGE_MIN, .uV_step = LM363X_STEP_50mV, .type = REGULATOR_VOLTAGE, @@ -254,7 +254,7 @@ static const struct regulator_desc lm363x_regulator_desc[] = { .of_match = "vneg", .id = LM36274_LDO_NEG, .ops = &lm363x_regulator_voltage_table_ops, - .n_voltages = LM36274_LDO_VSEL_MAX, + .n_voltages = LM36274_LDO_VSEL_MAX + 1, .min_uV = LM36274_VOLTAGE_MIN, .uV_step = LM363X_STEP_50mV, .type = REGULATOR_VOLTAGE, -- 2.20.1