Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Xin Ji <xji@analogixsemi.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Sheng Pan <span@analogixsemi.com>
Subject: Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP
 transmitter binding
Thread-Topic: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP
 transmitter binding
Thread-Index: AQHVb3j75RwTQ/LQlEe1c7kQ788vf6c0UZKAgARVAoA=
Date:   Mon, 23 Sep 2019 03:55:48 +0000
Message-ID: <20190923035539.GA5916@xin-VirtualBox>
References: <cover.1568957788.git.xji@analogixsemi.com>
 <606dba07640f0c9aba930e1dfb5d6a797f393ecc.1568957789.git.xji@analogixsemi.com>
 <20190920094621.GA12950@pendragon.ideasonboard.com>
In-Reply-To: <20190920094621.GA12950@pendragon.ideasonboard.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [222.35.23.38]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 31f2ea73-14f9-49ad-658b-08d73fd9eb1a
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR04MB6685;
x-ms-traffictypediagnostic: MN2PR04MB6685:
x-ms-exchange-purlcount: 3
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR04MB668570FE1C86BDEF2A3C3320C7850@MN2PR04MB6685.namprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0169092318
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(346002)(366004)(136003)(396003)(376002)(39840400004)(189003)(199004)(2906002)(3846002)(6116002)(66066001)(33716001)(25786009)(54906003)(1076003)(316002)(33656002)(4326008)(6306002)(14444005)(256004)(6916009)(305945005)(6512007)(9686003)(86362001)(107886003)(6246003)(229853002)(6436002)(486006)(99286004)(6486002)(7736002)(7416002)(14454004)(476003)(966005)(386003)(6506007)(5660300002)(52116002)(76176011)(71190400001)(71200400001)(26005)(186003)(102836004)(446003)(64756008)(66446008)(66946007)(11346002)(478600001)(8936002)(81166006)(66476007)(66556008)(81156014)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR04MB6685;H:MN2PR04MB5886.namprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: analogixsemi.com does not
 designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 30JRXtlTVAQ1I9K8EwJpLQ+13TuR/YtQztmHxF41Zmf6E/sNZMmtnckyv6tfybeNw+zJAiSivHCL5gFwMxE7sMzwYLeWN2Khes3/yjWcbKnl+TIMBpqMrDNvUl4OjBFciwAVVDeD986GC1I+/0dzAlLsAB72PGIaTQGO01+FZ6eAobGTs6uwTFY5l43HDlDlusX7j0o50Erfr430diRYn5kc+CZjhyq9Ak87RNV1esVzy7j9gff95/uYe+2JPsvATD3pDciWE0/iIjfmbsO+Y3C5VKq9U5yPOKHi9LJJn1cXr5vB2ClZ+ZAVQ+KTSvH/oHAz8Z1BPNaWYTZkU96CLDJv1kIYjiBXpQoRYFNxZtC1/cZNdY44ifFGUt2thL8ZYr9P3hwv1n8kwpAqjDj7wiXYEcLJcsxP1D8M6BUSFwE=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89EF8D1BB3962448B6334707B56223DD@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31f2ea73-14f9-49ad-658b-08d73fd9eb1a
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2019 03:55:48.7909
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1rBaGtbvau8EEnF/+S7kZX3fbnrwSHD0BK+LPME0OSjpT7X1z9xJ5A+JK6gAF6iAyM2MKiHKzKJkt3FjY6XpCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6685
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent Pinchart, thanks for your comment.

On Fri, Sep 20, 2019 at 12:46:21PM +0300, Laurent Pinchart wrote:
> Hello Xin Ji,
>=20
> Thank you for the patch.
>=20
> On Fri, Sep 20, 2019 at 06:05:03AM +0000, Xin Ji wrote:
> > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> > for portable device. It converts MIPI to DisplayPort 1.3 4K.
>=20
> I assume you meant MIPI DSI ? MIPI has released more standards than DSI,
> so it doesn't hurt to specify this explicitly.
It support DSI and DPI, I will to point out.
>=20
> According to
> https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBr=
ief_0.pdf,
> the ANX7625 supports for MIPI DSI and DPI on the input side.
> Furthermore, it seems to output DisplayPort on USB Type-C. Should this
> be documented ?
It can support both eDP output or USB Type-C output.
>=20
> > You can add support to your board with binding.
> >=20
> > Example:
> > 	anx_bridge: anx7625@58 {
> > 		compatible =3D "analogix,anx7625";
> > 		reg =3D <0x58>;
> > 		low-power-mode =3D <1>;
> > 		dsi-supported =3D <1>;
> > 		dsi-channel-id =3D <1>;
> > 		dsi-lanes-num =3D <4>;
> > 		internal-pannel-supported =3D <1>;
> > 		pon-gpios =3D <&gpio0 45 GPIO_ACTIVE_LOW>;
> > 		reset-gpios =3D <&gpio0 73 GPIO_ACTIVE_LOW>;
> > 		status =3D "okay";
> > 		port {
> > 			anx7625_1_in: endpoint {
> > 				remote-endpoint =3D <&mipi_dsi_bridge_1>;
> > 			};
> > 		};
> > 	};
> >=20
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  .../bindings/display/bridge/anx7625.yaml           | 84 ++++++++++++++=
++++++++
> >  1 file changed, 84 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/an=
x7625.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.y=
aml b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml
> > new file mode 100644
> > index 0000000..95fe18b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml
> > @@ -0,0 +1,84 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2019 Analogix Semiconductor, Inc.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> > +
> > +maintainers:
> > +  - Xin Ji <xji@analogixsemi.com>
> > +
> > +description: |
> > +  The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> > +  designed for portable devices.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - const: analogix,anx7625
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  low-power-gpios:
> > +    description: Low power mode support feature
> > +    maxItems: 1
> > +
> > +  hpd-gpios:
> > +    description: used for HPD interrupt
> > +    maxItems: 1
> > +
> > +  pon-gpios:
> > +    description: used for power on chip control
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    description: used for reset chip control
> > +    maxItems: 1
>=20
> How about mentioning which pin of the ANX7625 each GPIO refers to ? For
> the low-power, pon and reset GPIOs I assume they directly control the
> chip. We have standard names for some GPIOs, such as reset or enable. Is
> there one of the low-power and pon GPIOs that would qualify as an enable
> signal ?
OK, I think pon-gpios can qualify as an enable.
>=20
> What is the HPD GPIO for ? Does the chip output and HPD signal ?
Once the anx7625 received eDP HPD signal, the firmware will report HPD
interrupt to AP through defined gpio interrupt pin "hpd-gpios". It used
for interrupt between anx7625 and AP, not used for output.
>=20
> > +
> > +  extcon-supported:
> > +    description: external connector interface support flag
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  internal-pannel-supported:
> > +    description: indicate does internal pannel exist or not
> > +    $ref: /schemas/types.yaml#/definitions/uint32
>=20
> s/pannel/panel/
OK, will fix it.
>=20
> Are those two properties mutually exclusive ? If so you should combine
> them in a single required property with two values. My feeling is that
> they should be dropped though, please see below.
Yes, they are mutually exclusive.
There are 3 case, one is support google "external connector" framework,
one support internal panel, the other is support normal eDP output, so I
defined two flags to distinguish them here. Based on your comment below,
I'll define output port to distinguish them.
>=20
> > +
> > +  dsi-supported:
> > +    description: support MIPI DSI or DPI
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  dsi-channel-id:
> > +    description: dsi channel index
> > +    $ref: /schemas/types.yaml#/definitions/uint32
>=20
> This does not belong to DT, the virtual channel used by the DSI source
> should be queried at runtime by communicating between drivers.
I didn't know where can quiry this value. Can you give me more detail?
>=20
> > +
> > +  dsi-lanes-num:
> > +    description: dsi lanes used num
> > +    $ref: /schemas/types.yaml#/definitions/uint32
>=20
> Please use the standard data-lanes property as defined in
> video-interface.txt. It should be specified in the DSI endpoints.
OK, I'll fetch the dsi lanes from DSI endpoints.
>=20
> > +
> > +  port@0:
> > +    type: object
> > +    description:
> > +      A port node pointing to MIPI DSI host port node.
>=20
> You need at least 3 ports:
>=20
> - a DPI input port
I'll add DPI input port.
> - a DSI input port
> - an output port
>=20
> The dsi-supported property should be dropped, detecting the type of
> input should be done based on which of the DPI or DSI input port is
> connected.
OK.
>=20
> Assuming the ANX7625 can also output DisplayPort directly without going
> through USB Type-C (I can't verify that without the datasheet), I think
> you should use two output ports, one for USB Type-C and one for
> DisplayPort. The extcon-supported and internal-pannel-supported
> properties should be removed, and deduced from the connect output port.
I think there should exist 3 output port, one is for extern connector,
one is for normal eDP, other is for internal panel eDP.
>=20
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - dsi-channel-id
> > +  - dsi-lanes-num
> > +  - port@0
> > +
> > +example:
> > +  - |
> > +    anx_bridge: anx7625@58 {
> > +        compatible =3D "analogix,anx7625";
> > +        reg =3D <0x58>;
> > +        low-power-gpios =3D <0>;
> > +        dsi-supported =3D <1>;
> > +        dsi-channel-id =3D <1>;
> > +        dsi-lanes-num =3D <4>;
> > +        hpd-gpios =3D <&gpio1 19 IRQ_TYPE_LEVEL_LOW>;
> > +        status =3D "okay";
> > +    };
>=20
> You mention the port@0 node as being required, but it's missing from the
> example.
OK, I'll change it in the next series.
>=20
> --=20
> Regards,
>=20
> Laurent Pinchart