Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 23 Sep 2019 11:31:22 +0530
From:   "Milan P. Gandhi" <mgandhi@redhat.com>
To:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com
Subject: [PATCH] scsi: core: Log SCSI command age with errors
Message-ID: <20190923060122.GA9603@machine1>
MIME-Version: 1.0
User-Agent: Mutt/1.11.3 (2019-02-01)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Couple of users had requested to print the SCSI command age along=20
with command failure errors. This is a small change, but allows=20
users to get more important information about the command that was=20
failed, it would help the users in debugging the command failures:

Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c
index ecc5918e372a..ca2182bc53c6 100644
--- a/drivers/scsi/scsi_logging.c
+++ b/drivers/scsi/scsi_logging.c
@@ -437,6 +437,7 @@ void scsi_print_result(const struct scsi_cmnd *cmd, con=
st char *msg,
 =09const char *mlret_string =3D scsi_mlreturn_string(disposition);
 =09const char *hb_string =3D scsi_hostbyte_string(cmd->result);
 =09const char *db_string =3D scsi_driverbyte_string(cmd->result);
+=09unsigned long cmd_age =3D (jiffies - cmd->jiffies_at_alloc) / HZ;
=20
 =09logbuf =3D scsi_log_reserve_buffer(&logbuf_len);
 =09if (!logbuf)
@@ -478,10 +479,15 @@ void scsi_print_result(const struct scsi_cmnd *cmd, c=
onst char *msg,
=20
 =09if (db_string)
 =09=09off +=3D scnprintf(logbuf + off, logbuf_len - off,
-=09=09=09=09 "driverbyte=3D%s", db_string);
+=09=09=09=09 "driverbyte=3D%s ", db_string);
 =09else
 =09=09off +=3D scnprintf(logbuf + off, logbuf_len - off,
-=09=09=09=09 "driverbyte=3D0x%02x", driver_byte(cmd->result));
+=09=09=09=09 "driverbyte=3D0x%02x ",
+=09=09=09=09 driver_byte(cmd->result));
+
+=09off +=3D scnprintf(logbuf + off, logbuf_len - off,
+=09=09=09 "cmd-age=3D%lus", cmd_age);
+
 out_printk:
 =09dev_printk(KERN_INFO, &cmd->device->sdev_gendev, "%s", logbuf);
 =09scsi_log_release_buffer(logbuf);