Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Markus Elfring <Markus.Elfring@web.de>
CC:     "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        James Morse <james.morse@arm.com>,
        =?iso-8859-1?Q?Jan_L=FCbbe?= <jlu@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] EDAC: Armada XP: Use devm_platform_ioremap_resource() in
 two functions
Thread-Topic: [PATCH] EDAC: Armada XP: Use devm_platform_ioremap_resource() in
 two functions
Thread-Index: AQHVceZ/qmVc1mF5QEOLvvk2Um9yGg==
Date:   Mon, 23 Sep 2019 08:11:27 +0000
Message-ID: <20190923081117.4p4mwqz35fzavkeg@rric.localdomain>
References: <3cf2076e-6394-4997-613d-cbf5b6dbee1e@web.de>
In-Reply-To: <3cf2076e-6394-4997-613d-cbf5b6dbee1e@web.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f78f7ebb-ab38-424a-fec6-08d73ffda1ee
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:DM6PR18MB2474;
x-ms-traffictypediagnostic: DM6PR18MB2474:
x-microsoft-antispam-prvs: <DM6PR18MB2474EC9900B7610FD84B3E4FD9850@DM6PR18MB2474.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0169092318
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(346002)(39850400004)(396003)(376002)(366004)(189003)(199004)(2906002)(99286004)(186003)(64756008)(66446008)(53546011)(6506007)(1076003)(14454004)(76176011)(26005)(66476007)(66556008)(66946007)(86362001)(229853002)(4326008)(6246003)(52116002)(386003)(102836004)(478600001)(6436002)(6116002)(3846002)(25786009)(8676002)(81156014)(81166006)(8936002)(9686003)(6512007)(305945005)(7736002)(256004)(446003)(11346002)(6916009)(66066001)(6486002)(71200400001)(486006)(5660300002)(476003)(71190400001)(54906003)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR18MB2474;H:DM6PR18MB3403.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: V1wKxiEt1vr33VBO2/FarE/O83MevGNOaNoFQ78qeCoMCGSbhm2/4179mIOUqkXYvqFZXjaMjiSEJb3t7xpjwGZD7PuB326LW4vBEr0DJsnRB8qfkKGnTwwztEEdTs2DIcPhohWNd6RrqOiR2ILYCPiLr0s56se33BqZONIGgQqJvVm4SxBZPfaaHTZ5jq1ifjunphruIdtttmnnBgBXzn40h+eMsjUweYewS54wLldvOgqzHCMD6tIuQyHLUYi6BRT6sonnd9DaaaMIgRJC7Xm0i4AhOdXYDG74oeSLwPtoQwQgKGT89ylxYWiARqHz2Wnz5NzNiGeQFfHjsWMRw9RjlpGK33VvhY73MCLR4khuyglJ80sXPdEfnZWuKHza3v4Oiy/e2mDG9wUCeEgVKv7V/8lEGK4h1v7o4fSwgE4=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <274FD53589159A488D36422E47CC29B8@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f78f7ebb-ab38-424a-fec6-08d73ffda1ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2019 08:11:27.8231
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ovy2XyxA+v7i0kO4n4+6abvCcRVvqN4V9XrrbHsTgHChIMPyS1SkjT2Swl0Wfr2A6ag7IhGA5bIwL5TQHRQvNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2474
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-23_03:2019-09-23,2019-09-23 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Markus,

On 21.09.19 17:57:24, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 21 Sep 2019 17:50:17 +0200
>=20
> Simplify these function implementations by using a known function.
>=20
> This issue was detected by using the Coccinelle software.

Which semantic patch did you use here?

The kernel's spatch for this pattern only found and fixed the
following:

 $ make coccicheck COCCI=3Dscripts/coccinelle/api/devm_platform_ioremap_res=
ource.cocci MODE=3Dpatch M=3Ddrivers/edac | patch -p1
 patching file drivers/edac/ti_edac.c
 patching file drivers/edac/xgene_edac.c
 patching file drivers/edac/synopsys_edac.c

There are probably more drivers to fix than the above and the one you
fixed:

 $ git grep -l platform_get_resource drivers/edac/
 drivers/edac/altera_edac.c
 drivers/edac/armada_xp_edac.c
 drivers/edac/aspeed_edac.c
 drivers/edac/bluefield_edac.c
 drivers/edac/cpc925_edac.c
 drivers/edac/highbank_l2_edac.c
 drivers/edac/highbank_mc_edac.c
 drivers/edac/mv64x60_edac.c
 drivers/edac/synopsys_edac.c
 drivers/edac/ti_edac.c
 drivers/edac/xgene_edac.c

So while at it, how about fixing the .cocci patch in scripts/ and run
it for drivers/edac? There should be one patch only for all edac
drivers.

Thanks,

-Robert