Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: SoftFail (protection.outlook.com: domain of transitioning
 cadence.com discourages use of 199.43.4.28 as permitted sender)
X-CrossPremisesHeadersFilteredBySendConnector: mailsj6.global.cadence.com
Received: from global.cadence.com (158.140.32.37) by
 mailsj6.global.cadence.com (158.140.32.112) with Microsoft SMTP Server (TLS)
 id 15.0.1367.3; Mon, 23 Sep 2019 05:13:46 -0700
Date:   Mon, 23 Sep 2019 13:13:39 +0100
From:   Piotr Sroka <piotrs@cadence.com>
To:     Schrempf Frieder <frieder.schrempf@kontron.de>
CC:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] - change calculating of position page containing BBM
Message-ID: <20190923121337.GA15230@global.cadence.com>
References: <20190919124139.10856-1-piotrs@cadence.com>
 <20190919145819.66e74aef@xps13>
 <f03d93a5-4393-2405-b597-80b762059f01@kontron.de>
 <20190919151820.2bb8313d@xps13>
 <7a9675e4-8bcc-f822-6028-f78d0d12c3bf@kontron.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7a9675e4-8bcc-f822-6028-f78d0d12c3bf@kontron.de>
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Originating-IP: [158.140.32.37]
X-ClientProxiedBy: mailsj7.global.cadence.com (158.140.32.114) To
 mailsj6.global.cadence.com (158.140.32.112)
X-OrganizationHeadersPreserved: mailsj6.global.cadence.com
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:199.43.4.28;IPV:CAL;SCL:-1;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(136003)(39860400002)(376002)(396003)(346002)(36092001)(189003)(199004)(54094003)(1076003)(6916009)(33656002)(66574012)(336012)(5660300002)(53546011)(386003)(16526019)(26005)(186003)(7696005)(2486003)(23676004)(446003)(11346002)(476003)(76176011)(53416004)(956004)(7416002)(426003)(81166006)(305945005)(81156014)(4326008)(7736002)(6246003)(70586007)(70206006)(2906002)(6286002)(8676002)(6116002)(3846002)(14444005)(26826003)(8936002)(55016002)(50466002)(6666004)(356004)(229853002)(2870700001)(478600001)(86362001)(486006)(66066001)(58126008)(316002)(126002)(76130400001)(47776003)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR07MB6844;H:rmmaillnx1.cadence.com;FPR:;SPF:SoftFail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1;
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9127f97c-a3f4-4c81-f504-08d7401f824f
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR07MB6844;
X-MS-TrafficTypeDiagnostic: DM6PR07MB6844:
X-Microsoft-Antispam-PRVS: <DM6PR07MB6844056AF27D471146E33A63DD850@DM6PR07MB6844.namprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-Forefront-PRVS: 0169092318
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info: iQavoL+ESTE/CSyIS0H0rD+Z5bXyE6R0Q65mNea3/GlEYwv9swTLfbjrNC6TJPGF/PySizGLnb9J3Sl6cboIDBMyFOScjYf/6RIBGsx/hAgoYwX6yVUEzAyn1GONUGvdeTGU7PomtmXax0PctBtR2bU2P2IVKZ1TuJ4vtPLAs7WpcI85bJtcceRqMY8Y2aGwW0ZHNHiRSXD6t8hXJxUuB9q2K49TI4VQz8VE378q3HXEnvAVVSSqE2TRZ/3K1k6xCgwWMnImqYE/vEBvpczQ4WtccvYS5B4mEYM9KztWQUaIPVwY6EXig7GRPw9Bmgvj0eek4ffgBoS7LniLkS/V99fw4zZu9cMJY3efTE6YzplHqfnfILSH0aNHSZttrbI/cp7Zl8mfFlrJePi+XSIXYp+s8DinJzIMu5543w9+Mes=
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2019 12:13:56.9045
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9127f97c-a3f4-4c81-f504-08d7401f824f
X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9;Ip=[199.43.4.28];Helo=[rmmaillnx1.cadence.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB6844
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-23_04:2019-09-23,2019-09-23 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0
 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0
 impostorscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-1908290000
 definitions=main-1909230123
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello

The 09/19/2019 13:33, Schrempf Frieder wrote:
>EXTERNAL MAIL
>
>
>On 19.09.19 15:18, Miquel Raynal wrote:
>> Hello,
>>
>> Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Thu, 19 Sep
>> 2019 13:15:08 +0000:
>>
>>> On 19.09.19 14:58, Miquel Raynal wrote:
>>>> Hi Piotr,
>>>>
>>>> Piotr Sroka <piotrs@cadence.com> wrote on Thu, 19 Sep 2019 13:41:35
>>>> +0100:
>>>>
>>>>> Change calculating of position page containing BBM
>>>>>
>>>>> If none of BBM flags is set then function nand_bbm_get_next_page
>>>>> reports EINVAL. It causes that BBM is not read at all during scanning
>>>>> factory bad blocks. The result is that the BBT table is build without
>>>>> checking factory BBM at all. For Micron flash memories none of this
>>>>> flag is set if page size is different than 2048 bytes.
>>>
>>> I wonder if it wouldn't be better to fix the Micron driver instead:
>>>
>>> --- a/drivers/mtd/nand/raw/nand_micron.c
>>> +++ b/drivers/mtd/nand/raw/nand_micron.c
>>> @@ -448,6 +448,8 @@ static int micron_nand_init(struct nand_chip *chip)
>>>
>>>           if (mtd->writesize == 2048)
>>>                   chip->options |= NAND_BBM_FIRSTPAGE |
>>>                                    NAND_BBM_SECONDPAGE;
>>> +       else
>>> +               chip->options |= NAND_BBM_FIRSTPAGE;
>>
>> That's what I forgot in my last answer to this thread, I think I only
>> told Piotr privately: I would like both. I think it is important to fix
>> the bbm_get_next_page function but for clarity, setting the FIRSTPAGE
>> flag in Micron's driver seems also pertinent.
>
>Indeed, that sounds reasonable. Piotr, can you send another patch with
>the diff above? And by the way: thanks for fixing my code ;)
>
>Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>
Thanks Frieder and Miquel for the very quick reply. I will send next
version containing Micron driver fix.

>>
>>>
>>>           ondie = micron_supports_on_die_ecc(chip);
>>>
>>>
>>>>
>>>> "none of these flags are set"
>>>>
>>>>>
>>>>> This patch changes the nand_bbm_get_next_page function.
>>>>
>>>> "Address this regression by changing the
>>>> nand_bbm_get_next_page_function."
>>>>
>>>>> It will return 0 if none of BBM flag is set and page parameter is 0.
>>>>
>>>>                         no BBM flag is set
>>>>
>>>>> After that modification way of discovering factory bad blocks will work
>>>>> similar as in kernel version 5.1.
>>>>>
>>>>
>>>> Fixes + stable tags would be great!
Ok I will add fixes tag and "Cc: <stable@vger.kernel.org>". 

>>>>
>>>>> Signed-off-by: Piotr Sroka <piotrs@cadence.com>
>>>>> ---
>>>>>    drivers/mtd/nand/raw/nand_base.c | 8 ++++++--
>>>>>    1 file changed, 6 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
>>>>> index 5c2c30a7dffa..f64e3b6605c6 100644
>>>>> --- a/drivers/mtd/nand/raw/nand_base.c
>>>>> +++ b/drivers/mtd/nand/raw/nand_base.c
>>>>> @@ -292,12 +292,16 @@ int nand_bbm_get_next_page(struct nand_chip *chip, int page)
>>>>>    	struct mtd_info *mtd = nand_to_mtd(chip);
>>>>>    	int last_page = ((mtd->erasesize - mtd->writesize) >>
>>>>>    			 chip->page_shift) & chip->pagemask;
>>>>> +	unsigned int bbm_flags = NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE
>>>>> +		| NAND_BBM_LASTPAGE;
>>>>>
>>>>> +	if (page == 0 && !(chip->options & bbm_flags))
>>>>> +		return 0;
>>>>>    	if (page == 0 && chip->options & NAND_BBM_FIRSTPAGE)
>>>>>    		return 0;
>>>>> -	else if (page <= 1 && chip->options & NAND_BBM_SECONDPAGE)
>>>>> +	if (page <= 1 && chip->options & NAND_BBM_SECONDPAGE)
>>>>>    		return 1;
>>>>> -	else if (page <= last_page && chip->options & NAND_BBM_LASTPAGE)
>>>>> +	if (page <= last_page && chip->options & NAND_BBM_LASTPAGE)
>>>>>    		return last_page;
>>>>>
>>>>>    	return -EINVAL;
>>>>
>>>> Lookgs good otherwise.
>>>>
>>>> Thanks,
>>>> Miquèl
>>>>
>>
>> Thanks,
>> Miquèl
>>

Thanks,
Piotr