Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp706127ybn; Wed, 25 Sep 2019 06:33:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVCiei8Ca1aDMEx07C4y79PdR0BMQUuCbCsvHo5YhSMchG465HjXiAGTqqcPDDWrs9zyma X-Received: by 2002:a17:906:c5b:: with SMTP id t27mr4011768ejf.180.1569418421866; Wed, 25 Sep 2019 06:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569418421; cv=none; d=google.com; s=arc-20160816; b=uQV3x8VIP8kEVhwjGjhEctdOTJSEpdVoJK88BmAk9lc0t6yPNIxPmhCe+VtJIEKrgd 7v/WhwoUBuFasfX/Vn/8uhl92oCQjk+6P59vrLaIgkmnQveKBUKB39p7/Ai4+XCaG7k3 uhODucxbGjY0SPSOOE0308jETAniQ9V5PlHbG5aYMOWij6L9mxNqz6Ps/xknzJPUh1UL //RAeKbV1NaoGxF0qFt5WOThc6kFhIWWnIwIMJdsN471gGr7qzqL8E3/fIW5CNePEI7A iuQPbXBJHoxK4yRoM74dS+7oo3KYoClFn3GCJ1dflqRo6EnlQYo4scYe4aDJNEfTObQB EbZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=R2UE++Lz6+3GH5nL1uCwyFcmxQ7Wc2OaLYnXPbkk4wY=; b=w2055MYIQe1g+IGZu9Cn+bowD2QNJxxf1TEMUp9bHGo7S2NDJBaGJPivuPdd+obT/8 HdQl042ifqvy1EGW9gjDaBnkrTCJU9+FNE9Kf6KTpwxPkL1mmGyYpczV99ecUn4X41Cw Yeh6LRnQNZHlht9Vg60UVbmSKPZ4aL6en6JRM+MCZu+odkvIp/FrMESyVeIcpYw8uWzd 7XzmQZQp+uI28Y/Shc1e0rZMUwI6xRlS42oIiUR6OiIdszA56G+0PhPWAC7wobxJ3Rsi FXvVRGbOj8UYXAzIy5/+lb+xNCAR8jSOWgUiKy5Mz4700hEDJ58c83btzquA3WRqaNCU MHgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q46si3267010eda.44.2019.09.25.06.33.17; Wed, 25 Sep 2019 06:33:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439717AbfIWMzC (ORCPT + 99 others); Mon, 23 Sep 2019 08:55:02 -0400 Received: from regular1.263xmail.com ([211.150.70.200]:42354 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437464AbfIWMzB (ORCPT ); Mon, 23 Sep 2019 08:55:01 -0400 Received: from hjc?rock-chips.com (unknown [192.168.167.174]) by regular1.263xmail.com (Postfix) with ESMTP id D7EDA327; Mon, 23 Sep 2019 20:54:59 +0800 (CST) X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P29405T140104878241536S1569243297686069_; Mon, 23 Sep 2019 20:54:58 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <7f510e2dec1a5fec4a829d4e2f2a610e> X-RL-SENDER: hjc@rock-chips.com X-SENDER: hjc@rock-chips.com X-LOGIN-NAME: hjc@rock-chips.com X-FST-TO: dri-devel@lists.freedesktop.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Sandy Huang To: dri-devel@lists.freedesktop.org, Tomi Valkeinen , David Airlie , Daniel Vetter Cc: hjc@rock-chips.com, linux-kernel@vger.kernel.org Subject: [PATCH 36/36] drm/omapdrm: use bpp instead of cpp for drm_format_info Date: Mon, 23 Sep 2019 20:54:56 +0800 Message-Id: <1569243296-183701-1-git-send-email-hjc@rock-chips.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/omapdrm/omap_fb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c index 1b8b510..d18aafa 100644 --- a/drivers/gpu/drm/omapdrm/omap_fb.c +++ b/drivers/gpu/drm/omapdrm/omap_fb.c @@ -87,7 +87,7 @@ static u32 get_linear_addr(struct drm_framebuffer *fb, u32 offset; offset = fb->offsets[n] - + (x * format->cpp[n] / (n == 0 ? 1 : format->hsub)) + + (x * format->bpp[n] / 8 / (n == 0 ? 1 : format->hsub)) + (y * fb->pitches[n] / (n == 0 ? 1 : format->vsub)); return plane->dma_addr + offset; @@ -206,7 +206,7 @@ void omap_framebuffer_update_scanout(struct drm_framebuffer *fb, } /* convert to pixels: */ - info->screen_width /= format->cpp[0]; + info->screen_width /= format->bpp[0] / 8; if (fb->format->format == DRM_FORMAT_NV12) { plane = &omap_fb->planes[1]; @@ -382,10 +382,10 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev, goto fail; } - if (pitch % format->cpp[0]) { + if (pitch % (format->bpp[0] / 8)) { dev_dbg(dev->dev, "buffer pitch (%u bytes) is not a multiple of pixel size (%u bytes)\n", - pitch, format->cpp[0]); + pitch, format->bpp[0] / 8); ret = -EINVAL; goto fail; } -- 2.7.4