Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp753594ybn; Wed, 25 Sep 2019 07:15:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9zF8HxtWUtHcVabYsPpdsKV6CZHv3XYWwTaWIYIlGfgtoSTXux1Rt0FZ5NosnfyQ6YPi6 X-Received: by 2002:aa7:c2ce:: with SMTP id m14mr3171306edp.191.1569420939573; Wed, 25 Sep 2019 07:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569420939; cv=none; d=google.com; s=arc-20160816; b=07i6M4+fKxaCasvbz6T6U57/LqwDC7NujknGfDFukD4RvcMzEOGEIVVm2Mu7Y/lvsr Z51zjbgeMDTmWlEnn/rF+ndvNcbvyWvpNBUC6QwQEuO3rc1zxP96pRD8sX5hLpsS6pID CG2RAM9ftEtybfLeMDkhsiT2hlwYWwt5WYIAcyK3zk4CJf+8I4/I0Ef28jPxh9f1C4jL TcGRhcMXbe/rRpvUp6+QsycMRVAR8dX3JW6THHBL1HhZVrpIWqTVI05x094mtCekSNrc JVfRVAaQknFDwKdF09qf0A5JvvzKf8eZ3hj3ifBGQY6rP+y4FiddMF532ohLqstld2e3 +38w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hXQkKliC0S2X43voVjhiTVkMxCC4tIPV9acNAETqUso=; b=E4scmoqngzJrk4Waig3XzB8TOgFYgLNZdsyqiNq+KXDLoiOe1SA2aJdwzbMNgxeZs7 PeFh3QyKUcxBVK36ryKm40FOYzZXr1pnx8GOJbFQuZmwzsr2MAlBmzp6UoWW3SMoGoE+ UftMNegpCPuvkwTh9xuAd69qHCgbVUNTRXuhxhKAbi7F+GVQPCYvKDgTFEn+G58lKunj VJSM6pDHSo7YfC57E6jaT3nD31sx3GNS+HBnOpt4Ah2sqFVCEqLNzo+ipWVXPy6qEi2g gtCb/In/OM5m6U/kh+eLcdzSVtJtgDwxMHOhD8yaiIGWv12ynxUlXehA8m2JGxZ4Ay38 PEtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FeeJhFEY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gh12si2655717ejb.191.2019.09.25.07.15.11; Wed, 25 Sep 2019 07:15:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FeeJhFEY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408075AbfIWNfC (ORCPT + 99 others); Mon, 23 Sep 2019 09:35:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:58664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404581AbfIWNfC (ORCPT ); Mon, 23 Sep 2019 09:35:02 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45C0920820; Mon, 23 Sep 2019 13:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569245701; bh=hXQkKliC0S2X43voVjhiTVkMxCC4tIPV9acNAETqUso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FeeJhFEYpa8NQNgnmMZ03oC875vWZGIk2sDIDJW6viNc1wFklKbOaxWAIJZiDv3z9 VPL+5mYyMBGkryM57asvTYICU4x115rVu0DFVAjBJvQeXxR61BtdSSXkhiv2dR+/em 4ofSqLwfC02dVakvOgrS63rQNTOJczJ7yNnUIGkc= Date: Mon, 23 Sep 2019 09:35:00 -0400 From: Sasha Levin To: Laurent Pinchart Cc: Sakari Ailus , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.3 084/203] media: omap3isp: Don't set streaming state on random subdevs Message-ID: <20190923133500.GF8171@sasha-vm> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-84-sashal@kernel.org> <20190923071942.GJ5525@valkosipuli.retiisi.org.uk> <20190923072503.GA5056@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190923072503.GA5056@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 10:25:03AM +0300, Laurent Pinchart wrote: >On Mon, Sep 23, 2019 at 10:19:42AM +0300, Sakari Ailus wrote: >> Hi Sasha, >> >> On Sun, Sep 22, 2019 at 02:41:50PM -0400, Sasha Levin wrote: >> > From: Sakari Ailus >> > >> > [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] >> > >> > The streaming state should be set to the first upstream sub-device only, >> > not everywhere, for a sub-device driver itself knows how to best control >> > the streaming state of its own upstream sub-devices. >> > >> > Signed-off-by: Sakari Ailus >> > Reviewed-by: Laurent Pinchart >> > Signed-off-by: Mauro Carvalho Chehab >> > Signed-off-by: Sasha Levin >> >> I don't disagree with this going to the stable trees as well, but in that >> case it *must* be accompanied by commit e9eb103f0277 ("media: omap3isp: Set >> device on omap3isp subdevs") or the driver will mostly cease to work. >> >> Could you pick that up as well? > >While I don't disagree either, I also think there's no requirement to >get this commit backported to stable branches. It seems to be the result >of a too aggressive auto-selection. I'd very much agree that AUTOSEL is trying to be aggressive with it's patch selection (it's actually sort of like a "dial" I can adjust and now it's adjusted pretty high). However, please don't see it as something that is forced on you; if the maintainers disagree with patch selection please just let me know and it will dropped. The only reason I'm being aggressive with AUTOSEL is that I'm hopefull it will provide better experience for our users. -- Thanks, Sasha