Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190922173241.GA44503@rani.riverdale.lan>
In-Reply-To: <20190922173241.GA44503@rani.riverdale.lan>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 23 Sep 2019 09:15:16 -0700
Message-ID: <CAKwvOd=X9+uxQSzKad8B-Lw=ZarBT+SfNpBm_TE0k+DeJZmrsw@mail.gmail.com>
Subject: Re: kexec broken with STACKLEAK enabled
To:     Arvind Sankar <nivedita@alum.mit.edu>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 22, 2019 at 10:32 AM Arvind Sankar <nivedita@alum.mit.edu> wrote:
>
> Hi, since commit b059f801a937 (x86/purgatory: Use CFLAGS_REMOVE rather
> than reset KBUILD_CFLAGS) kexec is broken if GCC_PLUGIN_STACKLEAK is
> enabled, as the purgatory contains undefined references to
> stackleak_track_stack.
>
> Attempting to load a kexec kernel results in an error:
>
>         kexec: Undefined symbol: stackleak_track_stack
>         kexec-bzImage64: Loading purgatory failed
>
> Adding $(DISABLE_STACKLEAK_PLUGIN) to PURGATORY_CFLAGS in
> arch/x86/purgatory/Makefile fixes this.

Hi Arvind,
Thanks for the report.  That sounds like a straightforward fix.  Would
you like to send a patch for that?  I'd be happy to help review it.

>
> Not sure if that's the best fix or if other architectures also require a
> similar one.

The commit you reference should be x86 only.
-- 
Thanks,
~Nick Desaulniers