DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=YCt62uKoY7TpYlfWa3s4U80GbYMsHZBrDN9bxNiFRSsA5xada7tNtfos8L5ggL2xVfok7iTVZaV7VBETL2oUK4SV6CGWdSzZ7MELZWTZKQeYO+eemlMs973NBQoC5Hx+HVHwcSKZxGyEN4bjYCm8Dq930o3ieRcw3YR/dAnZD6Q=
Message-ID: <2cd57c900512310144o4aafd05en@mail.gmail.com>
Date: Sat, 31 Dec 2005 17:44:06 +0800
From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Yi Yang <yang.y.yi@gmail.com>
Subject: Re: [PATCH] Fix user data corrupted by old value return of sysctl
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, gregkh@suse.de,
       akpm@osdl.org
In-Reply-To: <43B64ECA.8090004@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <43B4F287.6080307@gmail.com>
	 <2cd57c900512310113i5467a258s@mail.gmail.com>
	 <43B64ECA.8090004@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 921
Lines: 26

2005/12/31, Yi Yang <yang.y.yi@gmail.com>:
> Coywolf Qi Hunt wrote:
> >You didn't set the trailing '\0', I wonder how your printf did work
> >properly ever. You've just been lucky or something.
> >
> >-- Coywolf
> >
> >
> The variable target does it, its value is 0x00000001, so you mustn't
> worry it.
> osname only has 4-bytes space, so if you set '\0' to its tail, a byte
> information will be lost.

I'm worrying more. We should set '\0'. Let the one byte information
lost, the caller deserve that. Actually here printf sees "mylo"+'\01'
if little endian.

Linus, besides fixing bug, your commit certainly breaks userland
compatibility. Please consider.
--
Coywolf Qi Hunt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/