Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 1/2] edac: Add an API for edac device to report for
 multiple errors
To:     Robert Richter <rrichter@marvell.com>
CC:     "bp@alien8.de" <bp@alien8.de>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
References: <20190919171713.8060-1-hhhawa@amazon.com>
 <20190919171713.8060-2-hhhawa@amazon.com>
 <20190920064155.f3xeqzobiud5hvxf@rric.localdomain>
From:   "Hawa, Hanna" <hhhawa@amazon.com>
Message-ID: <3d607fc4-73a1-cde7-51bf-31d807b1f438@amazon.com>
Date:   Mon, 23 Sep 2019 22:01:38 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20190920064155.f3xeqzobiud5hvxf@rric.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 9/20/2019 9:42 AM, Robert Richter wrote:
> On 19.09.19 18:17:12, Hanna Hawa wrote:
>> Add an API for EDAC device to report multiple errors with same type.
>>
>> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> 
> With the change below it looks good to me:
> 
> Acked-by: Robert Richter <rrichter@marvell.com>

Thanks

> 
> Thanks,
> 
> -Robert
> 
>> ---
>>   drivers/edac/edac_device.c | 62 ++++++++++++++++++++++++++------------
>>   drivers/edac/edac_device.h | 40 ++++++++++++++++++++++++
>>   2 files changed, 82 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
>> index 65cf2b9355c4..866934f2bcb0 100644
>> --- a/drivers/edac/edac_device.c
>> +++ b/drivers/edac/edac_device.c
>> @@ -555,12 +555,16 @@ static inline int edac_device_get_panic_on_ue(struct edac_device_ctl_info
>>   	return edac_dev->panic_on_ue;
>>   }
>>   
>> -void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
>> -			int inst_nr, int block_nr, const char *msg)
>> +void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
>> +			     unsigned int count, int inst_nr, int block_nr,
>> +			     const char *msg)
>>   {
>>   	struct edac_device_instance *instance;
>>   	struct edac_device_block *block = NULL;
>>   
>> +	if (!count)
>> +		return;
>> +
> 
> Those checks should be moved to the *_count() variants of both
> functions.

Will be moved to the inline functions.

> 
> [...]
> 
>> +static inline void edac_device_handle_ce_count(struct edac_device_ctl_info *edac_dev,
>> +					       unsigned int count, int inst_nr,
>> +					       int block_nr, const char *msg)
>> +{
> 
> 	if (count)
> 		...
> 
>> +	__edac_device_handle_ce(edac_dev, count, inst_nr, block_nr, msg);
>> +}
>> +
>> +static inline void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev,
>> +					       unsigned int count, int inst_nr,
>> +					       int block_nr, const char *msg)
>> +{
> 
> Here too.
> 
>> +	__edac_device_handle_ue(edac_dev, count, inst_nr, block_nr, msg);
>> +}

Thanks,
Hanna