Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     Daniel Wagner <dwagner@suse.de>,
        "QLogic-Storage-Upstream@cavium.com" 
        <QLogic-Storage-Upstream@cavium.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: qedf: Add port_id getter
Thread-Topic: [PATCH] scsi: qedf: Add port_id getter
Thread-Index: AQHVcfrzLGK4JScA4kqhj7Bwh5oaVac6WHaA
Date:   Tue, 24 Sep 2019 06:08:09 +0000
Message-ID: <MN2PR18MB25273EBD439B3458D6088610D2840@MN2PR18MB2527.namprd18.prod.outlook.com>
References: <20190923103738.67749-1-dwagner@suse.de>
In-Reply-To: <20190923103738.67749-1-dwagner@suse.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb2853c-e4ff-4d5e-9d2f-08d740b5930c
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2019 06:08:09.5550
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZiZfuAJv/KkxjFByLlDiXBFlxMFZy8z/oXNiRB7ieucxuSFNv5adUnm/e32BdLXsseLg75bfxJsGVv9hV/dmUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2973
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-09-24_03:2019-09-23,2019-09-24 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-owner@vger.kernel.org>=
 On
> Behalf Of Daniel Wagner
> Sent: Monday, September 23, 2019 4:08 PM
> To: QLogic-Storage-Upstream@cavium.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Wagn=
er
> <dwagner@suse.de>
> Subject: [PATCH] scsi: qedf: Add port_id getter
>=20
> Add qedf_get_host_port_id() to the transport template.
>=20
> The fc_transport_template initializes the port_id member to the default v=
alue of
> -1. The new getter ensures that the sysfs entry shows the current value a=
nd not
> the default one, e.g by using 'lsscsi -H -t'
>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  drivers/scsi/qedf/qedf_main.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.=
c index
> 9c24f3834d70..8fe8c3fdde1b 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -1926,6 +1926,13 @@ static int qedf_fcoe_reset(struct Scsi_Host *shost=
)
>  	return 0;
>  }
>=20
> +static void qedf_get_host_port_id(struct Scsi_Host *shost) {
> +	struct fc_lport *lport =3D shost_priv(shost);
> +
> +	fc_host_port_id(shost) =3D lport->port_id; }

Minor stuff, the closing brace should be in next line. Please submit v2.

Thanks,
~Saurav
> +
>  static struct fc_host_statistics *qedf_fc_get_host_stats(struct Scsi_Hos=
t
>  	*shost)
>  {
> @@ -1996,6 +2003,7 @@ static struct fc_function_template
> qedf_fc_transport_fn =3D {
>  	.show_host_active_fc4s =3D 1,
>  	.show_host_maxframe_size =3D 1,
>=20
> +	.get_host_port_id =3D qedf_get_host_port_id,
>  	.show_host_port_id =3D 1,
>  	.show_host_supported_speeds =3D 1,
>  	.get_host_speed =3D fc_get_host_speed,
> --
> 2.16.4