Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1398773ybn; Wed, 25 Sep 2019 17:46:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzC8lEfmOzK+u3hgJEsk4X2ZPAOVt6hpRTwCwZJXtxrb4t/LZvhrVk3+UfBLX+Lh+Qm6Pjl X-Received: by 2002:a17:906:944b:: with SMTP id z11mr864994ejx.46.1569458776120; Wed, 25 Sep 2019 17:46:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569458776; cv=none; d=google.com; s=arc-20160816; b=e8OthBWR2AB2q9HXDMuIrkn4knl4R27hHL48wsmYpnpG625jdxl5XP0NY5nT3/NZtD D/8HVN/9w+IWoh3fg1CKuFfA32sPWpH4hN2xmYK7v76WCWl5YnWC0geCK2rzMYcHYzP6 dVvsXxpUIyzPiHDfZf57IwB6t89yu6E24PQT3yitMsePtr+LTxW2YxUMYMTT2O/SywES LuwovLUTpC4jn4yBJDDMh2gPBsOd5OtvFhZP3DR/uFhC4enYB6NIyilwf0KXGwhIa0GL 94gTsDOjURmArYO4WN149QvA++mNHbTxtPQ+iv6T0u+kxR3NUlfDkG8M+ztYNmEdBqMs vEiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=YMeDYjBxF67X3O62wFpjbVoKh3D7HMbJtU4fhWR08SQ=; b=C4GSxLzUYB+7qFwqAu3Pc1chPyud0jOBkxj3S11yPuGdZQ8qGcyP+viH89F32PvTH2 cW5btcerXhfdS7DkYcvND0LX3wgzBw/08oYQt5xpzJP2jtIrJbZ6EfvoN+vd86zMKLrR 3GGgtcoBnNLvdJXjzFjZ6abQLFxEUxPwDHt0EeY+xR6Jwlz+OdVJjeS6MoTUBhpgQFoZ CNI93aE3zS9mp2VV9sKg550qxhmFyGrIMUUQVwrA/PR9/Y6LKfAGugxmDpHXEzgv4C3N 5sly4IazFa2sPliBB0iFMgaHcgTMKe9DcGSC5HPaOfQ1smnJqF1FnxsaOvrlUb90YW0A 3sTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8si396045edq.84.2019.09.25.17.45.52; Wed, 25 Sep 2019 17:46:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407944AbfIXHLo (ORCPT + 99 others); Tue, 24 Sep 2019 03:11:44 -0400 Received: from mail.monom.org ([188.138.9.77]:44748 "EHLO mail.monom.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388209AbfIXHLo (ORCPT ); Tue, 24 Sep 2019 03:11:44 -0400 Received: from mail.monom.org (localhost [127.0.0.1]) by filter.mynetwork.local (Postfix) with ESMTP id 2ABB5500114; Tue, 24 Sep 2019 09:11:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.monom.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (b9168f76.cgn.dg-w.de [185.22.143.118]) by mail.monom.org (Postfix) with ESMTPSA id EAE2F5000E6; Tue, 24 Sep 2019 09:11:41 +0200 (CEST) Date: Tue, 24 Sep 2019 09:11:38 +0200 From: Daniel Wagner To: Saurav Kashyap Cc: "QLogic-Storage-Upstream@cavium.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] scsi: qedf: Add port_id getter Message-ID: <20190924071138.pifkyd75xhrminnt@beryllium.lan> References: <20190923103738.67749-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 24, 2019 at 06:08:09AM +0000, Saurav Kashyap wrote: > > +static void qedf_get_host_port_id(struct Scsi_Host *shost) { > > + struct fc_lport *lport = shost_priv(shost); > > + > > + fc_host_port_id(shost) = lport->port_id; } > > Minor stuff, the closing brace should be in next line. Please submit v2. Oops, sorry about that. Thanks Daniel