Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "QLogic-Storage-Upstream@cavium.com" 
        <QLogic-Storage-Upstream@cavium.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] scsi: qedf: Add port_id getter
Thread-Topic: [EXT] Re: [PATCH] scsi: qedf: Add port_id getter
Thread-Index: AQHVcfrzLGK4JScA4kqhj7Bwh5oaVac6WHaAgAASMQCAAANZgIAAHYaQ
Date:   Tue, 24 Sep 2019 09:10:23 +0000
Message-ID: <MN2PR18MB2527C8FC1902CA98123E2231D2840@MN2PR18MB2527.namprd18.prod.outlook.com>
References: <20190923103738.67749-1-dwagner@suse.de>
 <MN2PR18MB25273EBD439B3458D6088610D2840@MN2PR18MB2527.namprd18.prod.outlook.com>
 <20190924071138.pifkyd75xhrminnt@beryllium.lan>
 <20190924072337.rfmgmyw2pjoi2lgx@beryllium.lan>
In-Reply-To: <20190924072337.rfmgmyw2pjoi2lgx@beryllium.lan>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d40ac632-9d15-49d1-054e-08d740cf086c
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2019 09:10:23.8790
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8DpaEqSd4GzawYb0AJYKZdhJJ0bHH+ibgpzSC3Oc0bnaN/rEtuFODgjMzdF5HqVs2Dzj5Mtx886dUVAUJ1ju6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3183
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-09-24_04:2019-09-23,2019-09-24 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Daniel,

> -----Original Message-----
> From: Daniel Wagner <dwagner@suse.de>
> Sent: Tuesday, September 24, 2019 12:54 PM
> To: Saurav Kashyap <skashyap@marvell.com>
> Cc: QLogic-Storage-Upstream@cavium.com; linux-scsi@vger.kernel.org; linux=
-
> kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH] scsi: qedf: Add port_id getter
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> Hi Saurav,
>=20
> On Tue, Sep 24, 2019 at 09:11:38AM +0200, Daniel Wagner wrote:
> > On Tue, Sep 24, 2019 at 06:08:09AM +0000, Saurav Kashyap wrote:
> > > > +static void qedf_get_host_port_id(struct Scsi_Host *shost) {
> > > > +	struct fc_lport *lport =3D shost_priv(shost);
> > > > +
> > > > +	fc_host_port_id(shost) =3D lport->port_id; }
> > >
> > > Minor stuff, the closing brace should be in next line. Please submit =
v2.
> >
> > Oops, sorry about that.
>=20
> The patch I sent out had the closing brace on a new
> line:
>=20
> https://lore.kernel.org/linux-scsi/20190923103738.67749-1-dwagner@suse.de=
/
>=20
> Now I am a bit confused how I screwed it up. Anyway, I'll send it out
> again after with hexdump there is not a special ASCII character
> hidden :)

Sorry about that, I changed my email client and it remove the extra lines.

Thanks,
~Saurav
>=20
> Thanks,
> Daniel