Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Support Opensource <Support.Opensource@diasemi.com>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        Steve Twiss <stwiss.opensource@diasemi.com>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage
 selection documentation
Thread-Topic: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage
 selection documentation
Thread-Index: AQHVbVV1957uISHJUEeJggkt0eobi6c6l9Dg
Date:   Tue, 24 Sep 2019 09:23:32 +0000
Message-ID: <AM5PR1001MB0994ABEF9C32BFB7BEA099B680840@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
References: <20190917124246.11732-1-m.felsch@pengutronix.de>
 <20190917124246.11732-3-m.felsch@pengutronix.de>
In-Reply-To: <20190917124246.11732-3-m.felsch@pengutronix.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a7a31840-e8b9-4113-b31f-08d740d0de73
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:AM5PR1001MB0961;
x-ms-traffictypediagnostic: AM5PR1001MB0961:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM5PR1001MB096150DCBEAFC7B22ECFEDF4A7840@AM5PR1001MB0961.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0170DAF08C
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(346002)(136003)(396003)(376002)(39850400004)(189003)(199004)(81156014)(81166006)(71190400001)(8676002)(4326008)(186003)(229853002)(64756008)(66946007)(66446008)(11346002)(54906003)(52536014)(446003)(66066001)(76176011)(8936002)(66556008)(110136005)(25786009)(26005)(76116006)(478600001)(316002)(14454004)(33656002)(486006)(66476007)(5660300002)(55016002)(7736002)(6246003)(476003)(2906002)(7696005)(53546011)(6116002)(6436002)(86362001)(6636002)(3846002)(102836004)(305945005)(256004)(9686003)(74316002)(55236004)(71200400001)(6506007)(2501003)(99286004)(14444005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR1001MB0961;H:AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 6H9tcJOvfaaKNqg6lTRWdpDDCgPLZWPzll045IvS8LI3NXJdN3DpLKOWwbiawu1gbd/Nw6b7uMruvkid32WiQFLZpsgzGGbK0FIkXrWzzLtqefozdEz+d3sKl9gV1SetV+qFt7qZjf4/oLYXbxcxBDv1F/5YtvssD/1UpYP0JaxBo53ArPJ6UbQFuH45tpgMi4PllSAHs2/0KfEeH9u0vQwd41+SsKYwzPZVI/404uBhsCFXTE26dtDJ5z+0/u+9eBnMCpRcPZ5hJ8pzZMjyJF+zf8M9QBuH2EV/lR8R6CXl/7C5nlR80QGtCf3rpxXqjioXNfvbfp8qkzlRmf1TOHKwLQOoNbK62SOnLKDKuSHOft3a5RW1tQ9BdVDfj9VFLeE6sPJe71iMebXZWNELckPjpzejhU/ZPmUoArvL9/U=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7a31840-e8b9-4113-b31f-08d740d0de73
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2019 09:23:32.4554
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: naGxXCuJsrj8UVChb9XX6bP47P35syaVzGTKvlYtV5BiHTn39uxCAtT7NBxT83fTGlZ2auJ2P9V7Ky6td9ATNnI+bxHjPdrAtxfNE19j3/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR1001MB0961
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17 September 2019 13:43, Marco Felsch wrote:

> Add the documentation which describe the voltage selection gpio support.
> This property can be applied to each subnode within the 'regulators'
> node so each regulator can be configured differently.
>=20
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/mfd/da9062.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt
> b/Documentation/devicetree/bindings/mfd/da9062.txt
> index edca653a5777..9d9820d8177d 100644
> --- a/Documentation/devicetree/bindings/mfd/da9062.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9062.txt
> @@ -66,6 +66,15 @@ Sub-nodes:
>    details of individual regulator device can be found in:
>    Documentation/devicetree/bindings/regulator/regulator.txt
>=20
> +  Optional regulator device-specific properties:
> +  - dlg,vsel-sense-gpios : The GPIO reference which should be used by th=
e
> +    regulator to switch the voltage between active/suspend voltage setti=
ngs. If
> +    the signal is active the active-settings are applied else the suspen=
d
> +    settings are applied. Attention: Sharing the same gpio for other pur=
poses
> +    or across multiple regulators is possible but the gpio settings must=
 be the
> +    same. Also the gpio phandle must refer to to the dlg,da9062-gpio dev=
ice
> +    other gpios are not allowed and make no sense.
> +

Should we not use the binding names that are defined in 'gpio-regulator.yam=
l' as
these seem to be generic and would probably serve the purpose here?

>  - rtc : This node defines settings required for the Real-Time Clock asso=
ciated
>    with the DA9062. There are currently no entries in this binding, howev=
er
>    compatible =3D "dlg,da9062-rtc" should be added if a node is created.
> --
> 2.20.1