Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1447057ybn; Wed, 25 Sep 2019 18:43:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqz5JgOvi9TrfGIYlQHQB2oxNJU2SSw3bQ6Mvybvg9Otau2FRRpK+gpUBxuZmBLp2XVVfmgJ X-Received: by 2002:a17:906:25ca:: with SMTP id n10mr1060548ejb.106.1569462212836; Wed, 25 Sep 2019 18:43:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569462212; cv=none; d=google.com; s=arc-20160816; b=1EOqo5irlcrmT91uHCA2veHZYZWeFsP50HadMda+lFY8ViU7j+qXP10EONt15o2e6s EdMdhBGNMk2EgZdZ3EQSu5JP+vS+orAGR73Nw8mGLIqkGdQNMswcM9ZRZd2moU0ITLnn X94daRU5au6f3Z7eX217aNQ15ihAy++Y6OP6gwTSK/btSQ9NV0rqqdi3QkpHo0zDitZA RXAcRyF77kUyXC8Rl4S4++H2xvKAxG2F09PajeRImpHXWOU5zFAun1BNc4sRK8MdfpCQ m76/ANPdMOtajt0QPIUHkkRqyI9Gb1izTtF6lcac77cLBIcZu6uZtln3HGZn/PtRZkqK mwdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6YlsGuRqgiV/EQBRpxOK559NlHgYrAL9EgTx9nyDQOQ=; b=CyOt/TRpW/OcPE4gq1J7JQKcTkKVaoTcos4rEJcKcmTru+R3iwMed6ls/Jiy6F+3CI GJnv5XzX6AY3h8dt4OiY85GapkpYNtTNCxksHyZX71dcsb8itsOcsUPz6XBCvfZOhESn kdOVnJ3/g08W1tYfVtSZUj35GZdNgdghfnMhP7L6xqH2F+g2jXhho2fUg5gkhMdq1mSY FZdncNHEsq2Uwp3oc64uAk4ge3lpSkXNjU08vYbaJQIgT4ygtYID5Wv/2CALfDd3Mx1d YiRWTSGbnXyUXFWHUa0xATwprmwauIpFplp4eSs8DBA4SaTtTUvhDhQ6PoMnQ8VlC/UD C5iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NkuCyu6W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b21si299990ejq.343.2019.09.25.18.43.09; Wed, 25 Sep 2019 18:43:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NkuCyu6W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440841AbfIXLdR (ORCPT + 99 others); Tue, 24 Sep 2019 07:33:17 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44950 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438702AbfIXLdR (ORCPT ); Tue, 24 Sep 2019 07:33:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6YlsGuRqgiV/EQBRpxOK559NlHgYrAL9EgTx9nyDQOQ=; b=NkuCyu6W/NM8LZwPz7z2JX7pl n1dbz0nvj4SKPsWoXxfaugHiPu/R0bz0FP6ckp4QUHeqCVfoVMWMpIoi7jYnpBkutQVmNZrHd8F6d nBsIGbaU0ZjiGtjiKaaKEVSGSqfsLsj33WUZmVYAchwqTZrnru8tRmt3oYdAEwRrSXV9nIByga9W6 6OUNpuLSBYv/E1Ts3w9+FvU6MRFpEKfkHkmh1oO1DdeWDvdx19xNHE2qUhGsWFMAv54r2hUgIXwlU ZXr18pNldMaSmMBxXJmN2WSrD022Mk6TbsJ2AQkfv51XznXXe2mJhz6YC4M+lCmfNrn7Sn6y/yJ8X h0dBFpopA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCj43-0001Vx-7W; Tue, 24 Sep 2019 11:33:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C211C305E35; Tue, 24 Sep 2019 13:32:14 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5A83C29E510E7; Tue, 24 Sep 2019 13:33:00 +0200 (CEST) Date: Tue, 24 Sep 2019 13:33:00 +0200 From: Peter Zijlstra To: Jens Axboe Cc: Pavel Begunkov , Ingo Molnar , Ingo Molnar , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Optimise io_uring completion waiting Message-ID: <20190924113300.GL2332@hirez.programming.kicks-ass.net> References: <731b2087-7786-5374-68ff-8cba42f0cd68@kernel.dk> <759b9b48-1de3-1d43-3e39-9c530bfffaa0@kernel.dk> <43244626-9cfd-0c0b-e7a1-878363712ef3@gmail.com> <20190924094942.GN2349@hirez.programming.kicks-ass.net> <6f935fb9-6ebd-1df1-0cd0-69e34a16fa7e@kernel.dk> <29e6e06e-351f-c19d-ed7c-51f30c9ca887@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29e6e06e-351f-c19d-ed7c-51f30c9ca887@kernel.dk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 24, 2019 at 12:34:17PM +0200, Jens Axboe wrote: > Just took a quick look at it, and ran into block/kyber-iosched.c that > actually uses the private pointer for something that isn't a task > struct... Argh... that's some 'creative' abuse of the waitqueue API :/