Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] edac: move edac_device_handle_*() API functions to
 header
To:     Robert Richter <rrichter@marvell.com>
CC:     "bp@alien8.de" <bp@alien8.de>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
References: <20190919171713.8060-1-hhhawa@amazon.com>
 <20190919171713.8060-3-hhhawa@amazon.com>
 <20190920064937.owwv5n663kwmnbb7@rric.localdomain>
From:   "Hawa, Hanna" <hhhawa@amazon.com>
Message-ID: <b0442e2c-a7c7-cbfc-9b0a-24b97d1356c9@amazon.com>
Date:   Mon, 23 Sep 2019 22:01:19 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20190920064937.owwv5n663kwmnbb7@rric.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 9/20/2019 9:49 AM, Robert Richter wrote:
> On 19.09.19 18:17:13, Hanna Hawa wrote:
>> Move edac_device_handle_*() functions from source file to header file as
>> inline funtcion that use the new API with single error.
>>
>> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> 
> With the changes below it looks good to me:
> 
> Acked-by: Robert Richter <rrichter@marvell.com>
> 
> Thanks,
> 
> -Robert
> 
>> diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h
>> index 30dc5f5979c8..796ea134a691 100644
>> --- a/drivers/edac/edac_device.h
>> +++ b/drivers/edac/edac_device.h
>> @@ -285,29 +285,6 @@ extern int edac_device_add_device(struct edac_device_ctl_info *edac_dev);
>>    */
>>   extern struct edac_device_ctl_info *edac_device_del_device(struct device *dev);
>>   
>> -/**
>> - * edac_device_handle_ue():
>> - *	perform a common output and handling of an 'edac_dev' UE event
>> - *
>> - * @edac_dev: pointer to struct &edac_device_ctl_info
>> - * @inst_nr: number of the instance where the UE error happened
>> - * @block_nr: number of the block where the UE error happened
>> - * @msg: message to be printed
>> - */
>> -extern void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
>> -				int inst_nr, int block_nr, const char *msg);
>> -/**
>> - * edac_device_handle_ce():
>> - *	perform a common output and handling of an 'edac_dev' CE event
>> - *
>> - * @edac_dev: pointer to struct &edac_device_ctl_info
>> - * @inst_nr: number of the instance where the CE error happened
>> - * @block_nr: number of the block where the CE error happened
>> - * @msg: message to be printed
>> - */
>> -extern void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
>> -				int inst_nr, int block_nr, const char *msg);
>> -
> 
> Just put in the inline replacement here.

I'll re-arrange the functions in patches 1/2 and put the 
*edac_device_handle_* functions here instead of end of file.

> 
>>   /**
>>    * edac_device_alloc_index: Allocate a unique device index number
>>    *
>> @@ -357,4 +334,18 @@ static inline void edac_device_handle_ue_count(struct edac_device_ctl_info *edac
>>   {
>>   	__edac_device_handle_ue(edac_dev, count, inst_nr, block_nr, msg);
>>   }
>> +
>> +static inline void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
>> +					 int inst_nr, int block_nr,
> 
> No need for this linebreak.

It'll be more than 80 characters.

> 
>> +					 const char *msg)
>> +{
>> +	__edac_device_handle_ce(edac_dev, 1, inst_nr, block_nr, msg);
>> +}
>> +
>> +static inline void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
>> +					 int inst_nr, int block_nr,
> 
> Same here.
> 
>> +					 const char *msg)
>> +{
>> +	__edac_device_handle_ue(edac_dev, 1, inst_nr, block_nr, msg);
>> +}
>>   #endif
>> -- 
>> 2.17.1
>>